Update footer terms for ai amount extraction [chromium/src : main]

0 views
Skip to first unread message

James Sun (Gerrit)

unread,
Dec 19, 2025, 3:12:16 PM (7 days ago) Dec 19
to Longsheng Yin, chromium...@chromium.org, armalhotra+a...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Longsheng Yin

James Sun added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
James Sun . unresolved

Thanks Longsheng!

Per UX discussion, the footer note we are showing on current UI is correct. But let's keep this CL as pending just in case if the UX team had any update during the implementation review process.

Open in Gerrit

Related details

Attention is currently required from:
  • Longsheng Yin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7670a166a9313c94ec52bb3bfaffc4e746602dda
Gerrit-Change-Number: 7281275
Gerrit-PatchSet: 3
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: James Sun <jame...@google.com>
Gerrit-Attention: Longsheng Yin <long...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 20:12:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

James Sun (Gerrit)

unread,
Dec 24, 2025, 11:50:15 AM (2 days ago) Dec 24
to Longsheng Yin, chromium...@chromium.org, armalhotra+a...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Longsheng Yin

James Sun added 1 comment

Patchset-level comments
James Sun . unresolved

Thanks Longsheng!

Per UX discussion, the footer note we are showing on current UI is correct. But let's keep this CL as pending just in case if the UX team had any update during the implementation review process.

James Sun

Hi Longsheng, based on UX review, what they want is `Google uses information from the checkout page and other relevant data to offer these options. To hide pay later options in autofill, go to payment settings.`.

Can you help update this? thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Longsheng Yin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7670a166a9313c94ec52bb3bfaffc4e746602dda
Gerrit-Change-Number: 7281275
Gerrit-PatchSet: 3
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: James Sun <jame...@google.com>
Gerrit-Attention: Longsheng Yin <long...@google.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 16:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: James Sun <jame...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

James Sun (Gerrit)

unread,
8:02 PM (3 hours ago) 8:02 PM
to Longsheng Yin, chromium...@chromium.org, armalhotra+a...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Longsheng Yin

James Sun added 1 comment

File components/autofill_payments_strings.grdp
Line 977, Patchset 3 (Latest): Google uses information from the checkout page and other relevant data to offer these options. To hide over time options in autofill, go to <ph name="IDS_AUTOFILL_CARD_BNPL_SELECT_PROVIDER_FOOTNOTE_HIDE_OPTION_PAYMENT_SETTINGS_LINK_TEXT">$1<ex>payment settings</ex></ph>.
James Sun . unresolved

based on our discussion and ux review mock: https://screenshot.googleplex.com/4F9VEtLCiLpcwh7, this should be "To hide pay later options in autofill,". Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Longsheng Yin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7670a166a9313c94ec52bb3bfaffc4e746602dda
Gerrit-Change-Number: 7281275
Gerrit-PatchSet: 3
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: James Sun <jame...@google.com>
Gerrit-Attention: Longsheng Yin <long...@google.com>
Gerrit-Comment-Date: Sat, 27 Dec 2025 01:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Longsheng Yin (Gerrit)

unread,
8:06 PM (3 hours ago) 8:06 PM
to James Sun, chromium...@chromium.org, armalhotra+a...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from James Sun

Longsheng Yin added 1 comment

File components/autofill_payments_strings.grdp
Line 977, Patchset 3 (Latest): Google uses information from the checkout page and other relevant data to offer these options. To hide over time options in autofill, go to <ph name="IDS_AUTOFILL_CARD_BNPL_SELECT_PROVIDER_FOOTNOTE_HIDE_OPTION_PAYMENT_SETTINGS_LINK_TEXT">$1<ex>payment settings</ex></ph>.
James Sun . resolved

based on our discussion and ux review mock: https://screenshot.googleplex.com/4F9VEtLCiLpcwh7, this should be "To hide pay later options in autofill,". Thanks!

Longsheng Yin

I forgot the branch name of this CL, so updated in https://chromium-review.googlesource.com/c/chromium/src/+/7330964, sorry for the confusion.

Open in Gerrit

Related details

Attention is currently required from:
  • James Sun
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7670a166a9313c94ec52bb3bfaffc4e746602dda
Gerrit-Change-Number: 7281275
Gerrit-PatchSet: 3
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: James Sun <jame...@google.com>
Gerrit-Attention: James Sun <jame...@google.com>
Gerrit-Comment-Date: Sat, 27 Dec 2025 01:06:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: James Sun <jame...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Longsheng Yin (Gerrit)

unread,
8:15 PM (3 hours ago) 8:15 PM
to James Sun, chromium...@chromium.org, armalhotra+a...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Longsheng Yin abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages