Prerender2Fallback: Enable by default on Android [chromium/src : main]
0 views
Skip to first unread message
Ken Okada (Gerrit)
Jun 17, 2026, 8:12:25 PMJun 17
to Hiroki Nakagawa, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Hiroki Nakagawa
Ken Okada added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hiroki Nakagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroki Nakagawa (Gerrit)
Jun 18, 2026, 12:50:11 AMJun 18
to Ken Okada, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Ken Okada
Hiroki Nakagawa voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hiroki Nakagawa
| Code-Review | +1 |
2 comments
Patchset-level comments
Hiroki Nakagawa . resolved
LGTM, thanks!
File testing/variations/fieldtrial_testing_config.json
Line 19686, Patchset 4 (Parent):
],Hiroki Nakagawa . unresolved
Should we keep running this for WebView?
Related details
Attention is currently required from:
- Ken Okada
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Okada (Gerrit)
Jun 18, 2026, 5:06:06 PMJun 18
to Avi Drissman, Kent Tamura, Peter Conn, Hiroki Nakagawa, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Avi Drissman, Hiroki Nakagawa, Kent Tamura and Peter Conn
Ken Okada added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Ken Okada . resolved
Owner review. Could you have a look?
peconn@
- android_webview/browser/aw_field_trials.cc
avi@
- content/public/common/content_features.*
tkent@
- third_party/blink/web_tests/VirtualTestSuites
File testing/variations/fieldtrial_testing_config.json
Hiroki Nakagawa . resolved
Should we keep running this for WebView?
Attention is currently required from:
- Avi Drissman
- Hiroki Nakagawa
- Kent Tamura
- Peter Conn
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Jun 18, 2026, 5:15:45 PMJun 18
to Ken Okada, Avi Drissman, Kent Tamura, Peter Conn, Hiroki Nakagawa, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Hiroki Nakagawa, Ken Okada, Kent Tamura and Peter Conn
Avi Drissman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Avi Drissman
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Hiroki Nakagawa
- Ken Okada
- Kent Tamura
- Peter Conn
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jun 18, 2026, 6:35:04 PMJun 18
to Ken Okada, Kent Tamura, Avi Drissman, Peter Conn, Hiroki Nakagawa, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Hiroki Nakagawa, Ken Okada and Peter Conn
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hiroki Nakagawa
- Ken Okada
- Peter Conn
Hiroki Nakagawa (Gerrit)
Jun 18, 2026, 7:28:30 PMJun 18
to Ken Okada, Kent Tamura, Avi Drissman, Peter Conn, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Ken Okada and Peter Conn
Hiroki Nakagawa voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ken Okada
- Peter Conn
Peter Conn (Gerrit)
Jun 19, 2026, 4:46:40 AMJun 19
to Ken Okada, Peter Beverloo, Hiroki Nakagawa, Kent Tamura, Avi Drissman, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Ken Okada
Peter Conn voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peter Conn
| Code-Review | +1 |
1 comment
Patchset-level comments
Peter Conn . unresolved
Code LGTM, but could you provide some context for why this isn't getting enabled on WebView?
+cc peter@ who's keeping track of such things.
Related details
Attention is currently required from:
- Ken Okada
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Okada (Gerrit)
Jun 19, 2026, 2:28:44 PMJun 19
to Peter Conn, Peter Beverloo, Hiroki Nakagawa, Kent Tamura, Avi Drissman, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Peter Conn
Ken Okada added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Peter Conn . unresolved
Code LGTM, but could you provide some context for why this isn't getting enabled on WebView?
+cc peter@ who's keeping track of such things.
Ken Okada
WebView was out of scope when this project was originally started (At that timing, IIRC, SpecRules was not enabled or just launched.), and now we are starting an experiment on WebView.
Related details
Attention is currently required from:
- Peter Conn
Avi Drissman (Gerrit)
Jun 19, 2026, 4:44:47 PMJun 19
to Ken Okada, Peter Conn, Peter Beverloo, Hiroki Nakagawa, Kent Tamura, Avi Drissman, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Ken Okada and Peter Conn
Avi Drissman added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Avi Drissman . resolved
content features lg
Attention is currently required from:
- Ken Okada
- Peter Conn
Peter Conn (Gerrit)
Jun 22, 2026, 4:25:05 AM (12 days ago) Jun 22
to Ken Okada, Peter Beverloo, Hiroki Nakagawa, Kent Tamura, Avi Drissman, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Ken Okada
Peter Conn added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Peter Conn . resolved
Ken OkadaCode LGTM, but could you provide some context for why this isn't getting enabled on WebView?
+cc peter@ who's keeping track of such things.
WebView was out of scope when this project was originally started (At that timing, IIRC, SpecRules was not enabled or just launched.), and now we are starting an experiment on WebView.
Peter Conn
Acknowledged
Related details
Attention is currently required from:
- Ken Okada
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Okada (Gerrit)
Jun 22, 2026, 7:19:19 AM (12 days ago) Jun 22
to Peter Conn, Peter Beverloo, Hiroki Nakagawa, Kent Tamura, Avi Drissman, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Ken Okada voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Okada
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Peter Conn . resolved
Ken OkadaCode LGTM, but could you provide some context for why this isn't getting enabled on WebView?
+cc peter@ who's keeping track of such things.
WebView was out of scope when this project was originally started (At that timing, IIRC, SpecRules was not enabled or just launched.), and now we are starting an experiment on WebView.
Chromium LUCI CQ (Gerrit)
Jun 22, 2026, 8:59:01 AM (12 days ago) Jun 22
to Ken Okada, Peter Conn, Peter Beverloo, Hiroki Nakagawa, Kent Tamura, Avi Drissman, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prerender2Fallback: Enable by default on Android
This CL enables a feature flag Prerender2FallbackPrefetchSpecRules
except for Android WebView. This CL also updates scheduler option not to
prioritize prefetch ahead of prerender.
Moving the feature flag from prerender_features.h to content_features.h
because we need to disable it on Android WebView.
Bug: 342089123
Change-Id: I72333902530652871765a5ea24d314078860f1aa
Reviewed-by: Peter Conn <pec...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Ken Okada <ken...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1650262}
Files:
- M android_webview/browser/aw_field_trials.cc
- M content/browser/preloading/preloading_decider_browsertest.cc
- M content/browser/preloading/prerender/prerender_browsertest.cc
- M content/browser/preloading/prerender/prerender_features.cc
- M content/browser/preloading/prerender/prerender_features.h
- M content/browser/preloading/prerender/prerender_host_registry_unittest.cc
- M content/browser/preloading/prerenderer_impl_unittest.cc
- M content/public/common/content_features.cc
- M content/public/common/content_features.h
- M testing/variations/fieldtrial_testing_config.json
- M third_party/blink/web_tests/VirtualTestSuites
Change size: M
Delta: 11 files changed, 22 insertions(+), 51 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Peter Conn, +1 by Kent Tamura, +1 by Hiroki Nakagawa, +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages