Fix FindBugs warnings (issue 11369052)

3 views
Skip to first unread message

skyo...@chromium.org

unread,
Nov 2, 2012, 2:35:48 PM11/2/12
to bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
Reviewers: bulach,

Description:
Fix FindBugs warnings


BUG=


Please review this at https://codereview.chromium.org/11369052/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M
chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java
M
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java


Index:
chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java
b/chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java
index
40f33e1b199256f5409ba411fe4a41e3de3a9671..0e2f56b3a5d81face5072865153dd102d86c0a05
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java
@@ -14,10 +14,7 @@ import org.chromium.base.CalledByNative;

public class GoogleLocationSettingsHelperStub implements
GoogleLocationSettingsHelper {

- private Context mApplicationContext;
-
public GoogleLocationSettingsHelperStub(Context context) {
- mApplicationContext = context.getApplicationContext();
}

@Override
Index:
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git
a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index
b087475d21e1503a57638ffd01fd4118623e97f6..084839c7287a168d1670fab1302716042695676d
100644
---
a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++
b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -2174,7 +2174,7 @@ public class ContentViewCore implements
MotionEventDelegate {
* @param tickTimeMicros The latest vsync tick time in microseconds.
* @param intervalMicros The vsync interval in microseconds.
*/
- public void UpdateVSync(long tickTimeMicros, long intervalMicros) {
+ public void updateVSync(long tickTimeMicros, long intervalMicros) {
if (mNativeContentViewCore != 0) {
nativeUpdateVSyncParameters(mNativeContentViewCore,
tickTimeMicros, intervalMicros);
}


bul...@chromium.org

unread,
Nov 5, 2012, 4:43:05 AM11/5/12
to skyo...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
lgtm, thanks!

https://codereview.chromium.org/11369052/

commi...@chromium.org

unread,
Nov 5, 2012, 5:35:12 AM11/5/12
to skyo...@chromium.org, bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyo...@chromium.org/11369052/1


https://chromiumcodereview.appspot.com/11369052/

skyo...@chromium.org

unread,
Nov 5, 2012, 6:26:45 AM11/5/12
to bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
Added a temporary shim to avoid breaking downstream build. PTAL?

https://codereview.chromium.org/11369052/

bul...@chromium.org

unread,
Nov 5, 2012, 6:28:33 AM11/5/12
to skyo...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
lgtm, thanks!

https://codereview.chromium.org/11369052/

commi...@chromium.org

unread,
Nov 5, 2012, 6:29:08 AM11/5/12
to skyo...@chromium.org, bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyo...@chromium.org/11369052/1003


https://chromiumcodereview.appspot.com/11369052/

commi...@chromium.org

unread,
Nov 5, 2012, 9:37:13 AM11/5/12
to skyo...@chromium.org, bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
Retried try job too often for step(s) content_browsertests

https://chromiumcodereview.appspot.com/11369052/

commi...@chromium.org

unread,
Nov 5, 2012, 9:39:29 AM11/5/12
to skyo...@chromium.org, bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org

commi...@chromium.org

unread,
Nov 5, 2012, 11:39:55 AM11/5/12
to skyo...@chromium.org, bul...@chromium.org, chromium...@chromium.org, joi+watc...@chromium.org, dari...@chromium.org, j...@chromium.org
Change committed as 165944

https://chromiumcodereview.appspot.com/11369052/
Reply all
Reply to author
Forward
0 new messages