updater: set the default load flags at link time for updatersetup [chromium/src : main]
0 views
Skip to first unread message
Sorin Jianu (Gerrit)
Jun 16, 2026, 4:45:51 PM (12 days ago) Jun 16
to Will Harris, S Ganesh, chromium...@chromium.org
Attention needed from S Ganesh and Will Harris
Sorin Jianu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sorin Jianu
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- S Ganesh
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
S Ganesh (Gerrit)
Jun 16, 2026, 6:17:17 PM (12 days ago) Jun 16
to Sorin Jianu, Chromium LUCI CQ, Will Harris, chromium...@chromium.org
Attention needed from Sorin Jianu and Will Harris
S Ganesh voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Sorin Jianu
- Will Harris
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
Jun 17, 2026, 2:09:00 PM (11 days ago) Jun 17
to Sorin Jianu, Will Harris, S Ganesh, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sorin Jianu
Will Harris voted and added 1 comment![]( "Open in Gerrit")
Votes added by Will Harris
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Will Harris . resolved
nice. I wonder if we should apply this more widely?
Related details
Attention is currently required from:
- Sorin Jianu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 17, 2026, 2:17:57 PM (11 days ago) Jun 17
to Sorin Jianu, Will Harris, S Ganesh, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
updater: set the default load flags at link time for updatersetup
The link option /DEPENDENTLOADFLAG:0x800 which corresponds to
LOAD_LIBRARY_SEARCH_SYSTEM32 is added to the link flags to limit the
module search path to the system directory.
Bug: 523382354
Change-Id: I44d95adeb2417a03e1ec15f14b6eea9238f77a8f
Reviewed-by: S Ganesh <gan...@chromium.org>
Commit-Queue: Will Harris <w...@chromium.org>
Auto-Submit: Sorin Jianu <so...@chromium.org>
Reviewed-by: Will Harris <w...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648461}
Files:
- M chrome/updater/win/installer/BUILD.gn
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by S Ganesh, +1 by Will Harris
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 18, 2026, 12:26:21 AM (11 days ago) Jun 18
to Sorin Jianu, Chromium LUCI CQ, Will Harris, S Ganesh, chromium...@chromium.org
Rakina Zata Amni has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages