Convert profile() to GetProfile() (Part 14) [chromium/src : main]

0 views
Skip to first unread message

Thomas Lukaszewicz (Gerrit)

unread,
2:42 PM (3 hours ago) 2:42 PM
to David Yeung, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajwong...@chromium.org, arc-review...@google.com, cfredri...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, tbarzi...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org
Attention needed from David Yeung

Thomas Lukaszewicz added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Thomas Lukaszewicz . resolved

Sorry David - one more

Open in Gerrit

Related details

Attention is currently required from:
  • David Yeung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4c71611e25630e1d03fecec123e20346bf98e722
Gerrit-Change-Number: 8061618
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-Attention: David Yeung <day...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 18:41:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Yeung (Gerrit)

unread,
4:11 PM (2 hours ago) 4:11 PM
to Thomas Lukaszewicz, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajwong...@chromium.org, arc-review...@google.com, cfredri...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, tbarzi...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org
Attention needed from Thomas Lukaszewicz

David Yeung voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4c71611e25630e1d03fecec123e20346bf98e722
    Gerrit-Change-Number: 8061618
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: David Yeung <day...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 20:11:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Lukaszewicz (Gerrit)

    unread,
    4:24 PM (1 hour ago) 4:24 PM
    to David Yeung, Chromium LUCI CQ, Avi Drissman, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajwong...@chromium.org, arc-review...@google.com, cfredri...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, tbarzi...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org

    Thomas Lukaszewicz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4c71611e25630e1d03fecec123e20346bf98e722
    Gerrit-Change-Number: 8061618
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: David Yeung <day...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 20:23:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:02 PM (1 hour ago) 5:02 PM
    to Thomas Lukaszewicz, David Yeung, Akihiro Ota, Avi Drissman, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, ajwong...@chromium.org, arc-review...@google.com, cfredri...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hidehik...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, rrsilva+wat...@google.com, shend...@chromium.org, tbarzi...@chromium.org, tote-eng...@google.com, tranbaod...@chromium.org, translat...@chromium.org, yhanada+...@chromium.org, yhanada...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Convert profile() to GetProfile() (Part 14)

    No expected behavior changes. This CL updates calls to
    Browser::profile() to instead be BrowserWindowInterface::GetProfile().

    This change contains only the rename + reformat (if necessary)
    Bug: 532248264
    Change-Id: I4c71611e25630e1d03fecec123e20346bf98e722
    Reviewed-by: David Yeung <day...@chromium.org>
    Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1659048}
    Files:
    • M chrome/browser/supervised_user/supervised_user_pending_state_navigation_browsertest.cc
    • M chrome/browser/supervised_user/supervised_user_regional_url_filter_browsertest.cc
    • M chrome/browser/supervised_user/supervised_user_service_browsertest.cc
    • M chrome/browser/support_tool/policy_data_collector_browsertest.cc
    • M chrome/browser/support_tool/signin_data_collector_browsertest.cc
    • M chrome/browser/support_tool/support_tool_util_browsertest.cc
    • M chrome/browser/sync/sessions/sync_sessions_router_tab_helper_browsertest.cc
    • M chrome/browser/sync/sync_ui_util.cc
    • M chrome/browser/sync/test/integration/local_sync_test.cc
    • M chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc
    • M chrome/browser/task_manager/task_manager_browsertest.cc
    • M chrome/browser/themes/theme_service_browsertest.cc
    • M chrome/browser/top_level_storage_access_api/request_storage_access_for_browsertest.cc
    • M chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc
    • M chrome/browser/translate/translate_manager_browsertest.cc
    • M chrome/browser/trusted_vault/trusted_vault_encryption_keys_tab_helper_browsertest.cc
    • M chrome/browser/ui/ash/app_list/app_list_search_browsertest.cc
    • M chrome/browser/ui/ash/arc/arc_open_url_delegate_impl_browsertest.cc
    • M chrome/browser/ui/ash/birch/birch_browsertest.cc
    • M chrome/browser/ui/ash/capture_mode/capture_mode_browsertest.cc
    • M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate_browsertest.cc
    • M chrome/browser/ui/ash/capture_mode/recording_service_browsertest.cc
    • M chrome/browser/ui/ash/desks/desks_client_browsertest.cc
    • M chrome/browser/ui/ash/google_one/google_one_offer_iph_tab_helper_browsertest.cc
    • M chrome/browser/ui/ash/graduation/graduation_manager_impl_browsertest.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_keyed_service_browsertest.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_keyed_service_unittest.cc
    • M chrome/browser/ui/ash/holding_space/holding_space_ui_browsertest.cc
    • M chrome/browser/ui/ash/keyboard/keyboard_controller_browsertest.cc
    • M chrome/browser/ui/ash/login/login_web_dialog_browsertest.cc
    • M chrome/browser/ui/ash/new_window/chrome_new_window_client_browsertest.cc
    • M chrome/browser/ui/ash/privacy_hub/geolocation_switch_interactive_uitest.cc
    • M chrome/browser/ui/ash/projector/pending_screencast_manager_browsertest.cc
    • M chrome/browser/ui/ash/projector/projector_client_impl_browsertest.cc
    • M chrome/browser/ui/ash/projector/screencast_manager_browsertest.cc
    • M chrome/browser/ui/ash/quick_answers/ui/quick_answers_pixeltest.cc
    • M chrome/browser/ui/ash/quick_insert/quick_insert_accessibility_browsertest.cc
    • M chrome/browser/ui/ash/sharesheet/sharesheet_bubble_view_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_service/app_service_app_window_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_service/app_service_promise_app_shelf_context_menu_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_service/app_service_shelf_context_menu_browsertest.cc
    • M chrome/browser/ui/ash/shelf/app_shortcut_shelf_item_controller_browsertest.cc
    Change size: L
    Delta: 42 files changed, 190 insertions(+), 182 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Yeung
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4c71611e25630e1d03fecec123e20346bf98e722
    Gerrit-Change-Number: 8061618
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Yeung <day...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages