Modify updateContent to support showing DOM Distiller content. [chromium/src : main]

[Gustavo Martin (Gerrit)]

Attention needed from Andres Munoz Medina, Jacobo Tapia and Lauren Winston

Gustavo Martin added 4 comments

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 543, Patchset 1: if (!this.trustedUpdatePolicy) {

Jacobo Tapia . resolved

Can you make sure to return an empty TrustedHTML object in case that `chrome.readingMode.isReadabilityEnabled` is false?

Gustavo Martin

Done

Line 545, Patchset 2: return window.trustedTypes!.emptyHTML;

Jacobo Tapia . unresolved

Can you change this to
```suggestion
      return window.trustedTypes ? window.trustedTypes.emptyHTML : '';
```
since `window.trustedTypes` could be `undefined.`

Gustavo Martin

I don't think we can do that since this funcion needs to return TrustedHTML.

And for us to be able to return that, window.trustedTypes needs to exist

lmk your thoughts

Line 552, Patchset 1: }

Jacobo Tapia . resolved

Nit: New line below.

Gustavo Martin

Done

File chrome/browser/ui/webui/side_panel/read_anything/read_anything_untrusted_ui.cc

Line 208, Patchset 1: source->OverrideContentSecurityPolicy(

Jacobo Tapia . resolved

Can you try to delete all the `polymer` references? They are not needed as we are only using `lit`.

Gustavo Martin

If I remove them I get these runtime errors:

https://paste.googleplex.com/5999382308716544

Will leave them as discussed offline.

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Jacobo Tapia
• Lauren Winston

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 5

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Lauren Winston <lwin...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 22:24:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jacobo Tapia <jata...@google.com>

[Lauren Winston (Gerrit)]

Attention needed from Andres Munoz Medina, Gustavo Martin and Jacobo Tapia

Lauren Winston added 4 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Lauren Winston . resolved

Thanks!

File chrome/browser/resources/side_panel/read_anything/app/app.ts

Line 366, Patchset 5 (Latest): const wordCount = (this.$.container.textContent) ?
getWordCount(this.$.container.textContent) :

Lauren Winston . unresolved

Does this need to change in this CL?

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 211, Patchset 5 (Latest): // Readability Path: Build DOM from the HTML string.
const title = chrome.readingMode.htmlTitle;
const contentHtml = chrome.readingMode.htmlContent;

// TODO: crbug.com/459156155 - Default to screen2X distillation if no
// distilled content from Readability.
if (!contentHtml) {
this.setEmpty();
return null;
}

const contentFragment = document.createDocumentFragment();

if (title) {
const titleElement = document.createElement('h1');
titleElement.textContent = title;
contentFragment.appendChild(titleElement);
}

const contentContainer = document.createElement('div');
contentContainer.innerHTML = this.getTrustedHtml(contentHtml);
contentFragment.appendChild(contentContainer);

this.setState(ContentType.HAS_CONTENT);
this.initializeReadAloud(contentFragment);
return contentFragment;

Lauren Winston . unresolved

Lets move this into another helper e.g. updateContentForReadability or similar

Line 289, Patchset 5 (Latest): initializeReadAloud(rootNode: Node): void {

Lauren Winston . unresolved

nit: lets call this something more like updateReadAloudState

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin
• Jacobo Tapia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 5

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 22:41:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jacobo Tapia (Gerrit)]

Attention needed from Andres Munoz Medina and Gustavo Martin

Jacobo Tapia added 1 comment

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 545, Patchset 2: return window.trustedTypes!.emptyHTML;

Jacobo Tapia . resolved

Can you change this to
```suggestion
      return window.trustedTypes ? window.trustedTypes.emptyHTML : '';
```
since `window.trustedTypes` could be `undefined.`

Gustavo Martin

I don't think we can do that since this funcion needs to return TrustedHTML.

And for us to be able to return that, window.trustedTypes needs to exist

lmk your thoughts

Jacobo Tapia

Done

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 23:05:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Gustavo Martin <gusm...@google.com>

Comment-In-Reply-To: Jacobo Tapia <jata...@google.com>

[Gustavo Martin (Gerrit)]

Attention needed from Andres Munoz Medina, Jacobo Tapia and Lauren Winston

Gustavo Martin added 4 comments

File chrome/browser/resources/side_panel/read_anything/app/app.ts

Line 366, Patchset 5: const wordCount = (this.$.container.textContent) ?
getWordCount(this.$.container.textContent) :

Lauren Winston . resolved

Does this need to change in this CL?

Gustavo Martin

It doesn't, I added it in this CL to avoid having to modify app.ts in a future CL.

I have flag guarded this change in case it causes issues.

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 211, Patchset 5: // Readability Path: Build DOM from the HTML string.


const title = chrome.readingMode.htmlTitle;
const contentHtml = chrome.readingMode.htmlContent;

// TODO: crbug.com/459156155 - Default to screen2X distillation if no
// distilled content from Readability.
if (!contentHtml) {
this.setEmpty();
return null;
}

const contentFragment = document.createDocumentFragment();

if (title) {
const titleElement = document.createElement('h1');
titleElement.textContent = title;
contentFragment.appendChild(titleElement);
}

const contentContainer = document.createElement('div');
contentContainer.innerHTML = this.getTrustedHtml(contentHtml);
contentFragment.appendChild(contentContainer);

this.setState(ContentType.HAS_CONTENT);
this.initializeReadAloud(contentFragment);
return contentFragment;

Lauren Winston . resolved

Lets move this into another helper e.g. updateContentForReadability or similar

Gustavo Martin

Done

Line 289, Patchset 5: initializeReadAloud(rootNode: Node): void {

Lauren Winston . resolved

nit: lets call this something more like updateReadAloudState

Gustavo Martin

Done

Line 545, Patchset 2: return window.trustedTypes!.emptyHTML;

Jacobo Tapia . resolved

Can you change this to
```suggestion
      return window.trustedTypes ? window.trustedTypes.emptyHTML : '';
```
since `window.trustedTypes` could be `undefined.`

Gustavo Martin

I don't think we can do that since this funcion needs to return TrustedHTML.

And for us to be able to return that, window.trustedTypes needs to exist

lmk your thoughts

Gustavo Martin

Discussed offline

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Jacobo Tapia
• Lauren Winston

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 6

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Lauren Winston <lwin...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 23:38:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Gustavo Martin <gusm...@google.com>

Comment-In-Reply-To: Jacobo Tapia <jata...@google.com>

Comment-In-Reply-To: Lauren Winston <lwin...@google.com>

[Lauren Winston (Gerrit)]

Attention needed from Andres Munoz Medina, Gustavo Martin and Jacobo Tapia

Lauren Winston voted and added 1 comment

Votes added by Lauren Winston

Code-Review

+1

1 comment

File chrome/browser/resources/side_panel/read_anything/app/app.ts

Line 365, Patchset 6 (Latest): if (!this.willDrawAgainSoon_) {
const wordCount = chrome.readingMode.isReadabilityEnabled ?
(this.$.container.textContent ?
getWordCount(this.$.container.textContent) :
0) :
(newRoot && newRoot.textContent ? getWordCount(newRoot.textContent) :
0);

Lauren Winston . unresolved

Can you pull out the container to a separate variable? I think that might make this a bit more readable. (I'm sure the formatting of this suggestion is off)
```suggestion
    const wordCountContainer = chrome.readingMode.isReadabilityEnabled ? this.$.container : newRoot;
    if (!this.willDrawAgainSoon_) {
      const wordCount =
          (wordCountContainer && wordCountContainer.textContent ? getWordCount(wordCountContainer.textContent) :
                                            0);
```

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin
• Jacobo Tapia

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 6

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 23:46:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Gustavo Martin (Gerrit)]

Attention needed from Andres Munoz Medina, Jacobo Tapia and Lauren Winston

Gustavo Martin added 1 comment

File chrome/browser/resources/side_panel/read_anything/app/app.ts

Line 365, Patchset 6: if (!this.willDrawAgainSoon_) {


const wordCount = chrome.readingMode.isReadabilityEnabled ?
(this.$.container.textContent ?
getWordCount(this.$.container.textContent) :
0) :
(newRoot && newRoot.textContent ? getWordCount(newRoot.textContent) :
0);

Lauren Winston . resolved

Can you pull out the container to a separate variable? I think that might make this a bit more readable. (I'm sure the formatting of this suggestion is off)
```suggestion
    const wordCountContainer = chrome.readingMode.isReadabilityEnabled ? this.$.container : newRoot;
    if (!this.willDrawAgainSoon_) {
      const wordCount =
          (wordCountContainer && wordCountContainer.textContent ? getWordCount(wordCountContainer.textContent) :
                                            0);
```

Gustavo Martin

Done

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Jacobo Tapia
• Lauren Winston

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 7

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Lauren Winston <lwin...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 00:01:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Lauren Winston <lwin...@google.com>

[Lauren Winston (Gerrit)]

Attention needed from Andres Munoz Medina, Gustavo Martin and Jacobo Tapia

Lauren Winston voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin
• Jacobo Tapia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 7

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 00:29:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lauren Winston (Gerrit)]

Attention needed from Andres Munoz Medina, Gustavo Martin and Jacobo Tapia

Lauren Winston added 1 comment

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 210, Patchset 7 (Latest): if (chrome.readingMode.isReadabilityEnabled) {

Lauren Winston . unresolved

Let's also add a check for Chrome.readingMode.htmlContent being empty here for this CL. We can refine that in the next CL once Readability is connected- but that way, we won't break anything with Screen2x in-between submissions.

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin
• Jacobo Tapia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 7

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 05:32:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Gustavo Martin (Gerrit)]

Attention needed from Andres Munoz Medina, Jacobo Tapia and Lauren Winston

Gustavo Martin added 1 comment

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 210, Patchset 7: if (chrome.readingMode.isReadabilityEnabled) {

Lauren Winston . resolved

Let's also add a check for Chrome.readingMode.htmlContent being empty here for this CL. We can refine that in the next CL once Readability is connected- but that way, we won't break anything with Screen2x in-between submissions.

Gustavo Martin

Done

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Jacobo Tapia
• Lauren Winston

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 8

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Lauren Winston <lwin...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 14:57:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Lauren Winston <lwin...@google.com>

[Jacobo Tapia (Gerrit)]

Attention needed from Andres Munoz Medina, Gustavo Martin and Lauren Winston

Jacobo Tapia added 2 comments

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 588, Patchset 8 (Latest): // return window.trustedTypes ? window.trustedTypes.emptyHTML : '';

Jacobo Tapia . unresolved

Remove this comment.

Line 608, Patchset 8 (Latest): console.warn(e);

Jacobo Tapia . unresolved

Apparently other instances in the codebase that create a trusted policy don't use a try/catch block.

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin
• Lauren Winston

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 8

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Lauren Winston <lwin...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 18:18:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Gustavo Martin (Gerrit)]

Attention needed from Andres Munoz Medina, Jacobo Tapia and Lauren Winston

Gustavo Martin added 2 comments

File chrome/browser/resources/side_panel/read_anything/content/content_controller.ts

Line 588, Patchset 8: // return window.trustedTypes ? window.trustedTypes.emptyHTML : '';

Jacobo Tapia . resolved

Remove this comment.

Gustavo Martin

Done

Line 608, Patchset 8: console.warn(e);

Jacobo Tapia . resolved

Apparently other instances in the codebase that create a trusted policy don't use a try/catch block.

Gustavo Martin

Done

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Jacobo Tapia
• Lauren Winston

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 9

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Lauren Winston <lwin...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 18:33:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jacobo Tapia <jata...@google.com>

[Lauren Winston (Gerrit)]

Attention needed from Andres Munoz Medina, Gustavo Martin and Jacobo Tapia

Lauren Winston voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin
• Jacobo Tapia

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 9

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Jacobo Tapia <jata...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 18:47:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Jacobo Tapia (Gerrit)]

Attention needed from Andres Munoz Medina and Gustavo Martin

Jacobo Tapia voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina
• Gustavo Martin

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 9

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Gustavo Martin <gusm...@google.com>

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 19:07:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Gustavo Martin (Gerrit)]

Attention needed from Andres Munoz Medina

Gustavo Martin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Andres Munoz Medina

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 9

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andres Munoz Medina <amme...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 19:46:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Modify updateContent to support showing DOM Distiller content.

When isReadabilityEnabled is active, updateContent method now shows in
RM WebUI content from htmlTitle and htmlContent. These variables are
currently empty but in a future CL (crrev.com/c/7282479) they will hold
distilled content from DOM distiller.

Bug: 459144991

Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7455146

Reviewed-by: Lauren Winston <lwin...@google.com>

Reviewed-by: Jacobo Tapia <jata...@google.com>

Commit-Queue: Gustavo Martin <gusm...@google.com>

Cr-Commit-Position: refs/heads/main@{#1568600}

Files:

• M chrome/browser/resources/side_panel/read_anything/app/app.ts
• M chrome/browser/resources/side_panel/read_anything/app/read_anything.d.ts
• M chrome/browser/resources/side_panel/read_anything/content/content_controller.ts
• M chrome/browser/ui/webui/side_panel/read_anything/read_anything_untrusted_ui.cc
• M chrome/renderer/accessibility/read_anything/read_anything_app_controller.cc
• M chrome/renderer/accessibility/read_anything/read_anything_app_controller.h
• M chrome/test/data/webui/side_panel/read_anything/app_content_test.ts
• M chrome/test/data/webui/side_panel/read_anything/fake_reading_mode.ts

Change size: M

Delta: 8 files changed, 152 insertions(+), 14 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Lauren Winston, +1 by Jacobo Tapia

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I748f59b76d44582bb697edd5651df00e58521045

Gerrit-Change-Number: 7455146

Gerrit-PatchSet: 10

Gerrit-Owner: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Andres Munoz Medina <amme...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gustavo Martin <gusm...@google.com>

Gerrit-Reviewer: Jacobo Tapia <jata...@google.com>

Gerrit-Reviewer: Lauren Winston <lwin...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org