[OTP] Add Gmail OTP SubscriptionWaitLatency metrics [chromium/src : main]

0 views
Skip to first unread message

Trang Mai (Gerrit)

unread,
7:33 AM (1 hour ago) 7:33 AM
to Bekzhan Kassenov, Jihad Hanna, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Bekzhan Kassenov and Jihad Hanna

Trang Mai voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bekzhan Kassenov
  • Jihad Hanna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8cf651e3fdf8f4c02938d53167d89cbea7aa9aa6
Gerrit-Change-Number: 7816776
Gerrit-PatchSet: 3
Gerrit-Owner: Trang Mai <tra...@google.com>
Gerrit-Reviewer: Bekzhan Kassenov <bkas...@google.com>
Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
Gerrit-Reviewer: Trang Mai <tra...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Bekzhan Kassenov <bkas...@google.com>
Gerrit-Attention: Jihad Hanna <jihad...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 11:32:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Trang Mai (Gerrit)

unread,
7:33 AM (1 hour ago) 7:33 AM
to Marc Treib, Bekzhan Kassenov, Jihad Hanna, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Bekzhan Kassenov, Jihad Hanna, Marc Treib and Trang Mai

Trang Mai voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bekzhan Kassenov
  • Jihad Hanna
  • Marc Treib
  • Trang Mai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8cf651e3fdf8f4c02938d53167d89cbea7aa9aa6
Gerrit-Change-Number: 7816776
Gerrit-PatchSet: 3
Gerrit-Owner: Trang Mai <tra...@google.com>
Gerrit-Reviewer: Bekzhan Kassenov <bkas...@google.com>
Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
Gerrit-Reviewer: Trang Mai <tra...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Trang Mai <tra...@google.com>
Gerrit-Attention: Bekzhan Kassenov <bkas...@google.com>
Gerrit-Attention: Marc Treib <tr...@chromium.org>
Gerrit-Attention: Jihad Hanna <jihad...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 11:33:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jihad Hanna (Gerrit)

unread,
7:39 AM (1 hour ago) 7:39 AM
to Trang Mai, android-bu...@system.gserviceaccount.com, Marc Treib, Bekzhan Kassenov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, knollr+wat...@chromium.org, asvitkine...@chromium.org
Attention needed from Bekzhan Kassenov, Marc Treib and Trang Mai

Jihad Hanna voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bekzhan Kassenov
  • Marc Treib
  • Trang Mai
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8cf651e3fdf8f4c02938d53167d89cbea7aa9aa6
    Gerrit-Change-Number: 7816776
    Gerrit-PatchSet: 3
    Gerrit-Owner: Trang Mai <tra...@google.com>
    Gerrit-Reviewer: Bekzhan Kassenov <bkas...@google.com>
    Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Trang Mai <tra...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Trang Mai <tra...@google.com>
    Gerrit-Attention: Bekzhan Kassenov <bkas...@google.com>
    Gerrit-Attention: Marc Treib <tr...@chromium.org>
    Gerrit-Comment-Date: Tue, 05 May 2026 11:39:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Marc Treib (Gerrit)

    unread,
    7:45 AM (1 hour ago) 7:45 AM
    to Trang Mai, Marc Treib, Jihad Hanna, android-bu...@system.gserviceaccount.com, Bekzhan Kassenov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, knollr+wat...@chromium.org, asvitkine...@chromium.org
    Attention needed from Bekzhan Kassenov and Trang Mai

    Marc Treib voted and added 2 comments

    Votes added by Marc Treib

    Code-Review+1

    2 comments

    File components/one_time_tokens/core/browser/gmail_otp_backend.cc
    Line 62, Patchset 3 (Latest): base::UmaHistogramTimes(
    Marc Treib . unresolved

    Just to check: `UmaHistogramTimes` has a max value of 10 seconds. Is that enough for this case, or would maybe `UmaHistogramMediumTimes` be better?

    Line 64, Patchset 3 (Latest): base::TimeTicks::Now() - notification.notification_received_timeticks);
    Marc Treib . resolved

    FWIW, I think many timing metrics, especially "short" ones, just use `base::Time` - in practice, it's almost always fine, especially for short time frames. So if you wanted, you could save the plumbing for the second timestamp.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bekzhan Kassenov
    • Trang Mai
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8cf651e3fdf8f4c02938d53167d89cbea7aa9aa6
    Gerrit-Change-Number: 7816776
    Gerrit-PatchSet: 3
    Gerrit-Owner: Trang Mai <tra...@google.com>
    Gerrit-Reviewer: Bekzhan Kassenov <bkas...@google.com>
    Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Trang Mai <tra...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Trang Mai <tra...@google.com>
    Gerrit-Attention: Bekzhan Kassenov <bkas...@google.com>
    Gerrit-Comment-Date: Tue, 05 May 2026 11:45:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages