[WebUI NTP on AL] Enable Tab Resumption Module unit tests on Android [chromium/src : main]
0 views
Skip to first unread message
Gianni Chen (Gerrit)
Jun 17, 2026, 4:38:48 AM (7 days ago) Jun 17
to Chromium LUCI CQ, chromium...@chromium.org
Gianni Chen added 1 comment![]( "Open in Gerrit")
File chrome/browser/new_tab_page/BUILD.gn
Line 176, Patchset 4 (Parent):
sources = [Gianni Chen . unresolved
Now that we're building the NTP unit tests for Android as well, we need to move the yet to be implemented features into the `!is_android` block.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gianni Chen (Gerrit)
Jun 18, 2026, 2:12:49 AM (6 days ago) Jun 18
to Riley Tatum, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Riley Tatum
Gianni Chen added 1 comment![]( "Open in Gerrit")
File chrome/browser/new_tab_page/BUILD.gn
Line 176, Patchset 4 (Parent):
sources = [Gianni Chen . resolved
Now that we're building the NTP unit tests for Android as well, we need to move the yet to be implemented features into the `!is_android` block.
Gianni Chen
Done
Related details
Attention is currently required from:
- Riley Tatum
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Riley Tatum (Gerrit)
Jun 18, 2026, 7:26:33 PM (5 days ago) Jun 18
to Gianni Chen, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Gianni Chen
Riley Tatum voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gianni Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gianni Chen (Gerrit)
Jun 20, 2026, 2:41:10 AM (4 days ago) Jun 20
to Riley Tatum, Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org
Gianni Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 20, 2026, 3:33:55 AM (4 days ago) Jun 20
to Gianni Chen, Riley Tatum, Andrew Grieve, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WebUI NTP on AL] Enable Tab Resumption Module unit tests on Android
This change enables the Most Relevant Tab Resumption module unit tests
on Android by adding the unit_tests target to the enable_webui_ntp deps
block in chrome/test/BUILD.gn.
It also adds unit tests verifying the URL title formatting logic
(specifically falling back to GURL spec when page title is empty).
Bug: 524830539
Change-Id: If773a85bc4b0725e76bee1cfbf72fe694ea83205
Reviewed-by: Riley Tatum <rta...@google.com>
Commit-Queue: Gianni Chen <gian...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649895}
Files:
- M chrome/browser/new_tab_page/BUILD.gn
- M chrome/browser/new_tab_page/modules/v2/most_relevant_tab_resumption/most_relevant_tab_resumption_page_handler_unittest.cc
- M chrome/test/BUILD.gn
Change size: M
Delta: 3 files changed, 94 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Riley Tatum
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages