Fix UNSAFE_TODO in waitable_event_win.cc [chromium/src : main]

0 views

Skip to first unread message

David Bienvenu (Gerrit)

unread,

7:07 PM (4 hours ago) 7:07 PM

to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Daniel Cheng

David Bienvenu added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

David Bienvenu . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

8:34 PM (3 hours ago) 8:34 PM

to David Bienvenu, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from David Bienvenu

Daniel Cheng added 1 comment

File base/synchronization/waitable_event_win.cc

Line 131, Patchset 1 (Latest): HANDLE handles[MAXIMUM_WAIT_OBJECTS];

Daniel Cheng . unresolved

```suggestion
  std::array<HANDLE, MAXIMUM_WAIT_OBJECTS> handles;
```

And you should't need the span below.