Define UKM metric setters inline in the generated header [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Aug 4, 2026, 9:32:16 PM (5 days ago) Aug 4
to Helmut Januschka, Andrew Grieve, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Helmut Januschka

Andrew Grieve added 1 comment

Commit Message
Line 14, Patchset 1 (Latest):Saves ~79KB of normalized APK size on Android (x64 local build).
Andrew Grieve . unresolved

android-binary-size currently also includes ancestor patches in the results, so I think this change has close to no size impact in isolation. Could be that thinlto is already inlining them.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8644cd6925b471d8b75095603f8e0ba6ea25e2c6
Gerrit-Change-Number: 8183021
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 01:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Aug 7, 2026, 6:36:36 PM (2 days ago) Aug 7
to Andrew Grieve, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Andrew Grieve

Helmut Januschka added 1 comment

Commit Message
Line 14, Patchset 1:Saves ~79KB of normalized APK size on Android (x64 local build).
Andrew Grieve . unresolved

android-binary-size currently also includes ancestor patches in the results, so I think this change has close to no size impact in isolation. Could be that thinlto is already inlining them.

Helmut Januschka

ok reporting was wrong because of chained commit :/, the change is pretty small/clean, should we still pursue landing?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8644cd6925b471d8b75095603f8e0ba6ea25e2c6
Gerrit-Change-Number: 8183021
Gerrit-PatchSet: 2
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Fri, 07 Aug 2026 22:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew Grieve <agr...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Aug 7, 2026, 8:37:05 PM (2 days ago) Aug 7
to Helmut Januschka, Andrew Grieve, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
Attention needed from Helmut Januschka

Andrew Grieve added 1 comment

Commit Message
Line 14, Patchset 1:Saves ~79KB of normalized APK size on Android (x64 local build).
Andrew Grieve . resolved

android-binary-size currently also includes ancestor patches in the results, so I think this change has close to no size impact in isolation. Could be that thinlto is already inlining them.

Helmut Januschka

ok reporting was wrong because of chained commit :/, the change is pretty small/clean, should we still pursue landing?

Andrew Grieve

Up to you. Given the shape of the function, I think it does make sense to be in the header, but certainly no measurable gains to be had.

If looking for more ideas, there may be modest savings to switching to 32-bit hashes, but would need a test to ensure no collisions in that case.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8644cd6925b471d8b75095603f8e0ba6ea25e2c6
    Gerrit-Change-Number: 8183021
    Gerrit-PatchSet: 2
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-CC: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Comment-Date: Sat, 08 Aug 2026 00:36:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
    Comment-In-Reply-To: Andrew Grieve <agr...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Helmut Januschka (Gerrit)

    unread,
    6:18 PM (2 hours ago) 6:18 PM
    to Chromium Metrics Reviews, Andrew Grieve, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
    Attention needed from Andrew Grieve

    Helmut Januschka voted and added 1 comment

    Votes added by Helmut Januschka

    Commit-Queue+1

    1 comment

    Commit Message
    Line 14, Patchset 1:Saves ~79KB of normalized APK size on Android (x64 local build).
    Andrew Grieve . resolved

    android-binary-size currently also includes ancestor patches in the results, so I think this change has close to no size impact in isolation. Could be that thinlto is already inlining them.

    Helmut Januschka

    ok reporting was wrong because of chained commit :/, the change is pretty small/clean, should we still pursue landing?

    Andrew Grieve

    Up to you. Given the shape of the function, I think it does make sense to be in the header, but certainly no measurable gains to be had.

    If looking for more ideas, there may be modest savings to switching to 32-bit hashes, but would need a test to ensure no collisions in that case.

    Helmut Januschka

    ahhh 32bit hash was a good hint! lets keep it, thanks alot!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Grieve
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8644cd6925b471d8b75095603f8e0ba6ea25e2c6
    Gerrit-Change-Number: 8183021
    Gerrit-PatchSet: 5
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Comment-Date: Sun, 09 Aug 2026 22:17:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    6:22 PM (2 hours ago) 6:22 PM
    to Helmut Januschka, Chromium Metrics Reviews, Alexei Svitkine, Andrew Grieve, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com
    Attention needed from Alexei Svitkine and Andrew Grieve

    Message from gwsq

    Reviewer source(s):
    asvi...@chromium.org is from context(analysis/uma/chrome-metrics.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexei Svitkine
    • Andrew Grieve
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8644cd6925b471d8b75095603f8e0ba6ea25e2c6
    Gerrit-Change-Number: 8183021
    Gerrit-PatchSet: 5
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-CC: Andrew Grieve <agr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Comment-Date: Sun, 09 Aug 2026 22:22:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages