[Vertical Tabs] Force TabbedLayout if vertical tabs is enabled [chromium/src : main]
0 views
Skip to first unread message
Caroline Rising (Gerrit)
Jan 9, 2026, 4:05:27 PM (2 days ago) Jan 9
to David Pennington, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from David Pennington
Caroline Rising voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eshwar Stalin (Gerrit)
Jan 9, 2026, 11:58:41 PM (2 days ago) Jan 9
to David Pennington, Caroline Rising, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Caroline Rising and David Pennington
Eshwar Stalin added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/ui_features.cc
Line 119, Patchset 2 (Latest):
return base::FeatureList::IsEnabled(kTabbedBrowserUseNewLayout) ||Eshwar Stalin . unresolved
Instead of this let's remove the flag for tabbed browser layout from chrome://flags.
Related details
Attention is currently required from:
- Caroline Rising
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Pennington (Gerrit)
Jan 10, 2026, 7:17:59 PM (22 hours ago) Jan 10
to Dana Fried, Eshwar Stalin, Caroline Rising, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Caroline Rising, Dana Fried and Eshwar Stalin
David Pennington added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/ui_features.cc
Line 119, Patchset 2 (Latest):
return base::FeatureList::IsEnabled(kTabbedBrowserUseNewLayout) ||Eshwar Stalin . unresolved
Instead of this let's remove the flag for tabbed browser layout from chrome://flags.
David Pennington
are you saying to remove kTabbedBrowserUseNewLayout? im happy to do that but im not sure if dfried thinks we are ready.
Related details
Attention is currently required from:
- Caroline Rising
- Dana Fried
- Eshwar Stalin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eshwar Stalin (Gerrit)
Jan 10, 2026, 11:38:57 PM (18 hours ago) Jan 10
to David Pennington, Dana Fried, Caroline Rising, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Caroline Rising, Dana Fried and David Pennington
Eshwar Stalin added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/ui_features.cc
Line 119, Patchset 2 (Latest):
return base::FeatureList::IsEnabled(kTabbedBrowserUseNewLayout) ||Eshwar Stalin . unresolved
David PenningtonInstead of this let's remove the flag for tabbed browser layout from chrome://flags.
are you saying to remove kTabbedBrowserUseNewLayout? im happy to do that but im not sure if dfried thinks we are ready.
Eshwar Stalin
Yes let's remove that flag from chrome://flags. We are close to deleting that flag soon.
Related details
Attention is currently required from:
- Caroline Rising
- Dana Fried
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages