build: Introduce cros_target_cpu_arch GN arg [chromium/src : main]
Bob Haarman (Gerrit)
Bob Haarman added 1 comment![]( "Open in Gerrit")
target_cpu_arch = ""Bob HaarmanThanks!
Two requests:
1. Since these archs are only used in a single .gn file, can we declare them there, instead of making a dedicated gni file?
2. Can we call this `cros_target_cpu_arch` and only use this if `target_os == "chromeos"`? (I imagine that's enough even for the android sub-part of a cros build?)
Bob HaarmanSure, happy to make those changes.
I'll keep the `arm_arch` functionality the way it is now so that it continues to apply even if `target_os != "chromeos"`. And then `cros_target_cpu_arch` will apply only if `target_os == "chromeos"`, the same way `cros_extra_*flags` do today.
Done
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nico Weber added 5 comments![]( "Open in Gerrit")
Thanks!
Since I think we only need this for x64 and aarch64 on cros (...right?) and since those currently don't globally set `march=` there, maybe this can become a bit more targeted still (see below).
I wonder how https://source.chromium.org/chromium/chromium/src/+/main:third_party/zlib/BUILD.gn;l=155?q=march%3D%20f:%5C.gn interacts with a global -march flag, but I suppose that isn't new to this CL here. The specific order on the commandline might be different, probably worth verifying that the relative order of the two march flags doesn't change for these examples :)
if (current_cpu == "arm") {Since cros no longer ships 32-bit arm, I think this can stay as it was.
cflags += [ "-msse3" ]```
if (target_os == "chromeos" && cros_target_cpu_arch != "" &&
current_cpu == target_cpu) {
cflags += [ "-march=cros_target_cpu_arch" ]
ldflags += [ "-march=cros_target_cpu_arch" ]
}
```
}```
if (target_os == "chromeos" && cros_target_cpu_arch != "" &&
current_cpu == target_cpu) {
cflags += [ "-march=cros_target_cpu_arch" ]
ldflags += [ "-march=cros_target_cpu_arch" ]
}
```
march = "mipsel"We don't ship mipsel cros, do we? Maybe this can stay as-is?
Related details
- Bob Haarman
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Haarman (Gerrit)
Bob Haarman added 4 comments![]( "Open in Gerrit")
if (current_cpu == "arm") {Since cros no longer ships 32-bit arm, I think this can stay as it was.
Done
```
if (target_os == "chromeos" && cros_target_cpu_arch != "" &&
current_cpu == target_cpu) {
cflags += [ "-march=cros_target_cpu_arch" ]
ldflags += [ "-march=cros_target_cpu_arch" ]
}
```
Done
```
if (target_os == "chromeos" && cros_target_cpu_arch != "" &&
current_cpu == target_cpu) {
cflags += [ "-march=cros_target_cpu_arch" ]
ldflags += [ "-march=cros_target_cpu_arch" ]
}
```
Done
We don't ship mipsel cros, do we? Maybe this can stay as-is?
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Haarman (Gerrit)
Bob Haarman voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Nico Weber
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |