IPP: Move IP Protection histograms into their own subfolders [chromium/src : main]

[Giovanni Ortuno Urquidi (Gerrit)]

Giovanni Ortuno Urquidi voted and added 1 comment

Votes added by Giovanni Ortuno Urquidi

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3:

Giovanni Ortuno Urquidi . resolved

chromium-met...@google.com: PTAL! Is this OK or would it be preferable to introduce a single ip_protection/ directory that contains both Net.IpProtection* and NetworkService.IpProtection* metrics?

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 5

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 24 Sep 2025 22:02:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Caitlin Fischer

Message from gwsq

From analysis/uma/chrome-metrics.gwsq:
Histograms should by default be reviewed by the owners of the subdirectories. The chromium-met...@google.com gwsq should be used when there are no individual owners, or for escalation to the Metrics team.
If you are interested in becoming a metrics reviewer, please review the instructions at https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Becoming-a-Metrics-Reviewer

Reviewer source(s):
caitlin...@google.com is from context(analysis/uma/chrome-metrics.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Caitlin Fischer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 5

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Caitlin Fischer <caitlin...@google.com>

Gerrit-Comment-Date: Wed, 24 Sep 2025 22:05:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Caitlin Fischer (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi

Caitlin Fischer added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Caitlin Fischer . unresolved

I'd prefer that we be consistent with the existing organization: tools/metrics/histograms/metadata/one_subdir/histograms.xml.

I.e., option 1 that you mentioned in your CL description.

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 5

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 14:27:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Giovanni Ortuno Urquidi (Gerrit)]

Giovanni Ortuno Urquidi added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Caitlin Fischer . unresolved

I'd prefer that we be consistent with the existing organization: tools/metrics/histograms/metadata/one_subdir/histograms.xml.

I.e., option 1 that you mentioned in your CL description.

Giovanni Ortuno Urquidi

Sounds good! I'll go ahead and switch to that.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 5

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Comment-Date: Thu, 25 Sep 2025 14:30:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Caitlin Fischer <caitlin...@google.com>

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Caitlin Fischer

Giovanni Ortuno Urquidi added 1 comment

Patchset-level comments

File-level comment, Patchset 5:

Caitlin Fischer . resolved

I'd prefer that we be consistent with the existing organization: tools/metrics/histograms/metadata/one_subdir/histograms.xml.

I.e., option 1 that you mentioned in your CL description.

Giovanni Ortuno Urquidi

Sounds good! I'll go ahead and switch to that.

Giovanni Ortuno Urquidi

Done

Open in Gerrit

Related details

Attention is currently required from:

• Caitlin Fischer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 6

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Caitlin Fischer <caitlin...@google.com>

Gerrit-Comment-Date: Thu, 25 Sep 2025 16:31:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Caitlin Fischer <caitlin...@google.com>

Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>

[Caitlin Fischer (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi

Caitlin Fischer voted and added 2 comments

Votes added by Caitlin Fischer

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6:

Caitlin Fischer . resolved

LGTM % comment

File tools/metrics/histograms/metadata/ip_protection/OWNERS

Line 4, Patchset 6:awi...@chromium.org

Caitlin Fischer . unresolved

I don't see that awillia has completed the quiz: go/reviewing-metrics. Could you remove them until they complete the quiz, please?

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 6

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 18:41:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Caitlin Fischer

Giovanni Ortuno Urquidi added 1 comment

File tools/metrics/histograms/metadata/ip_protection/OWNERS

Line 4, Patchset 6:awi...@chromium.org

Caitlin Fischer . unresolved

I don't see that awillia has completed the quiz: go/reviewing-metrics. Could you remove them until they complete the quiz, please?

Giovanni Ortuno Urquidi

Thanks for checking! I was actually not planning on landing this change until they complete the quiz. I considered just adding myself but would prefer not adding an OWNERS file with just one reviewer. I can ping when they complete the quiz to confirm this is ok to land!

Open in Gerrit

Related details

Attention is currently required from:

• Caitlin Fischer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 7

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Caitlin Fischer <caitlin...@google.com>

Gerrit-Comment-Date: Thu, 25 Sep 2025 18:47:08 +0000

[Caitlin Fischer (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi

Caitlin Fischer voted and added 1 comment

Votes added by Caitlin Fischer

Code-Review

+1

1 comment

File tools/metrics/histograms/metadata/ip_protection/OWNERS

Line 4, Patchset 6:awi...@chromium.org

Caitlin Fischer . unresolved

I don't see that awillia has completed the quiz: go/reviewing-metrics. Could you remove them until they complete the quiz, please?

Giovanni Ortuno Urquidi

Thanks for checking! I was actually not planning on landing this change until they complete the quiz. I considered just adding myself but would prefer not adding an OWNERS file with just one reviewer. I can ping when they complete the quiz to confirm this is ok to land!

Caitlin Fischer

SG! Thanks for holding off until they pass the quiz.

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 7

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 18:49:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Caitlin Fischer

Giovanni Ortuno Urquidi added 1 comment

File tools/metrics/histograms/metadata/ip_protection/OWNERS

Line 4, Patchset 6:awi...@chromium.org

Caitlin Fischer . unresolved

I don't see that awillia has completed the quiz: go/reviewing-metrics. Could you remove them until they complete the quiz, please?

Giovanni Ortuno Urquidi

Thanks for checking! I was actually not planning on landing this change until they complete the quiz. I considered just adding myself but would prefer not adding an OWNERS file with just one reviewer. I can ping when they complete the quiz to confirm this is ok to land!

Caitlin Fischer

SG! Thanks for holding off until they pass the quiz.

Giovanni Ortuno Urquidi

awillia passed the quiz! does it take a bit to propagate or can you see the result already?

Open in Gerrit

Related details

Attention is currently required from:

• Caitlin Fischer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 7

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Caitlin Fischer <caitlin...@google.com>

Gerrit-Comment-Date: Thu, 25 Sep 2025 19:40:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Caitlin Fischer (Gerrit)]

Attention needed from Giovanni Ortuno Urquidi

Caitlin Fischer added 1 comment

File tools/metrics/histograms/metadata/ip_protection/OWNERS

Line 4, Patchset 6:awi...@chromium.org

Caitlin Fischer . resolved

I don't see that awillia has completed the quiz: go/reviewing-metrics. Could you remove them until they complete the quiz, please?

Giovanni Ortuno Urquidi

Thanks for checking! I was actually not planning on landing this change until they complete the quiz. I considered just adding myself but would prefer not adding an OWNERS file with just one reviewer. I can ping when they complete the quiz to confirm this is ok to land!

Caitlin Fischer

SG! Thanks for holding off until they pass the quiz.

Giovanni Ortuno Urquidi

awillia passed the quiz! does it take a bit to propagate or can you see the result already?

Caitlin Fischer

I think it takes a day or so to propagate? In any case, the hono(u)r system is fine. Feel free to land this.

Open in Gerrit

Related details

Attention is currently required from:

• Giovanni Ortuno Urquidi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia29dd179694b9fc0b706ff0571e5a25fd6a116f3

Gerrit-Change-Number: 6979235

Gerrit-PatchSet: 7

Gerrit-Owner: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Caitlin Fischer <caitlin...@google.com>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-CC: Andrew Williams <awi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 22:58:27 +0000