[Blink] Eliminate WebGpuRecyclableRP::ProduceCanvasResource() [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

Jul 7, 2026, 11:13:09 AM (20 hours ago) Jul 7

to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

3:02 AM (4 hours ago) 3:02 AM

to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Blink] Eliminate WebGpuRecyclableRP::ProduceCanvasResource()

Transitions remaining callsite using the methods introduced in [1].
Note: In the `use_copy_to_shared_image` codepath, it is not necessary
to add a call to EndWriteAccess() as BeginExternalOverwrite() invokes it
[2] and EndExternalWrite() does not have any impact on the state
modified by EndWriteAccess() [3][4]. For the other codepath,
DoExternalOverdraw() already invokes EndWriteAccess().


[1] https://chromium-review.googlesource.com/c/chromium/src/+/8035093
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;l=321?q=BeginExternalOverwrite&ss=chromium
[3] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;l=333-337?q=BeginExternalOverwrite&ss=chromium
[4] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;l=307-311;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4?q=BeginExternalOverwrite&ss=chromium

Bug: 352263194

Change-Id: I3a6288945213f71e9ecb73f122090dcd77a1fec5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8052066

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Commit-Queue: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1658537}

Files:

M third_party/blink/renderer/modules/webgpu/external_texture_helper.cc
M third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc
M third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.h

Change size: S

Delta: 3 files changed, 13 insertions(+), 33 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages