[ash] arc: Drop dead chrome/browser/prefs include [chromium/src : main]

0 views
Skip to first unread message

Tiago Vignatti (Gerrit)

unread,
Jul 8, 2026, 1:32:32 PM (22 hours ago) Jul 8
to Hidehiko Abe, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org
Attention needed from Hidehiko Abe

Tiago Vignatti added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tiago Vignatti . resolved

Please take a look. Thank you

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I201ded17aa15fc49ab3c713b3604213fe3aec163
Gerrit-Change-Number: 8065710
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
Gerrit-CC: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 17:31:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Jul 8, 2026, 9:22:12 PM (14 hours ago) Jul 8
to Tiago Vignatti, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org
Attention needed from Tiago Vignatti

Hidehiko Abe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tiago Vignatti
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I201ded17aa15fc49ab3c713b3604213fe3aec163
Gerrit-Change-Number: 8065710
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
Gerrit-CC: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 01:21:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tiago Vignatti (Gerrit)

unread,
7:59 AM (4 hours ago) 7:59 AM
to Hidehiko Abe, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org

Tiago Vignatti voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I201ded17aa15fc49ab3c713b3604213fe3aec163
Gerrit-Change-Number: 8065710
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
Gerrit-CC: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 11:59:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
8:18 AM (3 hours ago) 8:18 AM
to Tiago Vignatti, Hidehiko Abe, Thomas Lukaszewicz, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ash] arc: Drop dead chrome/browser/prefs include

arc_play_store_enabled_preference_handler.cc included
chrome/browser/prefs/pref_service_syncable_util.h but never referenced
it. It was arc's only production include from chrome/browser/prefs, so
remove it and scope the DEPS exemption to arc_session_manager_unittest,
which still installs prefs through the //chrome-side helpers.

#ai-assisted
Bug: 353332589
Change-Id: I201ded17aa15fc49ab3c713b3604213fe3aec163
Commit-Queue: Tiago Vignatti <tvig...@igalia.com>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659481}
Files:
  • M chrome/browser/ash/arc/DEPS
  • M chrome/browser/ash/arc/session/arc_play_store_enabled_preference_handler.cc
Change size: XS
Delta: 2 files changed, 6 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hidehiko Abe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I201ded17aa15fc49ab3c713b3604213fe3aec163
Gerrit-Change-Number: 8065710
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages