policy: Decouple LocalFilesMigrationManager from g_browser_process [chromium/src : main]

[Jun Ishiguro (Gerrit)]

Attention needed from Hidehiko Abe

Jun Ishiguro added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jun Ishiguro . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia25b9588568a7ff3a20a4df80e30d2d5645f7db6

Gerrit-Change-Number: 8061513

Gerrit-PatchSet: 1

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Wed, 08 Jul 2026 09:20:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Hidehiko Abe (Gerrit)]

Attention needed from Jun Ishiguro

Hidehiko Abe added 2 comments

File chrome/browser/ash/policy/skyvault/local_files_migration_manager.h

Line 54, Patchset 1 (Latest): explicit LocalFilesMigrationManager(PrefService* local_state,

Hidehiko Abe . unresolved

nit: s/explicit//

File chrome/browser/ash/policy/skyvault/local_files_migration_manager_unittest.cc

Line 163, Patchset 1 (Latest): PrefService* local_state() {

Hidehiko Abe . unresolved

nit: static

Open in Gerrit

Related details

Attention is currently required from:

• Jun Ishiguro

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia25b9588568a7ff3a20a4df80e30d2d5645f7db6

Gerrit-Change-Number: 8061513

Gerrit-PatchSet: 1

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jun Ishiguro <ju...@google.com>

Gerrit-Comment-Date: Wed, 08 Jul 2026 12:15:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jun Ishiguro (Gerrit)]

Attention needed from Hidehiko Abe

Jun Ishiguro added 3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jun Ishiguro . resolved

Thank you for the review!

File chrome/browser/ash/policy/skyvault/local_files_migration_manager.h

Line 54, Patchset 1: explicit LocalFilesMigrationManager(PrefService* local_state,

Hidehiko Abe . resolved

nit: s/explicit//

Jun Ishiguro

Done

File chrome/browser/ash/policy/skyvault/local_files_migration_manager_unittest.cc

Line 163, Patchset 1: PrefService* local_state() {

Hidehiko Abe . resolved

nit: static

Jun Ishiguro

Done

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia25b9588568a7ff3a20a4df80e30d2d5645f7db6

Gerrit-Change-Number: 8061513

Gerrit-PatchSet: 2

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Wed, 08 Jul 2026 13:39:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>

[Jun Ishiguro (Gerrit)]

Attention needed from Hidehiko Abe

Jun Ishiguro voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia25b9588568a7ff3a20a4df80e30d2d5645f7db6

Gerrit-Change-Number: 8061513

Gerrit-PatchSet: 2

Gerrit-Owner: Jun Ishiguro <ju...@google.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Jun Ishiguro <ju...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Wed, 08 Jul 2026 13:40:13 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes