Enable AcceleratedVideoDecodeLinuxGL flags [chromium/src : main]

0 views
Skip to first unread message

Kramer Ge (Gerrit)

unread,
4:24 PM (4 hours ago) 4:24 PM
to Vasiliy Telezhnikov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Vasiliy Telezhnikov

Kramer Ge voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:24:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ted (Chromium) Meyer (Gerrit)

unread,
4:49 PM (3 hours ago) 4:49 PM
to Kramer Ge, Dale Curtis, Chromium LUCI CQ, Vasiliy Telezhnikov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Kramer Ge and Vasiliy Telezhnikov

Ted (Chromium) Meyer voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:49:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
4:51 PM (3 hours ago) 4:51 PM
to Ted (Chromium) Meyer, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Kramer Ge voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:51:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
4:51 PM (3 hours ago) 4:51 PM
to Ted (Chromium) Meyer, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Kramer Ge added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kramer Ge . resolved

Thanks for +1!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:51:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Ted (Chromium) Meyer (Gerrit)

unread,
4:52 PM (3 hours ago) 4:52 PM
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Ted (Chromium) Meyer added 1 comment

Patchset-level comments
Ted (Chromium) Meyer . resolved

The default linux configuration is to use Vulkan, rendering this flag moot. I had considered experimenting, but there isn't a meaningful population that:
1. uses flags to disable vulkan
2. uses linux
3. gets finch configs

So this is _probably_ fine (I use this flag on my personal machine), but there might be angry linux users ranting on a forum somewhere about this.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
5:06 PM (3 hours ago) 5:06 PM
to Ted (Chromium) Meyer, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Kramer Ge added 1 comment

Patchset-level comments
Ted (Chromium) Meyer . resolved

The default linux configuration is to use Vulkan, rendering this flag moot. I had considered experimenting, but there isn't a meaningful population that:
1. uses flags to disable vulkan
2. uses linux
3. gets finch configs

So this is _probably_ fine (I use this flag on my personal machine), but there might be angry linux users ranting on a forum somewhere about this.

Kramer Ge

Users that got moved from X11 sessions to wayland by their selected window management system would receive this treatment because chrome is running EGL there.

We've been running this for internal googlers, it appears to be fine, and we received requests from AMD to launch it. I've locally tested on a NVIDIA driver which appears to be OK.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 21:06:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ted (Chromium) Meyer <tmath...@chromium.org>
satisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
5:06 PM (3 hours ago) 5:06 PM
to Ted (Chromium) Meyer, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Kramer Ge voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863c2f675f9be4bea5bf5228be881574ec8f29f4
Gerrit-Change-Number: 7064471
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 21:06:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages