[GlowUp] Do not animate arrow on long mouse press [chromium/src : main]

[Dominic Austria (Gerrit)]

Attention needed from Emily Shack

Dominic Austria voted and added 2 comments

Votes added by Dominic Austria

Commit-Queue

+1

2 comments

Commit Message

Line 7, Patchset 1:I love the toolbar

Emily Shack . resolved

Glad you and the toolbar are getting along, but could you update this to be a bit more descriptive of your change?

Dominic Austria

Done

File chrome/browser/ui/views/toolbar/back_forward_button.cc

Line 155, Patchset 1 (Parent): event.IsLeftMouseButton();

Emily Shack . unresolved

Looks like you dropped the IsLeftMouseButton check. Just to confirm, is that because NotifyClick only is invoked on left button click, not right button click?

Dominic Austria

Thanks for flagging. After auditing the code, it seems I have no guarantee that NotifyClick() is not called with just left mouse button clicks, so I added the check that we are pressing the left mouse button from the passed in event

Open in Gerrit

Related details

Attention is currently required from:

• Emily Shack

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I12e746909dc5fc3f96310abc7dc2c0adc10d7de6

Gerrit-Change-Number: 8144326

Gerrit-PatchSet: 2

Gerrit-Owner: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Emily Shack <ems...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emily Shack <ems...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Jul 2026 23:17:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Emily Shack <ems...@chromium.org>

[Emily Shack (Gerrit)]

Attention needed from Dominic Austria

Emily Shack voted and added 1 comment

Votes added by Emily Shack

Code-Review

+1

1 comment

File chrome/browser/ui/views/toolbar/back_forward_button.cc

Line 155, Patchset 1 (Parent): event.IsLeftMouseButton();

Emily Shack . resolved

Looks like you dropped the IsLeftMouseButton check. Just to confirm, is that because NotifyClick only is invoked on left button click, not right button click?

Dominic Austria

Thanks for flagging. After auditing the code, it seems I have no guarantee that NotifyClick() is not called with just left mouse button clicks, so I added the check that we are pressing the left mouse button from the passed in event

Emily Shack

SGTM, thanks for checking!

Open in Gerrit

Related details

Attention is currently required from:

• Dominic Austria

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I12e746909dc5fc3f96310abc7dc2c0adc10d7de6

Gerrit-Change-Number: 8144326

Gerrit-PatchSet: 4

Gerrit-Owner: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Emily Shack <ems...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Dominic Austria <dominic...@google.com>

Gerrit-Comment-Date: Fri, 24 Jul 2026 23:22:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Dominic Austria <dominic...@google.com>

Comment-In-Reply-To: Emily Shack <ems...@chromium.org>

[Dominic Austria (Gerrit)]

Dominic Austria voted and added 1 comment

Votes added by Dominic Austria

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Dominic Austria . unresolved

Just I am going to merge this after branch for safety I think.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I12e746909dc5fc3f96310abc7dc2c0adc10d7de6

Gerrit-Change-Number: 8144326

Gerrit-PatchSet: 4

Gerrit-Owner: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Emily Shack <ems...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 25 Jul 2026 01:37:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Dominic Austria (Gerrit)]

Attention needed from Dominic Austria

Dominic Austria voted and added 1 comment

Votes added by Dominic Austria

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Dominic Austria . unresolved

Just I am going to merge this after branch for safety I think.

Dominic Austria

Nevermind I think this should be pretty safe and revertable

Open in Gerrit

Related details

Attention is currently required from:

• Dominic Austria

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I12e746909dc5fc3f96310abc7dc2c0adc10d7de6

Gerrit-Change-Number: 8144326

Gerrit-PatchSet: 4

Gerrit-Owner: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Emily Shack <ems...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Dominic Austria <dominic...@google.com>

Gerrit-Comment-Date: Sat, 25 Jul 2026 01:38:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Dominic Austria <dominic...@google.com>

[Dominic Austria (Gerrit)]

Dominic Austria voted and added 1 comment

Votes added by Dominic Austria

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Dominic Austria . resolved

Just I am going to merge this after branch for safety I think.

Dominic Austria

Nevermind I think this should be pretty safe and revertable

Dominic Austria

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I12e746909dc5fc3f96310abc7dc2c0adc10d7de6

Gerrit-Change-Number: 8144326

Gerrit-PatchSet: 4

Gerrit-Owner: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Emily Shack <ems...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 25 Jul 2026 01:38:10 +0000

[Dominic Austria (Gerrit)]

Dominic Austria voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I12e746909dc5fc3f96310abc7dc2c0adc10d7de6

Gerrit-Change-Number: 8144326

Gerrit-PatchSet: 4

Gerrit-Owner: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Dominic Austria <dominic...@google.com>

Gerrit-Reviewer: Emily Shack <ems...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 25 Jul 2026 17:37:40 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes