Roll zmij: 1.0.12 => 1.0.13 in //third_party/rust. [chromium/src : main]
0 views
Skip to first unread message
Daniel Rubery (Gerrit)
Jan 12, 2026, 5:35:23 PMJan 12
to chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from chrome-third-pa...@google.com
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jan 12, 2026, 5:37:39 PMJan 12
to Daniel Rubery, chrome-third-pa...@google.com, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Daniel Cheng
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq:
third-party-rust: dch...@chromium.org
It looks like you’re modifying `//third_party/rust`. An appropriate reviewer has been automatically added to this CL.
`//third_party/rust` reviewer(s): dch...@chromium.org
Reviewer source(s):
dch...@chromium.org is from context(googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq)
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jan 12, 2026, 8:33:30 PMJan 12
to Daniel Rubery, Daniel Cheng, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Daniel Rubery
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Cheng . resolved
Lots of SIMD and unsafe magic but... it looks plausible.
Related details
Attention is currently required from:
- Daniel Rubery
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Jan 13, 2026, 2:28:12 PMJan 13
to Daniel Cheng, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Daniel Rubery voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 13, 2026, 2:48:39 PMJan 13
to Daniel Rubery, Daniel Cheng, chrome-third-pa...@google.com, chromium...@chromium.org, chrome-rust-exper...@google.com
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/rust/chromium_crates_io/vendor/zmij-v1/src/lib.rs
Insertions: 21, Deletions: 83.
The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/rust/chromium_crates_io/vendor/zmij-v1/src/stdarch_x86.rs
Insertions: 1, Deletions: 3.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Roll zmij: 1.0.12 => 1.0.13 in //third_party/rust.
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* zmij: 1.0.12 => 1.0.13; https://docs.rs/crate/zmij/1.0.13
Bug: None
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Change-Id: I352ba715a74dc9add4c236ea0a053a16fa11cfca
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Rubery <dru...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568599}
Files:
- M third_party/rust/chromium_crates_io/Cargo.lock
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/.cargo_vcs_info.json
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/Cargo.lock
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/Cargo.toml
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/Cargo.toml.orig
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/README.md
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/src/lib.rs
- A third_party/rust/chromium_crates_io/vendor/zmij-v1/src/stdarch_x86.rs
- M third_party/rust/chromium_crates_io/vendor/zmij-v1/src/traits.rs
- M third_party/rust/zmij/v1/BUILD.gn
- M third_party/rust/zmij/v1/README.chromium
Change size: L
Delta: 11 files changed, 398 insertions(+), 270 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages