Disable slow browser test [chromium/src : main]

0 views
Skip to first unread message

Noam Rosenthal (Gerrit)

unread,
Jan 12, 2026, 8:59:35 AM (24 hours ago) Jan 12
to chromium...@chromium.org, mfoltz+wa...@chromium.org

Noam Rosenthal voted and added 1 comment

Votes added by Noam Rosenthal

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Noam Rosenthal . resolved

(Gardener, applying owners-override)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
Gerrit-Change-Number: 7450980
Gerrit-PatchSet: 1
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 13:59:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Jan 12, 2026, 8:59:51 AM (24 hours ago) Jan 12
to Rubber Stamper, chromium...@chromium.org, mfoltz+wa...@chromium.org

Noam Rosenthal voted Code-Review+0

Code-Review+0
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
Gerrit-Change-Number: 7450980
Gerrit-PatchSet: 1
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 13:59:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 12, 2026, 9:00:21 AM (24 hours ago) Jan 12
to Noam Rosenthal, chromium...@chromium.org, mfoltz+wa...@chromium.org

Message from Rubber Stamper

The change cannot be auto-reviewed. The following files do not match the benign file configuration: chrome/browser/actor/tools/page_tool_browsertest.cc. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
Gerrit-Change-Number: 7450980
Gerrit-PatchSet: 1
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 14:00:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

thefrog (Gerrit)

unread,
Jan 12, 2026, 9:25:14 AM (23 hours ago) Jan 12
to Noam Rosenthal, Caleb Raitto, chromium...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Caleb Raitto and Noam Rosenthal

thefrog voted and added 2 comments

Votes added by thefrog

Code-Review+1

2 comments

Commit Message
Line 12, Patchset 1 (Latest):Bug: 453258855
thefrog . unresolved

I don't think this is the right bug because it's for file type_tool_browsertest.cc. Could you file + link a separate bug?

File chrome/browser/actor/tools/page_tool_browsertest.cc
Line 106, Patchset 1 (Latest):#if defined(ADDRESS_SANITIZER) || !defined(NDEBUG)
thefrog . unresolved

I can't find the build link, but if it's for builder "chromium/ci/Linux Tests (dbg)(1)" then could you limit this to Linux?

Open in Gerrit

Related details

Attention is currently required from:
  • Caleb Raitto
  • Noam Rosenthal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
    Gerrit-Change-Number: 7450980
    Gerrit-PatchSet: 1
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Caleb Raitto <cara...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: thefrog <the...@chromium.org>
    Gerrit-Attention: Caleb Raitto <cara...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 14:25:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Noam Rosenthal (Gerrit)

    unread,
    Jan 12, 2026, 9:44:58 AM (23 hours ago) Jan 12
    to thefrog, Caleb Raitto, chromium...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Caleb Raitto

    Noam Rosenthal voted and added 2 comments

    Votes added by Noam Rosenthal

    Owners-Override+1

    2 comments

    Commit Message
    Line 12, Patchset 1:Bug: 453258855
    thefrog . resolved

    I don't think this is the right bug because it's for file type_tool_browsertest.cc. Could you file + link a separate bug?

    Noam Rosenthal

    Done

    File chrome/browser/actor/tools/page_tool_browsertest.cc
    Line 106, Patchset 1:#if defined(ADDRESS_SANITIZER) || !defined(NDEBUG)
    thefrog . resolved

    I can't find the build link, but if it's for builder "chromium/ci/Linux Tests (dbg)(1)" then could you limit this to Linux?

    Noam Rosenthal

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Caleb Raitto
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
      Gerrit-Change-Number: 7450980
      Gerrit-PatchSet: 3
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Caleb Raitto <cara...@chromium.org>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: thefrog <the...@chromium.org>
      Gerrit-Attention: Caleb Raitto <cara...@chromium.org>
      Gerrit-Comment-Date: Mon, 12 Jan 2026 14:44:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: thefrog <the...@chromium.org>
      satisfied_requirement
      open
      diffy

      Noam Rosenthal (Gerrit)

      unread,
      Jan 12, 2026, 9:45:00 AM (23 hours ago) Jan 12
      to thefrog, Caleb Raitto, chromium...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Caleb Raitto

      Noam Rosenthal voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Caleb Raitto
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
      Gerrit-Change-Number: 7450980
      Gerrit-PatchSet: 3
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Caleb Raitto <cara...@chromium.org>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: thefrog <the...@chromium.org>
      Gerrit-Attention: Caleb Raitto <cara...@chromium.org>
      Gerrit-Comment-Date: Mon, 12 Jan 2026 14:44:47 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 12, 2026, 10:17:45 AM (22 hours ago) Jan 12
      to Noam Rosenthal, thefrog, Caleb Raitto, chromium...@chromium.org, mfoltz+wa...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      1 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: chrome/browser/actor/tools/page_tool_browsertest.cc
      Insertions: 1, Deletions: 1.

      @@ -103,7 +103,7 @@
       // Type so much text that a timeout occurs. Then, try again typing a single
       // character, which should succeed.
       
      -#if defined(ADDRESS_SANITIZER) || !defined(NDEBUG)
      +#if BUILDFLAG(IS_LINUX) && defined(ADDRESS_SANITIZER) && !defined(NDEBUG)
       #define MAYBE_Timeout DISABLED_Timeout
       #else
       #define MAYBE_Timeout Timeout
      ```

      Change information

      Commit message:
      Disable slow browser test

      Test: ActorPageToolTimeoutBrowserTest/Timeout
      Disabling on debug/ASAN

      Failing build: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29
      Bug: 453258855
      Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
      Reviewed-by: thefrog <the...@chromium.org>
      Owners-Override: Noam Rosenthal <nrose...@google.com>
      Commit-Queue: Noam Rosenthal <nrose...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1567757}
      Files:
      • M chrome/browser/actor/tools/page_tool_browsertest.cc
      Change size: XS
      Delta: 1 file changed, 7 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by thefrog
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
      Gerrit-Change-Number: 7450980
      Gerrit-PatchSet: 4
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Caleb Raitto <cara...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement

      Caleb Raitto (Gerrit)

      unread,
      Jan 12, 2026, 11:05:41 AM (22 hours ago) Jan 12
      to Chromium LUCI CQ, Noam Rosenthal, thefrog, chromium...@chromium.org, mfoltz+wa...@chromium.org

      Caleb Raitto voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib5ccb878f14325793eb3194e299f652b7bd31aac
      Gerrit-Change-Number: 7450980
      Gerrit-PatchSet: 4
      Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: Caleb Raitto <cara...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-Reviewer: thefrog <the...@chromium.org>
      Gerrit-Comment-Date: Mon, 12 Jan 2026 16:05:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages