Add Heartbeat related methods to CorpServiceClient [chromium/src : main]
0 views
Skip to first unread message
Joe Downing (Gerrit)
Sep 22, 2024, 11:01:40 AM9/22/24
to Yuwei Huang, Nicolas Ouellet-Payeur, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Nicolas Ouellet-Payeur and Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Nicolas Ouellet-Payeur
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Sep 23, 2024, 5:58:04 PM9/23/24
to Joe Downing, Nicolas Ouellet-Payeur, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Joe Downing and Nicolas Ouellet-Payeur
Yuwei Huang voted and added 3 comments![]( "Open in Gerrit")
Votes added by Yuwei Huang
| Code-Review | +1 |
3 comments
File remoting/base/corp_service_client.cc
Line 154, Patchset 3 (Latest):
"if the CRD host is not configured and run on a Corp machine."Yuwei Huang . unresolved
nit: maybe ", or if it is not run"? The use of "and" could be ambiguous and misunderstood as "will not be sent on a corp machine".
Line 203, Patchset 3 (Latest):
"if the CRD host is not configured and run on a Corp machine."Yuwei Huang . unresolved
ditto
File remoting/proto/internal_stubs.h
Line 81, Patchset 3 (Latest):
GetUpdateRemoteAccessHostRequest(const std::string& directory_id,Yuwei Huang . resolved
As I mentioned in the internal CL, it might be more manageable to pass these as a struct, but I'm fine if you fix this in a separate CL.
Related details
Attention is currently required from:
- Joe Downing
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Sep 23, 2024, 7:59:47 PM9/23/24
to Yuwei Huang, Nicolas Ouellet-Payeur, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Nicolas Ouellet-Payeur
Joe Downing voted and added 4 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +1 |
| Commit-Queue | +1 |
4 comments
Patchset-level comments
File remoting/base/corp_service_client.cc
Line 154, Patchset 3:
"if the CRD host is not configured and run on a Corp machine."Yuwei Huang . resolved
nit: maybe ", or if it is not run"? The use of "and" could be ambiguous and misunderstood as "will not be sent on a corp machine".
Joe Downing
Thanks I missed that while editing the annotation. I've fixed it to be more clear.
Line 203, Patchset 3:
"if the CRD host is not configured and run on a Corp machine."Yuwei Huang . resolved
Joe Downingditto
Done
File remoting/proto/internal_stubs.h
Line 81, Patchset 3:
GetUpdateRemoteAccessHostRequest(const std::string& directory_id,Yuwei Huang . resolved
As I mentioned in the internal CL, it might be more manageable to pass these as a struct, but I'm fine if you fix this in a separate CL.
Attention is currently required from:
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Ouellet-Payeur (Gerrit)
Sep 24, 2024, 10:11:22 AM9/24/24
to Joe Downing, Chromium LUCI CQ, Yuwei Huang, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Joe Downing
Nicolas Ouellet-Payeur voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicolas Ouellet-Payeur
| Code-Review | +1 |
1 comment
Patchset-level comments
Nicolas Ouellet-Payeur . resolved
`//tools/traffic_annotation` LGTM
Not triggering autosubmit, because bots were red in the dry-run
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Sep 24, 2024, 10:15:21 AM9/24/24
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, Yuwei Huang, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Joe Downing voted and added 2 comments![]( "Open in Gerrit")
Votes added by Joe Downing
| Auto-Submit | +0 |
2 comments
Patchset-level comments
Nicolas Ouellet-Payeur . resolved
`//tools/traffic_annotation` LGTM
Not triggering autosubmit, because bots were red in the dry-run
Joe Downing
Thanks! The failures are unrelated ([2034/11530] SOLINK ./libchromeos_ui_clipboard_history.so) so I'm going to rebase and submit.
Joe Downing . resolved
Thanks!
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Sep 24, 2024, 10:17:52 AM9/24/24
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, Yuwei Huang, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Joe Downing voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Sep 24, 2024, 10:46:34 AM9/24/24
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, Yuwei Huang, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Nicolas Ouellet-Payeur and Yuwei Huang
Joe Downing added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Joe Downing . resolved
It turns out there was another build issue (masked by the external failure) that I had to address. Can i get you guys to +1 again?
Thanks!
Related details
Attention is currently required from:
- Nicolas Ouellet-Payeur
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Ouellet-Payeur (Gerrit)
Sep 24, 2024, 1:20:38 PM9/24/24
to Joe Downing, Chromium LUCI CQ, Yuwei Huang, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Joe Downing and Yuwei Huang
Nicolas Ouellet-Payeur voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joe Downing
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Sep 24, 2024, 2:11:45 PM9/24/24
to Joe Downing, Nicolas Ouellet-Payeur, Chromium LUCI CQ, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Attention needed from Joe Downing
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Joe Downing
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Sep 24, 2024, 2:19:13 PM9/24/24
to Yuwei Huang, Nicolas Ouellet-Payeur, Chromium LUCI CQ, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 24, 2024, 2:22:09 PM9/24/24
to Joe Downing, Yuwei Huang, Nicolas Ouellet-Payeur, AyeAye, Tricium, chromium...@chromium.org, chromotin...@chromium.org, crmulli...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, jorgel...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add Heartbeat related methods to CorpServiceClient
These are analogous to the methods on the Cloud service client
but with the service details in //remoting/internal.
Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/remoting/internal/+/7698773
Change-Id: I711e09fe1fad84f3d2be6b4e753902eec674c043
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nico...@chromium.org>
Commit-Queue: Joe Downing <joe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359488}
Files:
- M remoting/base/corp_service_client.cc
- M remoting/base/corp_service_client.h
- M remoting/host/setup/corp_host_starter.cc
- M remoting/proto/internal_stubs.cc
- M remoting/proto/internal_stubs.h
- M tools/traffic_annotation/summary/annotations.xml
- M tools/traffic_annotation/summary/grouping.xml
Change size: M
Delta: 7 files changed, 157 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicolas Ouellet-Payeur, +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages