Pref: Add kInputKrispNoiseCancellationEnabled [chromium/src : main]
0 views
Skip to first unread message
Hung-Hsien Chen (Gerrit)
Mar 20, 2026, 4:53:15 PM (3 days ago) Mar 20
to chromium...@chromium.org
Hung-Hsien Chen has uploaded the change for review![]( "Open in Gerrit")
Commit message
Pref: Add kInputKrispNoiseCancellationEnabled
This pref will be used to indicate whether the Krisp noise cancellation
is enabled or not.
It is expected to reflect corresponding changes from Admin Policy.
Will make the audio handler listen to this pref change in following CLs.
Bug: 463837927
Test: None
Change-Id: Ie762032ca9a80a5e0dcea1834a98dfe6c9e6a034
Change diff
diff --git a/ash/constants/ash_pref_names.h b/ash/constants/ash_pref_names.h
index 7e5efb8..6d9bc92 100644
--- a/ash/constants/ash_pref_names.h
+++ b/ash/constants/ash_pref_names.h
@@ -318,6 +318,10 @@
inline constexpr char kInputVoiceIsolationPreferredEffect[] =
"ash.input_voice_isolation_preferred_effect";
+// A boolean pref that controls whether Krisp noise cancellation is enabled.
+inline constexpr char kInputKrispNoiseCancellationEnabled[] =
+ "ash.input_krisp_noise_cancellation_enabled";
+
// A boolean pref that controls whether input noise cancellation is enabled.
inline constexpr char kInputNoiseCancellationEnabled[] =
"ash.input_noise_cancellation_enabled";
Change information
Files:
- M ash/constants/ash_pref_names.h
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Mar 20, 2026, 5:06:23 PM (3 days ago) Mar 20
to Hung-Hsien Chen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Hung-Hsien Chen
James Cook voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hung-Hsien Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Li-Yu Yu (Gerrit)
12:54 AM (18 hours ago) 12:54 AM
to Hung-Hsien Chen, Andy Rollo, James Cook, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Hung-Hsien Chen
Li-Yu Yu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hung-Hsien Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hung-Hsien Chen (Gerrit)
10:08 AM (9 hours ago) 10:08 AM
to Li-Yu Yu, Andy Rollo, James Cook, Chromium LUCI CQ, chromium...@chromium.org
Hung-Hsien Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:42 AM (9 hours ago) 10:42 AM
to Hung-Hsien Chen, Li-Yu Yu, Andy Rollo, James Cook, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Pref: Add kInputKrispNoiseCancellationEnabled
This pref will be used to indicate whether the Krisp noise cancellation
is enabled or not.
It is expected to reflect corresponding changes from Admin Policy.
Will make the audio handler listen to this pref change in following CLs.
Bug: 463837927
Test: None
Change-Id: Ie762032ca9a80a5e0dcea1834a98dfe6c9e6a034
Reviewed-by: James Cook <jame...@chromium.org>
Reviewed-by: Li-Yu Yu <aar...@google.com>
Commit-Queue: Hung-Hsien Chen <hunghs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1603464}
Files:
- M ash/constants/ash_pref_names.h
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by James Cook, +1 by Li-Yu Yu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages