[ios] Fix flakiness in BookmarksTestCase [chromium/src : main]

0 views
Skip to first unread message

Scott Yoder (Gerrit)

unread,
Apr 20, 2026, 9:15:40 PM (10 days ago) Apr 20
to Arthur Milchior, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Arthur Milchior

Scott Yoder added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Scott Yoder . resolved

Please take a look. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Milchior
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ce7b24ed69b729a226525694f01dc81b8fb6cc0
Gerrit-Change-Number: 7780166
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Yoder <scott...@google.com>
Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>
Gerrit-Reviewer: Scott Yoder <scott...@google.com>
Gerrit-Attention: Arthur Milchior <arthurm...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 01:15:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Milchior (Gerrit)

unread,
Apr 21, 2026, 6:22:28 AM (10 days ago) Apr 21
to Scott Yoder, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder

Arthur Milchior voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Scott Yoder
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ce7b24ed69b729a226525694f01dc81b8fb6cc0
Gerrit-Change-Number: 7780166
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Yoder <scott...@google.com>
Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>
Gerrit-Reviewer: Scott Yoder <scott...@google.com>
Gerrit-Attention: Scott Yoder <scott...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 10:22:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Scott Yoder (Gerrit)

unread,
Apr 21, 2026, 7:17:05 AM (10 days ago) Apr 21
to Arthur Milchior, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Scott Yoder voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ce7b24ed69b729a226525694f01dc81b8fb6cc0
Gerrit-Change-Number: 7780166
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Yoder <scott...@google.com>
Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>
Gerrit-Reviewer: Scott Yoder <scott...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 11:16:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 21, 2026, 8:33:16 AM (10 days ago) Apr 21
to Scott Yoder, Arthur Milchior, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ios] Fix flakiness in BookmarksTestCase

Wait for the bookmarks table view to appear in reopenBookmarks before
returning control to the test. This ensures the UI is fully presented
and loaded before assertions are made, fixing flakiness where assertions
checked for visibility before the UI was ready.
Fixed: 483351045
Change-Id: I9ce7b24ed69b729a226525694f01dc81b8fb6cc0
Commit-Queue: Scott Yoder <scott...@google.com>
Reviewed-by: Arthur Milchior <arthurm...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618093}
Files:
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Arthur Milchior
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ce7b24ed69b729a226525694f01dc81b8fb6cc0
Gerrit-Change-Number: 7780166
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Yoder <scott...@google.com>
Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages