[ios] Fix flakiness in BookmarksTestCase [chromium/src : main]
0 views
Skip to first unread message
Scott Yoder (Gerrit)
Apr 20, 2026, 9:15:40 PM (10 days ago) Apr 20
to Arthur Milchior, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Arthur Milchior
Scott Yoder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Arthur Milchior
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Milchior (Gerrit)
Apr 21, 2026, 6:22:28 AM (10 days ago) Apr 21
to Scott Yoder, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Arthur Milchior voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
Apr 21, 2026, 7:17:05 AM (10 days ago) Apr 21
to Arthur Milchior, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Scott Yoder voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 8:33:16 AM (10 days ago) Apr 21
to Scott Yoder, Arthur Milchior, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ios] Fix flakiness in BookmarksTestCase
Wait for the bookmarks table view to appear in reopenBookmarks before
returning control to the test. This ensures the UI is fully presented
and loaded before assertions are made, fixing flakiness where assertions
checked for visibility before the UI was ready.
Fixed: 483351045
Change-Id: I9ce7b24ed69b729a226525694f01dc81b8fb6cc0
Commit-Queue: Scott Yoder <scott...@google.com>
Reviewed-by: Arthur Milchior <arthurm...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618093}
Files:
- M ios/chrome/browser/bookmarks/test/bookmarks_egtest.mm
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Arthur Milchior
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages