Add an about:flags entry for disabling hyperlink auditing. (issue5393001)
joc...@chromium.org
following:
the purpose of this feature is to speed up web browsing by avoiding the
usual
redirect to track clicks. However, web pages are unlikely to use this
feature if
not almost all users have this feature enabled.
hth
-jochen
pe...@chromium.org
Message:
On 2010/11/26 19:32:46, jochen wrote:
> the reason we decided against having UI for disabling a-ping is the
> following:
> the purpose of this feature is to speed up web browsing by avoiding the
> usual
> redirect to track clicks. However, web pages are unlikely to use this
> feature
if
> not almost all users have this feature enabled.
> hth
> -jochen
While, in essence, I agree, I also think Julian got a point in the issue.
Quite
some people worry about their privacy and there is already enough
rumoring/fud
about the browser which also was the reason the spec makes a note about
this.
Until an API for features such as this is available for more convenient
disabling, I don't think supporting this in about:flags does any harm.
Regardless, I do understand the position on this, but then I also think we
should be clear in saying there won't be an UI option until any kind of API
is
available. By this I mean that issue 59024 should be closed saying exactly
that.
If the consensus is that it's better to not add this to about:flags, can I
go on
and do so?
Regards,
Peter
Description:
Add an about:flags entry for disabling hyperlink auditing.
BUG=59024
TEST=none
Please review this at http://codereview.chromium.org/5393001/
SVN Base: http://src.chromium.org/svn/trunk/src/
Affected files:
M chrome/app/generated_resources.grd
M chrome/browser/about_flags.cc
Index: chrome/app/generated_resources.grd
===================================================================
--- chrome/app/generated_resources.grd (revision 67437)
+++ chrome/app/generated_resources.grd (working copy)
@@ -4173,6 +4173,12 @@
<message name="IDS_FLAGS_CLICK_TO_PLAY_DESCRIPTION"
desc="Description of the 'Click to play' lab.">
Enables a "click to play" option in the plug-in content settings.
</message>
+ <message name="IDS_FLAGS_DISABLE_HYPERLINK_AUDITING_NAME" desc="Name
of the 'Disable hyperlink auditing' lab.">
+ Disable hyperlink auditing
+ </message>
+ <message name="IDS_FLAGS_DISABLE_HYPERLINK_AUDITING_DESCRIPTION"
desc="Description of the 'Disable hyperlink auditing' lab.">
+ Disable sending hyperlink auditing pings.
+ </message>
<!-- Instant -->
<message name="IDS_INSTANT_OPT_IN_ENABLE" desc="Button shown in the
omnibox dropdown for enabling instant">
Index: chrome/browser/about_flags.cc
===================================================================
--- chrome/browser/about_flags.cc (revision 67437)
+++ chrome/browser/about_flags.cc (working copy)
@@ -234,6 +234,13 @@
kOsAll,
switches::kEnableClickToPlay
},
+ {
+ "disable-hyperlink-auditing",
+ IDS_FLAGS_DISABLE_HYPERLINK_AUDITING_NAME,
+ IDS_FLAGS_DISABLE_HYPERLINK_AUDITING_DESCRIPTION,
+ kOsAll,
+ switches::kNoPings
+ }
};
const Experiment* experiments = kExperiments;
joc...@chromium.org
Yes, we should be transparent about this. You can wait for Darin to
comment, but
from my point of view, having this in about:flags is not a great solution.
pe...@chromium.org
Darin Fisher
joc...@chromium.org
pe...@chromium.org
> LGTM
Could you commit it please, as I don't have commit privileges?
