[bling][sheriff] Mark multiple tests flaky [chromium/src : main]

Sergio Collazos (Gerrit)

unread,

Jul 1, 2022, 5:35:53 PM7/1/22

to Tina Wang, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, Tricium, chromium...@chromium.org, Enterprise Policy Reviews

Attention is currently required from: Tina Wang.

Patch set 2:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  LGTM

To view, visit change 3741273. To unsubscribe, or for help writing mail filters, visit settings.

Tina Wang (Gerrit)

unread,

Jul 1, 2022, 11:22:26 PM7/1/22

to ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, Sergio Collazos, Tricium, chromium...@chromium.org, Enterprise Policy Reviews

Attention is currently required from: Tina Wang.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 3741273. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jul 2, 2022, 12:25:38 AM7/2/22

to Tina Wang, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, Sergio Collazos, Tricium, chromium...@chromium.org, Enterprise Policy Reviews

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Tina Wang: Send CL to CQ automatically after approval; Commit; Looks good to me
  Sergio Collazos: Looks good to me

[bling][sheriff] Mark multiple tests flaky

iphone-simulator builder is failed by multiple tests.

https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator

This cl marked below tests as flaky:
PolicyTestCase/testTranslateEnabled
KeyboardCommandsTestCase/testKeyboardCommandsNotRegistered_AddBookmarkPresented

Bug: 1341363
Change-Id: I7cdcb880df9dd233fcf077cc4e980f24fa031de4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3741273
Auto-Submit: Tina Wang <tina...@chromium.org>
Reviewed-by: Sergio Collazos <sc...@chromium.org>
Owners-Override: Tina Wang <tina...@chromium.org>
Commit-Queue: Tina Wang <tina...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1020339}
---
M ios/chrome/browser/policy/policy_egtest.mm
M ios/chrome/browser/ui/keyboard/keyboard_commands_egtest.mm
2 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/ios/chrome/browser/policy/policy_egtest.mm b/ios/chrome/browser/policy/policy_egtest.mm
index 1071c65..a3035c4 100644
--- a/ios/chrome/browser/policy/policy_egtest.mm
+++ b/ios/chrome/browser/policy/policy_egtest.mm
@@ -307,7 +307,8 @@
 
 // Tests that language detection is not performed and the tool manual trigger
 // button is disabled when the pref kOfferTranslateEnabled is set to false.
-- (void)testTranslateEnabled {
+// TODO(crbug.com/1341363): Disabled due to flakiness. Re-enabled when fixed.
+- (void)DISABLED_testTranslateEnabled {
   GREYAssertTrue(self.testServer->Start(), @"Test server failed to start.");
   const GURL testURL = self.testServer->GetURL("/pony.html");
   const std::string pageText = "pony";
diff --git a/ios/chrome/browser/ui/keyboard/keyboard_commands_egtest.mm b/ios/chrome/browser/ui/keyboard/keyboard_commands_egtest.mm
index f395a7f..8100601 100644
--- a/ios/chrome/browser/ui/keyboard/keyboard_commands_egtest.mm
+++ b/ios/chrome/browser/ui/keyboard/keyboard_commands_egtest.mm
@@ -104,7 +104,8 @@
 
 // Tests that keyboard commands are not registered when the bookmark UI is
 // shown.
-- (void)testKeyboardCommandsNotRegistered_AddBookmarkPresented {
+// TODO(crbug.com/1341363): Disabled due to flakiness. Re-enabled when fixed.
+- (void)DISABLED_testKeyboardCommandsNotRegistered_AddBookmarkPresented {
   [ChromeEarlGrey waitForBookmarksToFinishLoading];
   [ChromeEarlGrey clearBookmarks];

To view, visit change 3741273. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward