Revert "[TabBottomSheet] Restructure files" [chromium/src : main]

0 views
Skip to first unread message

Chrome Crash (Prod) (Gerrit)

unread,
3:08 AM (10 hours ago) 3:08 AM
to Chromium LUCI CQ, Calder Kitagawa, Hitarth Kothari, chromium...@chromium.org
Attention needed from Calder Kitagawa and Hitarth Kothari

Chrome Crash (Prod) has uploaded the change for review

Chrome Crash (Prod) would like Chromium LUCI CQ, Calder Kitagawa and Hitarth Kothari to review this change.

Commit message

Revert "[TabBottomSheet] Restructure files"

This reverts commit b0a26aa11f11586cfdbe9154ab8d3b6214996465.

Reason for revert:
The Suspect CL https://chromium-review.googlesource.com/q/Ic9eec323a4fa92cf69908d42734e6fe91746bece is highly likely the cause of the crash. Please see the crash report http://crash/e732e41d2710d1f2.
Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.

If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.

More details can be found in the go/crash-revert-cls-creation.

Original change's description:
> [TabBottomSheet] Restructure files
>
> Bug: 476103594
> Change-Id: Ic9eec323a4fa92cf69908d42734e6fe91746bece
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7487730
> Auto-Submit: Hitarth Kothari <hitarth...@google.com>
> Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
> Commit-Queue: Hitarth Kothari <hitarth...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1569982}
>
Bug: 476519347
Bug: 476103594
Change-Id: If6be4cc4e33da47fa79233d0435dd74101be3c72

Change diff


Change information

Files:
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetCoordinator.java
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetCoordinatorTest.java
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetManager.java
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetManagerTest.java
  • D chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetSimpleManager.java
  • A chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetToolbarContainer.java
  • A chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetToolbarContainerTest.java
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetUtils.java
  • M chrome/android/features/tab_ui/tab_management_java_sources.gni
  • M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
  • M chrome/android/junit/BUILD.gn
Change size: L
Delta: 11 files changed, 333 insertions(+), 133 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
  • Hitarth Kothari
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6be4cc4e33da47fa79233d0435dd74101be3c72
Gerrit-Change-Number: 7486662
Gerrit-PatchSet: 1
Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hitarth Kothari <hitarth...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Attention: Hitarth Kothari <hitarth...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages