[scoped-registry] Ensure custom element registry attribute in template is serialized [chromium/src : main]
0 views
Skip to first unread message
Jayson Chen (Gerrit)
Sep 4, 2025, 1:19:12 PM (3 days ago) Sep 4
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar and Mason Freed
Jayson Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jayson Chen . resolved
A small CL to ensure customelementregistry attribute is serialized correctly. PTAL, thanks!
Related details
Attention is currently required from:
- Joey Arhar
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Sep 4, 2025, 1:48:35 PM (3 days ago) Sep 4
to Jayson Chen, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Jayson Chen and Mason Freed
Joey Arhar voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jayson Chen
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Sep 4, 2025, 5:25:49 PM (2 days ago) Sep 4
to Jayson Chen, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Jayson Chen
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jayson Chen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayson Chen (Gerrit)
Sep 4, 2025, 7:51:36 PM (2 days ago) Sep 4
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Jayson Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 9:12:28 PM (2 days ago) Sep 4
to Jayson Chen, Mason Freed, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[scoped-registry] Ensure custom element registry attribute in template is serialized
While serializing a shadow host and a shadow root, we should ensure that
as long as the custom element registry hold by the host and shadow root
are different, the attribute shadowrootcustomelementregistry should be
serialized.
Bug: 40826514
Change-Id: I685a8b9b8578bc9e753c145b93306c8d33b8a72d
Reviewed-by: Joey Arhar <jar...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Jayson Chen <jayso...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1511258}
Files:
- M third_party/blink/renderer/core/editing/serializers/markup_accumulator.cc
- M third_party/blink/web_tests/virtual/scoped-custom-element-registry/external/wpt/custom-elements/registries/template.window-expected.txt
Change size: XS
Delta: 2 files changed, 4 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed, +1 by Joey Arhar
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages