Reland "Override credential selection for actor login on password change tasks" [chromium/src : main]

0 views
Skip to first unread message

Ioana Treib (Gerrit)

unread,
Mar 20, 2026, 12:40:24 PM (4 days ago) Mar 20
to Fiorella Barrientos Villalta, AyeAye, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Fiorella Barrientos Villalta and Kevin McNee

Ioana Treib added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ioana Treib . unresolved

Is this ready for review? What is the diff to the reverted CL?

Open in Gerrit

Related details

Attention is currently required from:
  • Fiorella Barrientos Villalta
  • Kevin McNee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
Gerrit-Change-Number: 7685476
Gerrit-PatchSet: 1
Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ioana Treib <ioa...@chromium.org>
Gerrit-Reviewer: Kevin McNee <mc...@chromium.org>
Gerrit-Attention: Kevin McNee <mc...@chromium.org>
Gerrit-Attention: Fiorella Barrientos Villalta <fior...@google.com>
Gerrit-Comment-Date: Fri, 20 Mar 2026 16:40:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiorella Barrientos Villalta (Gerrit)

unread,
Mar 20, 2026, 6:22:23 PM (4 days ago) Mar 20
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org

Fiorella Barrientos Villalta added 1 comment

Patchset-level comments
Ioana Treib . resolved

Is this ready for review? What is the diff to the reverted CL?

Fiorella Barrientos Villalta

Not ready, created the rebase to patch it and work on it. Will remove the reviewers for now. But the CL had nothing wrong, the test is flaky in general (it was disabled in win / linux already). So I will fix the flakiness here and send it for review again .

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
    Gerrit-Change-Number: 7685476
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Comment-Date: Fri, 20 Mar 2026 22:22:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ioana Treib <ioa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Fiorella Barrientos Villalta (Gerrit)

    unread,
    Mar 20, 2026, 6:22:41 PM (4 days ago) Mar 20
    to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org

    Fiorella Barrientos Villalta added 1 comment

    Patchset-level comments
    Ioana Treib . resolved

    Is this ready for review? What is the diff to the reverted CL?

    Fiorella Barrientos Villalta

    Not ready, created the rebase to patch it and work on it. Will remove the reviewers for now. But the CL had nothing wrong, the test is flaky in general (it was disabled in win / linux already). So I will fix the flakiness here and send it for review again .

    Fiorella Barrientos Villalta

    reland*

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
    Gerrit-Change-Number: 7685476
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Comment-Date: Fri, 20 Mar 2026 22:22:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Fiorella Barrientos Villalta <fior...@google.com>
    Comment-In-Reply-To: Ioana Treib <ioa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Viktor Semeniuk (Gerrit)

    unread,
    9:54 AM (12 hours ago) 9:54 AM
    to Fiorella Barrientos Villalta, Kevin McNee, Ioana Treib, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Fiorella Barrientos Villalta, Ioana Treib and Kevin McNee

    Viktor Semeniuk added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Viktor Semeniuk . resolved

    Hi, relanding the CL on behalf of Fiorella, PTAL
    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fiorella Barrientos Villalta
    • Ioana Treib
    • Kevin McNee
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
    Gerrit-Change-Number: 7685476
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ioana Treib <ioa...@chromium.org>
    Gerrit-Reviewer: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: Viktor Semeniuk <vsem...@google.com>
    Gerrit-Attention: Kevin McNee <mc...@chromium.org>
    Gerrit-Attention: Fiorella Barrientos Villalta <fior...@google.com>
    Gerrit-Attention: Ioana Treib <ioa...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Mar 2026 13:54:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kevin McNee (Gerrit)

    unread,
    11:21 AM (11 hours ago) 11:21 AM
    to Viktor Semeniuk, Fiorella Barrientos Villalta, Ioana Treib, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Fiorella Barrientos Villalta, Ioana Treib and Viktor Semeniuk

    Kevin McNee voted and added 1 comment

    Votes added by Kevin McNee

    Code-Review+1

    1 comment

    Patchset-level comments
    Viktor Semeniuk . unresolved

    Hi, relanding the CL on behalf of Fiorella, PTAL
    Thanks!

    Kevin McNee

    According to an above comment, there's some unaddressed flakiness.

    But since the actor code is unchanged, LGTM for that.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fiorella Barrientos Villalta
    • Ioana Treib
    • Viktor Semeniuk
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
      Gerrit-Change-Number: 7685476
      Gerrit-PatchSet: 3
      Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Ioana Treib <ioa...@chromium.org>
      Gerrit-Reviewer: Kevin McNee <mc...@chromium.org>
      Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Attention: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Attention: Fiorella Barrientos Villalta <fior...@google.com>
      Gerrit-Attention: Ioana Treib <ioa...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Mar 2026 15:20:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Viktor Semeniuk <vsem...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ioana Treib (Gerrit)

      unread,
      11:36 AM (10 hours ago) 11:36 AM
      to Viktor Semeniuk, Fiorella Barrientos Villalta, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Fiorella Barrientos Villalta and Viktor Semeniuk

      Ioana Treib voted and added 1 comment

      Votes added by Ioana Treib

      Code-Review+1

      1 comment

      Commit Message
      Line 9, Patchset 3 (Latest):This is a reland of commit 804a4486015db9fdce9e8ae90cf3bbc871334b0c
      Ioana Treib . unresolved

      Please state what you did in this relant that makes it different from the CL that was reverted.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fiorella Barrientos Villalta
      • Viktor Semeniuk
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
      Gerrit-Change-Number: 7685476
      Gerrit-PatchSet: 3
      Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Ioana Treib <ioa...@chromium.org>
      Gerrit-Reviewer: Kevin McNee <mc...@chromium.org>
      Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Attention: Viktor Semeniuk <vsem...@google.com>
      Gerrit-Attention: Fiorella Barrientos Villalta <fior...@google.com>
      Gerrit-Comment-Date: Tue, 24 Mar 2026 15:35:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Viktor Semeniuk (Gerrit)

      unread,
      1:14 PM (9 hours ago) 1:14 PM
      to Fiorella Barrientos Villalta, Ioana Treib, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Fiorella Barrientos Villalta

      Viktor Semeniuk added 2 comments

      Patchset-level comments
      File-level comment, Patchset 3:
      Viktor Semeniuk . resolved

      Hi, relanding the CL on behalf of Fiorella, PTAL
      Thanks!

      Kevin McNee

      According to an above comment, there's some unaddressed flakiness.

      But since the actor code is unchanged, LGTM for that.

      Viktor Semeniuk

      Ah, didn't notice. I fixed the test and reenabled it.

      Commit Message
      Line 9, Patchset 3:This is a reland of commit 804a4486015db9fdce9e8ae90cf3bbc871334b0c
      Ioana Treib . resolved

      Please state what you did in this relant that makes it different from the CL that was reverted.

      Viktor Semeniuk

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Fiorella Barrientos Villalta
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ia0f015b972772faa16e8c2d9693c3b773b611358
        Gerrit-Change-Number: 7685476
        Gerrit-PatchSet: 5
        Gerrit-Owner: Fiorella Barrientos Villalta <fior...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Ioana Treib <ioa...@chromium.org>
        Gerrit-Reviewer: Kevin McNee <mc...@chromium.org>
        Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
        Gerrit-Attention: Fiorella Barrientos Villalta <fior...@google.com>
        Gerrit-Comment-Date: Tue, 24 Mar 2026 17:14:37 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Kevin McNee <mc...@chromium.org>
        Comment-In-Reply-To: Viktor Semeniuk <vsem...@google.com>
        Comment-In-Reply-To: Ioana Treib <ioa...@chromium.org>
        satisfied_requirement
        open
        diffy

        Viktor Semeniuk (Gerrit)

        unread,
        1:14 PM (9 hours ago) 1:14 PM
        to Fiorella Barrientos Villalta, Ioana Treib, Kevin McNee, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, mfoltz+wa...@chromium.org
        Attention needed from Fiorella Barrientos Villalta

        Viktor Semeniuk voted Commit-Queue+2

        Commit-Queue+2
        Gerrit-Comment-Date: Tue, 24 Mar 2026 17:14:42 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages