[ios] Fix an issue with the toolbar buttons on rotation [chromium/src : main]
0 views
Skip to first unread message
Scott Yoder (Gerrit)
11:38 AM (5 hours ago) 11:38 AM
to Eric Ekey, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Eric Ekey
Scott Yoder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Eric Ekey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Ekey (Gerrit)
1:30 PM (3 hours ago) 1:30 PM
to Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Eric Ekey voted and added 2 comments![]( "Open in Gerrit")
Votes added by Eric Ekey
| Code-Review | +1 |
2 comments
Patchset-level comments
Eric Ekey . resolved
LGTM
File ios/chrome/browser/toolbar/ui/toolbar_view_controller.mm
Line 381, Patchset 3 (Latest):
- (void)viewWillTransitionToSize:(CGSize)size
withTransitionCoordinator:
(id<UIViewControllerTransitionCoordinator>)coordinator {Eric Ekey . unresolved
```suggestion
#pragma mark - UIContentContainer
- (void)viewWillTransitionToSize:(CGSize)size
withTransitionCoordinator:
(id<UIViewControllerTransitionCoordinator>)coordinator {
```
Related details
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
1:38 PM (3 hours ago) 1:38 PM
to Eric Ekey, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Scott Yoder voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Yoder
| Commit-Queue | +2 |
- (void)viewWillTransitionToSize:(CGSize)size
withTransitionCoordinator:
(id<UIViewControllerTransitionCoordinator>)coordinator {Eric Ekey . resolved
```suggestion
#pragma mark - UIContentContainer- (void)viewWillTransitionToSize:(CGSize)size
withTransitionCoordinator:
(id<UIViewControllerTransitionCoordinator>)coordinator {
```
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:38 PM (1 hour ago) 3:38 PM
to Scott Yoder, Eric Ekey, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/toolbar/ui/toolbar_view_controller.mm
Insertions: 1, Deletions: 0.
@@ -378,6 +378,7 @@
_bannerPromoBackgroundHeightConstraint.constant = [self
bannerPromoBackgroundHeightForFullscreenProgress:_fullscreenProgress];
}
+#pragma mark - UIContentContainer
- (void)viewWillTransitionToSize:(CGSize)size
withTransitionCoordinator:
```
Change information
Commit message:
[ios] Fix an issue with the toolbar buttons on rotation
This change fixes an issue when the user scrolls to enter fullscreen and
then rotates to landscape. Because some buttons appear only in
landscape, those buttons hidden property is changed which also sets the
alpha which causes them to appear even when the rest of the toolbar is
in fullscreen.
Example of issue:
https://screenshot.googleplex.com/B9U7pACxiipJWjq.png
Change-Id: I6f7f3eee3b68ad7b8d9cb53abb6dfa6aaec7c618
Reviewed-by: Eric Ekey <eric...@google.com>
Commit-Queue: Scott Yoder <scott...@google.com>
Cr-Commit-Position: refs/heads/main@{#1637879}
Files:
- M ios/chrome/browser/toolbar/ui/toolbar_view_controller.mm
Change size: S
Delta: 1 file changed, 15 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eric Ekey
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages