[mac] Guard async menu callbacks against browser shutdown race [chromium/src : main]

0 views

Skip to first unread message

Yuanjun Zhu (Gerrit)

unread,

May 8, 2026, 9:26:38 PM (2 days ago) May 8

to Avi Drissman, Mark Mentovai, Nico Weber, Bryan Oltman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org

Attention needed from Avi Drissman, Bryan Oltman, Mark Mentovai and Nico Weber

Yuanjun Zhu added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Yuanjun Zhu . resolved

Hi @a...@chromium.org, @bryan...@google.com, @tha...@chromium.org, @bryan...@google.com,

Please help take a look this CL. The issue was found by a Monkey (ad-hoc UI automation test) in Edge mac. And the browser test in this CL can repro this issue with similar CHECK call frame.
`CreateBrowser` cannot handle a nullptr profile, so wrap the binding with a null-checking lambda.

Thanks in advance.

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Bryan Oltman
Mark Mentovai
Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

May 9, 2026, 8:40:49 PM (16 hours ago) May 9

to Yuanjun Zhu, Avi Drissman, Mark Mentovai, Nico Weber, Bryan Oltman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org

Attention needed from Bryan Oltman, Mark Mentovai, Nico Weber and Yuanjun Zhu

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Avi Drissman . resolved

Oooh, this looks great, thanks! Your monkey tool seems intriguing.