[mac] Guard async menu callbacks against browser shutdown race [chromium/src : main]

0 views
Skip to first unread message

Yuanjun Zhu (Gerrit)

unread,
May 8, 2026, 9:26:38 PM (2 days ago) May 8
to Avi Drissman, Mark Mentovai, Nico Weber, Bryan Oltman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Avi Drissman, Bryan Oltman, Mark Mentovai and Nico Weber

Yuanjun Zhu added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yuanjun Zhu . resolved

Hi @a...@chromium.org, @bryan...@google.com, @tha...@chromium.org, @bryan...@google.com,

Please help take a look this CL. The issue was found by a Monkey (ad-hoc UI automation test) in Edge mac. And the browser test in this CL can repro this issue with similar CHECK call frame.
`CreateBrowser` cannot handle a nullptr profile, so wrap the binding with a null-checking lambda.

Thanks in advance.

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Bryan Oltman
  • Mark Mentovai
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fa44f1318e92dc088b72f21c0dbc39229da161e
Gerrit-Change-Number: 7831746
Gerrit-PatchSet: 1
Gerrit-Owner: Yuanjun Zhu <yuanj...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Bryan Oltman <bryan...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Yuanjun Zhu <yuanj...@microsoft.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Attention: Bryan Oltman <bryan...@google.com>
Gerrit-Comment-Date: Sat, 09 May 2026 01:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
May 9, 2026, 8:40:49 PM (16 hours ago) May 9
to Yuanjun Zhu, Avi Drissman, Mark Mentovai, Nico Weber, Bryan Oltman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Bryan Oltman, Mark Mentovai, Nico Weber and Yuanjun Zhu

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Code-Review+1

1 comment

Patchset-level comments
Avi Drissman . resolved

Oooh, this looks great, thanks! Your monkey tool seems intriguing.

Open in Gerrit

Related details

Attention is currently required from:
  • Bryan Oltman
  • Mark Mentovai
  • Nico Weber
  • Yuanjun Zhu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fa44f1318e92dc088b72f21c0dbc39229da161e
Gerrit-Change-Number: 7831746
Gerrit-PatchSet: 1
Gerrit-Owner: Yuanjun Zhu <yuanj...@microsoft.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Bryan Oltman <bryan...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Yuanjun Zhu <yuanj...@microsoft.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Bryan Oltman <bryan...@google.com>
Gerrit-Attention: Yuanjun Zhu <yuanj...@microsoft.com>
Gerrit-Comment-Date: Sun, 10 May 2026 00:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages