Declare Element.requestPointerLock() as returning a Promise [chromium/src : main]

0 views
Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,
Sep 10, 2024, 11:38:24 PM9/10/24
to Nate Chapin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Nate Chapin

Andrey Kosyakov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I703ab81d012fe4967c61c7a2e9f0b3949e88b637
Gerrit-Change-Number: 5852277
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Sep 2024 23:38:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Sep 11, 2024, 4:43:38 PM9/11/24
to Andrey Kosyakov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Andrey Kosyakov

Nate Chapin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I703ab81d012fe4967c61c7a2e9f0b3949e88b637
Gerrit-Change-Number: 5852277
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Sep 2024 16:43:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Sep 11, 2024, 4:59:09 PM9/11/24
to Nate Chapin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Andrey Kosyakov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I703ab81d012fe4967c61c7a2e9f0b3949e88b637
Gerrit-Change-Number: 5852277
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Sep 2024 16:58:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 11, 2024, 5:03:27 PM9/11/24
to Andrey Kosyakov, Nate Chapin, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Declare Element.requestPointerLock() as returning a Promise

It already does, just make it official now. This also makes it
match the spec: https://w3c.github.io/pointerlock/#requestPointerLock

As a drive by, fix a typo in exception message.
Change-Id: I703ab81d012fe4967c61c7a2e9f0b3949e88b637
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354014}
Files:
  • M third_party/blink/renderer/core/dom/element.cc
  • M third_party/blink/renderer/core/dom/element.h
  • M third_party/blink/renderer/core/dom/element.idl
  • D third_party/blink/web_tests/external/wpt/pointerlock/idlharness.window-expected.txt
Change size: S
Delta: 4 files changed, 14 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Chapin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I703ab81d012fe4967c61c7a2e9f0b3949e88b637
Gerrit-Change-Number: 5852277
Gerrit-PatchSet: 3
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages