[aim-drive] - gate add from drive behind pcontext eligibility [chromium/src : main]
0 views
Skip to first unread message
Adam Yao (Gerrit)
Jul 20, 2026, 1:11:07 PM (20 hours ago) Jul 20
to Juliet Lévesque Knighton, Dhruv Kathpalia, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, orinj...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Attention needed from Dhruv Kathpalia and Juliet Lévesque Knighton
Adam Yao voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dhruv Kathpalia
- Juliet Lévesque Knighton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Juliet Lévesque Knighton (Gerrit)
Jul 20, 2026, 1:18:13 PM (20 hours ago) Jul 20
to Adam Yao, Dhruv Kathpalia, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, orinj...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Attention needed from Adam Yao and Dhruv Kathpalia
Juliet Lévesque Knighton voted and added 2 comments![]( "Open in Gerrit")
Votes added by Juliet Lévesque Knighton
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Juliet Lévesque Knighton . resolved
LGTM % nit, great work Adam!!!
File components/contextual_search/footprints/internal/fpop_service_impl.cc
Line 303, Patchset 5 (Latest):
std::move(callback).Run(false, response);Juliet Lévesque Knighton . unresolved
nit: will you please preface this with a comment to help readers understand what its refering to (like you have above) here and below?
Related details
Attention is currently required from:
- Adam Yao
- Dhruv Kathpalia
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dhruv Kathpalia (Gerrit)
Jul 20, 2026, 1:21:25 PM (20 hours ago) Jul 20
to Adam Yao, Juliet Lévesque Knighton, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, orinj...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Attention needed from Adam Yao
Dhruv Kathpalia voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Adam Yao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Yao (Gerrit)
Jul 20, 2026, 1:38:46 PM (20 hours ago) Jul 20
to Dhruv Kathpalia, Juliet Lévesque Knighton, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, orinj...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Adam Yao added 1 comment![]( "Open in Gerrit")
File components/contextual_search/footprints/internal/fpop_service_impl.cc
nit: will you please preface this with a comment to help readers understand what its refering to (like you have above) here and below?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Yao (Gerrit)
Jul 20, 2026, 1:38:49 PM (20 hours ago) Jul 20
to Dhruv Kathpalia, Juliet Lévesque Knighton, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, orinj...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Adam Yao voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 20, 2026, 3:10:15 PM (18 hours ago) Jul 20
to Adam Yao, Dhruv Kathpalia, Juliet Lévesque Knighton, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, orinj...@chromium.org, niharm...@google.com, omnibox-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/contextual_search/footprints/internal/fpop_service_impl.cc
Insertions: 3, Deletions: 3.
@@ -300,18 +300,18 @@
const std::string& response_body) {
footprints::oneplatform::ShouldShowMobileConsentFlowResponse response;
if (!success) {
- std::move(callback).Run(false, response);
+ std::move(callback).Run(/*success=*/false, response);
return;
}
if (!response.ParseFromString(response_body)) {
LOG(ERROR) << "Failed to parse ShouldShowMobileConsentFlowResponse from "
"Footprints OnePlatform.";
- std::move(callback).Run(false, response);
+ std::move(callback).Run(/*success=*/false, response);
return;
}
- std::move(callback).Run(true, response);
+ std::move(callback).Run(/*success=*/true, response);
}
} // namespace contextual_search
```
Change information
Commit message:
[aim-drive] - gate add from drive behind pcontext eligibility
This CL replaces the GetFacs RPC with ShouldShowMobileConsentFlow in
DriveDisclaimerController to determine if a user is eligible to use the
"Add from Drive" feature.
Fixed: b:535717434
Change-Id: I028237dd66658b33de9f2d7d19bd3b6c66fa097d
Reviewed-by: Dhruv Kathpalia <dhruvka...@google.com>
Reviewed-by: Juliet Lévesque Knighton <julietl...@google.com>
Commit-Queue: Adam Yao <ada...@google.com>
Cr-Commit-Position: refs/heads/main@{#1664841}
Files:
- M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc
- M components/contextual_search/footprints/internal/fpop_service_impl.cc
- M components/contextual_search/footprints/internal/fpop_service_impl.h
- M components/contextual_search/footprints/public/drive_disclaimer_controller.cc
- M components/contextual_search/footprints/public/drive_disclaimer_controller.h
- M components/contextual_search/footprints/public/drive_disclaimer_controller_unittest.cc
- M components/contextual_search/footprints/public/fpop_service.h
- M components/contextual_search/footprints/public/proto/footprints_oneplatform.proto
Change size: L
Delta: 8 files changed, 296 insertions(+), 165 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Juliet Lévesque Knighton, +1 by Dhruv Kathpalia
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages