cros/recovery: Refactor RPM device execs to support slices of RPM targets [infra/infra : main]

0 views
Skip to first unread message

Jason Stanko (Gerrit)

unread,
3:21 PM (6 hours ago) 3:21 PM
to chromium...@chromium.org, infra-rev...@chromium.org

Jason Stanko has uploaded the change for review

Commit message

cros/recovery: Refactor RPM device execs to support slices of RPM targets

Refactor device_rpm_power_on, device_rpm_power_off, and device_rpm_power_cycle to iterate over a slice of target RPM outlets retrieved via getRPMTargets.

BUG=b:536041360
Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8

Change diff


Change information

Files:
  • M go/src/infra/cros/recovery/internal/execs/rpm/rpm_execs.go
Change size: M
Delta: 1 file changed, 75 insertions(+), 35 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
Gerrit-Change-Number: 8134526
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Stanko <jst...@google.com>
unsatisfied_requirement
open
diffy

Otabek Kasimov (Gerrit)

unread,
4:51 PM (4 hours ago) 4:51 PM
to Jason Stanko, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Jason Stanko

Otabek Kasimov voted and added 1 comment

Votes added by Otabek Kasimov

Code-Review+1

1 comment

File go/src/infra/cros/recovery/internal/execs/rpm/rpm_execs.go
Line 198, Patchset 4 (Latest):func getRPMTargets(info execs.ExecInfo, deviceType string) ([]*rpmTarget, error) {
Otabek Kasimov . unresolved

please add test for this function.

Open in Gerrit

Related details

Attention is currently required from:
  • Jason Stanko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
Gerrit-Change-Number: 8134526
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Stanko <jst...@google.com>
Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
Gerrit-Attention: Jason Stanko <jst...@google.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 20:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jason Stanko (Gerrit)

unread,
5:29 PM (4 hours ago) 5:29 PM
to Otabek Kasimov, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov

Jason Stanko added 1 comment

File go/src/infra/cros/recovery/internal/execs/rpm/rpm_execs.go
Line 198, Patchset 4:func getRPMTargets(info execs.ExecInfo, deviceType string) ([]*rpmTarget, error) {
Otabek Kasimov . resolved

please add test for this function.

Jason Stanko

Done. Please +1 again, lost due to new file.

Open in Gerrit

Related details

Attention is currently required from:
  • Otabek Kasimov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
Gerrit-Change-Number: 8134526
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Stanko <jst...@google.com>
Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
Gerrit-Attention: Otabek Kasimov <ota...@google.com>
Gerrit-Comment-Date: Wed, 22 Jul 2026 21:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Otabek Kasimov <ota...@google.com>
unsatisfied_requirement
open
diffy

Otabek Kasimov (Gerrit)

unread,
5:51 PM (3 hours ago) 5:51 PM
to Jason Stanko, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Jason Stanko

Otabek Kasimov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jason Stanko
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
    Gerrit-Change-Number: 8134526
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jason Stanko <jst...@google.com>
    Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
    Gerrit-Attention: Jason Stanko <jst...@google.com>
    Gerrit-Comment-Date: Wed, 22 Jul 2026 21:50:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jason Stanko (Gerrit)

    unread,
    7:17 PM (2 hours ago) 7:17 PM
    to Otabek Kasimov, chromium...@chromium.org, infra-rev...@chromium.org

    Jason Stanko voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
    Gerrit-Change-Number: 8134526
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jason Stanko <jst...@google.com>
    Gerrit-Reviewer: Jason Stanko <jst...@google.com>
    Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
    Gerrit-Comment-Date: Wed, 22 Jul 2026 23:17:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    LUCI CQ (Gerrit)

    unread,
    7:33 PM (1 hour ago) 7:33 PM
    to Jason Stanko, Otabek Kasimov, chromium...@chromium.org, infra-rev...@chromium.org

    LUCI CQ submitted the change

    Change information

    Commit message:
    cros/recovery: Refactor RPM device execs to support slices of RPM targets

    Refactor device_rpm_power_on, device_rpm_power_off, and device_rpm_power_cycle to iterate over a slice of target RPM outlets retrieved via getRPMTargets.

    BUG=b:536041360
    Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
    Reviewed-by: Otabek Kasimov <ota...@google.com>
    Commit-Queue: Jason Stanko <jst...@google.com>
    Cr-Commit-Position: refs/heads/main@{#82046}
    Files:
    • M go/src/infra/cros/recovery/internal/execs/rpm/rpm_execs.go
    • A go/src/infra/cros/recovery/internal/execs/rpm/rpm_execs_test.go
    Change size: L
    Delta: 2 files changed, 277 insertions(+), 38 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Otabek Kasimov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: I1b20b7225ce5e13f98c2a68c4acc9c3be7daf6e8
    Gerrit-Change-Number: 8134526
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jason Stanko <jst...@google.com>
    Gerrit-Reviewer: Jason Stanko <jst...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages