Revert "Fix screenshot capture hangs for chrome://feedback on macOS" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 31, 2026, 9:30:21 PM (2 days ago) Jul 31
to Palak Agarwal, Chromium LUCI CQ, Guido Urdaneta, Avi Drissman, Rijubrata Bhaumik, Simon Hangl, chromium...@chromium.org, Andrew Rayskiy
Attention needed from Avi Drissman, Guido Urdaneta and Palak Agarwal

luci-bi...@appspot.gserviceaccount.com has uploaded the change for review

luci-bi...@appspot.gserviceaccount.com would like Palak Agarwal, Chromium LUCI CQ, Guido Urdaneta and Avi Drissman to review this change.

Commit message

Revert "Fix screenshot capture hangs for chrome://feedback on macOS"

This reverts commit 128b98a69aa5562f82198c8cf0a63f10764ddba6.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5083696227942400

Sample build with failed test: https://ci.chromium.org/b/8674733599567833265
Affected test(s):
[://chrome/test\:browser_tests!gtest::ComposeSessionBrowserTest#OpenFeedbackPage](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::ComposeSessionBrowserTest%23OpenFeedbackPage?q=VHash%3A812306a38c719b85)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5083696227942400&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8153540&type=BUG

Original change's description:
> Fix screenshot capture hangs for chrome://feedback on macOS
>
> With the new native SCK picker on Mac, the user needs to manually select
> the screen they want to share in the feedback UI. With this change, we
> now route the request to the new picker flow.
>
> Also:
> - Added a check for request_approved_for_test_ in the picker flow to
> auto-approve requests and prevent interactive UI tests from hanging.
> - Added unit tests verifying feedback UI screenshot requests.
>
> Bug: 536647286, 40286360
> Change-Id: Ib5ea9aa16c17231a4c4371d27e7fdba8e75ea6a7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8153540
> Reviewed-by: Avi Drissman <a...@chromium.org>
> Reviewed-by: Guido Urdaneta <gui...@chromium.org>
> Commit-Queue: Palak Agarwal <agp...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1671961}
>
Bug: 536647286, 40286360
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I497f7ec83e512d0b51a9596add8180a36a1952f5

Change diff


Change information

Files:
  • M chrome/browser/media/webrtc/desktop_capture_access_handler.cc
  • M chrome/browser/media/webrtc/desktop_capture_access_handler.h
  • M chrome/browser/media/webrtc/desktop_capture_access_handler_unittest.cc
  • M chrome/browser/ui/autofill/autofill_context_menu_manager_interactive_uitest.cc
  • M chrome/browser/ui/webui/side_panel/customize_chrome/wallpaper_search/wallpaper_search_interactive_uitest.cc
Change size: M
Delta: 5 files changed, 7 insertions(+), 127 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Guido Urdaneta
  • Palak Agarwal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I497f7ec83e512d0b51a9596add8180a36a1952f5
Gerrit-Change-Number: 8178319
Gerrit-PatchSet: 1
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 31, 2026, 9:30:53 PM (2 days ago) Jul 31
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Palak Agarwal, Chromium LUCI CQ, Guido Urdaneta, Avi Drissman, Rijubrata Bhaumik, Simon Hangl, chromium...@chromium.org, Andrew Rayskiy, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Avi Drissman, Guido Urdaneta and Palak Agarwal

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Guido Urdaneta
  • Palak Agarwal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I497f7ec83e512d0b51a9596add8180a36a1952f5
Gerrit-Change-Number: 8178319
Gerrit-PatchSet: 1
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Sat, 01 Aug 2026 01:30:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 31, 2026, 9:31:25 PM (2 days ago) Jul 31
to luci-bi...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Palak Agarwal, Chromium LUCI CQ, Guido Urdaneta, Avi Drissman, Rijubrata Bhaumik, Simon Hangl, chromium...@chromium.org, Andrew Rayskiy, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Avi Drissman, Guido Urdaneta and Palak Agarwal

Related details

Attention is currently required from:
  • Avi Drissman
  • Guido Urdaneta
  • Palak Agarwal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I497f7ec83e512d0b51a9596add8180a36a1952f5
    Gerrit-Change-Number: 8178319
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Sat, 01 Aug 2026 01:31:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Aug 1, 2026, 8:46:35 PM (11 hours ago) Aug 1
    to luci-bi...@appspot.gserviceaccount.com, Avi Drissman, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Palak Agarwal, Chromium LUCI CQ, Guido Urdaneta, Rijubrata Bhaumik, Simon Hangl, chromium...@chromium.org, Andrew Rayskiy, chfreme...@chromium.org, feature-me...@chromium.org
    Attention needed from Guido Urdaneta and Palak Agarwal

    Avi Drissman voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Guido Urdaneta
    • Palak Agarwal
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I497f7ec83e512d0b51a9596add8180a36a1952f5
    Gerrit-Change-Number: 8178319
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Comment-Date: Sun, 02 Aug 2026 00:46:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Aug 1, 2026, 8:46:43 PM (11 hours ago) Aug 1
    to luci-bi...@appspot.gserviceaccount.com, Avi Drissman, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Palak Agarwal, Chromium LUCI CQ, Guido Urdaneta, Rijubrata Bhaumik, Simon Hangl, chromium...@chromium.org, Andrew Rayskiy, chfreme...@chromium.org, feature-me...@chromium.org
    Attention needed from Guido Urdaneta and Palak Agarwal

    Avi Drissman voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Sun, 02 Aug 2026 00:46:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 1, 2026, 8:47:16 PM (11 hours ago) Aug 1
    to luci-bi...@appspot.gserviceaccount.com, Avi Drissman, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Palak Agarwal, Guido Urdaneta, Rijubrata Bhaumik, Simon Hangl, chromium...@chromium.org, Andrew Rayskiy, chfreme...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Reviewed-by: Avi Drissman <a...@chromium.org>
    Commit-Queue: Avi Drissman <a...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1672330}
    Files:
    • M chrome/browser/media/webrtc/desktop_capture_access_handler.cc
    • M chrome/browser/media/webrtc/desktop_capture_access_handler.h
    • M chrome/browser/media/webrtc/desktop_capture_access_handler_unittest.cc
    • M chrome/browser/ui/autofill/autofill_context_menu_manager_interactive_uitest.cc
    • M chrome/browser/ui/webui/side_panel/customize_chrome/wallpaper_search/wallpaper_search_interactive_uitest.cc
    Change size: M
    Delta: 5 files changed, 7 insertions(+), 127 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I497f7ec83e512d0b51a9596add8180a36a1952f5
    Gerrit-Change-Number: 8178319
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages