cft/bols_satlab: Modularize BOLS server handlers into domain services [infra/infra : main]
0 views
Skip to first unread message
Otabek Kasimov (Gerrit)
6:43 PM (2 hours ago) 6:43 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Modularize BOLS server handlers into domain services
Split the monolithic service.go in bols_satlab into domain-specific files
(file_service.go, servod_service.go, cmd_service.go, and common.go) to
prepare for sharing with lib/bols.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I90229e2279c114241754c659a54ceab650ab6b35
Change diff
Change information
Files:
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/cmd_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/common.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/file_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_service.go
Change size: XL
Delta: 5 files changed, 1472 insertions(+), 1509 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:04 PM (2 hours ago) 7:04 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Modularize BOLS server handlers into domain services
Split the monolithic service.go in bols_satlab into domain-specific files
(file_service.go, servod_lifecycle_service.go, servod_control_service.go,
dolos_service.go, cmd_service.go, and common.go) to prepare for sharing with lib/bols.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I49450ce670e1aa30e30797718e1c726782fb13a3
Change diff
Change information
Files:
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/cmd_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/common.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/file_service.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_control_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_lifecycle_service.go
Change size: XL
Delta: 7 files changed, 1497 insertions(+), 1509 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:11 PM (2 hours ago) 7:11 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Modularize BOLS server handlers into domain services
Split monolithic service.go and common.go in bols_satlab into domain-specific files
(file_service.go, servod_lifecycle_service.go, servod_control_service.go,
dolos_service.go, cmd_service.go, ip_cache.go, local_dev.go, container_utils.go,
tar_utils.go, logger.go, util.go) to prepare for sharing with lib/bols.
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I2ac5f9234945febffd42e20863bf39ea8e47c9c8
Change diff
Change information
Files:
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/cmd_service.go
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/common.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/container_utils.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/file_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/ip_cache.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/local_dev.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/logger.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_control_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_lifecycle_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/tar_utils.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/util.go
Change size: XL
Delta: 13 files changed, 1623 insertions(+), 1580 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:23 PM (2 hours ago) 7:23 PM
to chromium...@chromium.org, infra-rev...@chromium.org
Otabek Kasimov has uploaded the change for review![]( "Open in Gerrit")
Commit message
cft/bols_satlab: Modularize BOLS server handlers into domain services
Split servod_service.go and common.go into modular domain service files:
- servod_lifecycle_service.go (StartServod, StopServod, StartEmptyContainer, GetServodStatus)
- servod_control_service.go (HWInitServod, DocServod, GetServod, SetServod, etc.)
- dolos_service.go (Dolos RPC stubs)
- file_service.go (File and directory gRPC RPCs)
- cmd_service.go (DMesg, RunMount, RunUMount, RunFutility, etc.)
- ip_cache.go (ipCacheManager struct)
- local_dev.go (localDevOptions struct)
- container_utils.go (Container execution helpers)
- tar_utils.go (Tar and stat parsing helpers)
- logger.go (Log creation and logger methods)
- util.go (Env and time helpers)
BUG=b:535648254
TAG=agy
CONV=36a8a6f6-1fca-4066-b3ab-db52fba1ecdc
Change-Id: I06196a2ff18d06632f398e594a938a7aee5a054f
Change diff
Change information
Files:
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/cmd_service.go
- D go/src/infra/cros/cmd/cft/bols_satlab/internal/server/common.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/container_utils.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/dolos_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/file_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/ip_cache.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/local_dev.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/logger.go
- M go/src/infra/cros/cmd/cft/bols_satlab/internal/server/service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_control_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_lifecycle_service.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/tar_utils.go
- A go/src/infra/cros/cmd/cft/bols_satlab/internal/server/util.go
Change size: XL
Delta: 13 files changed, 1588 insertions(+), 1582 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:45 PM (1 hour ago) 7:45 PM
to See Wai Fu, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from See Wai Fu
Otabek Kasimov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Otabek Kasimov
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Otabek Kasimov . resolved
I have focused on splitting the handlers into domain services first to simplify the logic before moving them to a shared location for reuse in bols_linux. Please review these structural changes.
Related details
Attention is currently required from:
- See Wai Fu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Otabek Kasimov (Gerrit)
7:51 PM (1 hour ago) 7:51 PM
to LUCI CQ, See Wai Fu, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from See Wai Fu
Otabek Kasimov voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- See Wai Fu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
See Wai Fu (Gerrit)
7:59 PM (1 hour ago) 7:59 PM
to Otabek Kasimov, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov
See Wai Fu voted and added 1 comment![]( "Open in Gerrit")
Votes added by See Wai Fu
| Code-Review | -1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
See Wai Fu . unresolved
It is a big change, and there is no testing information in the commit message. Please create a new container and deploy it to a Satlab to test it out. Then, update the commit message. You should use bols_satlab to test it.
Related details
Attention is currently required from:
- Otabek Kasimov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
See Wai Fu (Gerrit)
8:10 PM (1 hour ago) 8:10 PM
to Otabek Kasimov, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov
See Wai Fu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
See Wai Fu . unresolved
It is a big change, and there is no testing information in the commit message. Please create a new container and deploy it to a Satlab to test it out. Then, update the commit message. You should use bols_satlab to test it.
See Wai Fu
Sorry, I meant that we should bols_testing to test
Related details
Attention is currently required from:
- Otabek Kasimov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
See Wai Fu (Gerrit)
8:30 PM (30 minutes ago) 8:30 PM
to Otabek Kasimov, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov
See Wai Fu voted and added 2 comments![]( "Open in Gerrit")
Votes added by See Wai Fu
| Code-Review | +0 |
2 comments
File go/src/infra/cros/cmd/cft/bols_satlab/internal/server/servod_lifecycle_service.go
Line 186, Patchset 3 (Latest):
servodContainerlLabel = "SERVOD_CONTAINER_LABEL"See Wai Fu . unresolved
Typo. Probably from the original code. Probably we should fix this now.
Line 259, Patchset 3 (Latest):
var _ = stringset.NewSee Wai Fu . unresolved
go.chromium.org/luci/common/data/stringset is unused if we remove this, and I don't remember why we need this in the first place.
Related details
Attention is currently required from:
- Otabek Kasimov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
See Wai Fu (Gerrit)
8:31 PM (29 minutes ago) 8:31 PM
to Otabek Kasimov, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov
See Wai Fu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
See Wai Fu . resolved
See Wai FuIt is a big change, and there is no testing information in the commit message. Please create a new container and deploy it to a Satlab to test it out. Then, update the commit message. You should use bols_satlab to test it.
Sorry, I meant that we should bols_testing to test
See Wai Fu
That's fine. I remember that this code cannot go to Satlab release without manual process. We can delay the testing.
Related details
Attention is currently required from:
- Otabek Kasimov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages