[omnibox] Logs search navigations to debug logs [chromium/src : main]
0 views
Skip to first unread message
Moe Ahmadi (Gerrit)
Feb 5, 2026, 10:53:47 AM (2 days ago) Feb 5
to Sophie Chang, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Sophie Chang
Moe Ahmadi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Jones (Gerrit)
Feb 5, 2026, 10:56:11 AM (2 days ago) Feb 5
to Sophie Chang, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Moe Ahmadi and Sophie Chang
Matthew Jones added 1 comment![]( "Open in Gerrit")
File components/omnibox/browser/omnibox_metrics_provider.cc
Line 279, Patchset 1:
if (base::FeatureList::IsEnabled(omnibox::kOmniboxDebugLogs) && log &&Matthew Jones . unresolved
You don't need this explicitly. Having this check means that you still won't see anything if you have the log page open. The flag is only needed if you're trying to log before the page is opened.
Related details
Attention is currently required from:
- Moe Ahmadi
- Sophie Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Feb 5, 2026, 10:56:17 AM (2 days ago) Feb 5
to Matthew Jones, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Moe Ahmadi
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Moe Ahmadi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Jones (Gerrit)
Feb 5, 2026, 10:57:36 AM (2 days ago) Feb 5
to Sophie Chang, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Attention needed from Moe Ahmadi
Matthew Jones voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthew Jones
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Moe Ahmadi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Ahmadi (Gerrit)
Feb 5, 2026, 11:11:13 AM (2 days ago) Feb 5
to Matthew Jones, Sophie Chang, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Moe Ahmadi added 1 comment![]( "Open in Gerrit")
File components/omnibox/browser/omnibox_metrics_provider.cc
Line 279, Patchset 1:
if (base::FeatureList::IsEnabled(omnibox::kOmniboxDebugLogs) && log &&Matthew Jones . resolved
You don't need this explicitly. Having this check means that you still won't see anything if you have the log page open. The flag is only needed if you're trying to log before the page is opened.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Ahmadi (Gerrit)
10:52 AM (2 hours ago) 10:52 AM
to Matthew Jones, Sophie Chang, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Moe Ahmadi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Moe Ahmadi
| Commit-Queue | +2 |
Holding off until crrev.com/c/7505016 lands.
Moe Ahmadi
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:23 PM (21 minutes ago) 12:23 PM
to Matthew Jones, Sophie Chang, Matt Jones, Nihar Majmudar, Duncan Mercer, chromium...@chromium.org, christia...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/omnibox/browser/omnibox_metrics_provider.cc
Insertions: 2, Deletions: 5.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[omnibox] Logs search navigations to debug logs
http://screen/94e3qEdaxpxBgMh
Bug: b:477608864
Change-Id: I864cfb3f4d464a110f31a82101c3710f6c63b706
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Reviewed-by: Matthew Jones <mdj...@chromium.org>
Commit-Queue: Moe Ahmadi <mah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581355}
Files:
- M components/omnibox/browser/omnibox_metrics_provider.cc
- M components/omnibox/browser/omnibox_metrics_provider.h
Change size: S
Delta: 2 files changed, 27 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sophie Chang, +1 by Matthew Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages