[PDF] Refactor PDFiumEngine::SearchUsingICU() [chromium/src : main]
0 views
Skip to first unread message
Andy Phan (Gerrit)
Jan 9, 2026, 2:59:22 PMJan 9
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org
Attention needed from Lei Zhang
Andy Phan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jan 9, 2026, 3:03:48 PMJan 9
to Lei Zhang, Andy Phan, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 3:07:21 PMJan 9
to Lei Zhang, Andy Phan, chromium...@chromium.org, pdf-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[PDF] Refactor PDFiumEngine::SearchUsingICU()
- Split a chunk of code off as GetAdjustedPageTextData().
- Add local variables for repeatedly used values.
Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567122}
Files:
- M pdf/pdfium/pdfium_engine.cc
Change size: M
Delta: 1 file changed, 89 insertions(+), 72 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jan 13, 2026, 12:55:03 PMJan 13
to Lei Zhang, Chromium LUCI CQ, Andy Phan, chromium...@chromium.org, pdf-r...@chromium.org
Lei Zhang added 1 comment![]( "Open in Gerrit")
File pdf/pdfium/pdfium_engine.cc
Line 2420, Patchset 2 (Latest):
int start = FPDFText_GetTextIndexFromCharIndex(text_page, temp_start);Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Jan 13, 2026, 2:49:16 PMJan 13
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org
Andy Phan added 1 comment![]( "Open in Gerrit")
File pdf/pdfium/pdfium_engine.cc
Line 2420, Patchset 2 (Latest):
int start = FPDFText_GetTextIndexFromCharIndex(text_page, temp_start);Andy Phan
Sorry for not catching this!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages