[PDF] Refactor PDFiumEngine::SearchUsingICU() [chromium/src : main]

0 views
Skip to first unread message

Andy Phan (Gerrit)

unread,
Jan 9, 2026, 2:59:22 PMJan 9
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org
Attention needed from Lei Zhang

Andy Phan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Gerrit-Change-Number: 7419998
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 19:59:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jan 9, 2026, 3:03:48 PMJan 9
to Lei Zhang, Andy Phan, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Gerrit-Change-Number: 7419998
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 20:03:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 9, 2026, 3:07:21 PMJan 9
to Lei Zhang, Andy Phan, chromium...@chromium.org, pdf-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[PDF] Refactor PDFiumEngine::SearchUsingICU()

- Split a chunk of code off as GetAdjustedPageTextData().
- Add local variables for repeatedly used values.
Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567122}
Files:
  • M pdf/pdfium/pdfium_engine.cc
Change size: M
Delta: 1 file changed, 89 insertions(+), 72 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andy Phan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Gerrit-Change-Number: 7419998
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement

Lei Zhang (Gerrit)

unread,
Jan 13, 2026, 12:55:03 PMJan 13
to Lei Zhang, Chromium LUCI CQ, Andy Phan, chromium...@chromium.org, pdf-r...@chromium.org

Lei Zhang added 1 comment

File pdf/pdfium/pdfium_engine.cc
Line 2420, Patchset 2 (Latest): int start = FPDFText_GetTextIndexFromCharIndex(text_page, temp_start);
Lei Zhang . resolved

Whoops! Fixing this error in https://crrev.com/c/7454813.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Gerrit-Change-Number: 7419998
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 17:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Andy Phan (Gerrit)

unread,
Jan 13, 2026, 2:49:16 PMJan 13
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, pdf-r...@chromium.org

Andy Phan added 1 comment

File pdf/pdfium/pdfium_engine.cc
Line 2420, Patchset 2 (Latest): int start = FPDFText_GetTextIndexFromCharIndex(text_page, temp_start);
Lei Zhang . resolved

Whoops! Fixing this error in https://crrev.com/c/7454813.

Andy Phan

Sorry for not catching this!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc7927df9e35d1c599a041e8c5dc89e83336e054
Gerrit-Change-Number: 7419998
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages