Extend startup hard fault metrics to macOS and Linux [chromium/src : main]
0 views
Skip to first unread message
Alex Attar (Gerrit)
Jul 6, 2026, 11:52:05 AM (2 days ago) Jul 6
to Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Olivier Li
Alex Attar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Olivier Li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Li (Gerrit)
Jul 6, 2026, 2:20:43 PM (2 days ago) Jul 6
to Alex Attar, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Alex Attar
Olivier Li added 1 comment![]( "Open in Gerrit")
File components/startup_metric_utils/browser/startup_metric_utils.cc
Line 288, Patchset 7 (Latest):
task_info(mach_task_self(), TASK_EVENTS_INFO,Olivier Li . unresolved
I'm having a bit of a hard time figuring out a good source to understand what `TASK_EVENTS_INFO` means. Is there are link you could add in comment?
Related details
Attention is currently required from:
- Alex Attar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
Jul 7, 2026, 10:32:20 AM (yesterday) Jul 7
to Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Olivier Li
Alex Attar added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File components/startup_metric_utils/browser/startup_metric_utils.cc
I'm having a bit of a hard time figuring out a good source to understand what `TASK_EVENTS_INFO` means. Is there are link you could add in comment?
Attention is currently required from:
- Olivier Li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
Jul 7, 2026, 2:26:43 PM (yesterday) Jul 7
to Sean Maher, Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Olivier Li and Sean Maher
Alex Attar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Olivier Li
- Sean Maher
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Li (Gerrit)
Jul 7, 2026, 2:46:44 PM (yesterday) Jul 7
to Alex Attar, Sean Maher, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Alex Attar and Sean Maher
Olivier Li voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Attar
- Sean Maher
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Maher (Gerrit)
Jul 7, 2026, 2:49:57 PM (yesterday) Jul 7
to Alex Attar, Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Alex Attar
Sean Maher voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sean Maher
| Code-Review | +1 |
1 comment
File tools/metrics/histograms/metadata/startup/histograms.xml
Line 787, Patchset 8 (Latest):
(pageins); on Linux from getrusage (ru_majflt). Absolute values are not
directly comparable across platforms.Sean Maher . unresolved
I would add perhaps that these may not be comparable even between OS versions (though of course we would hope they may be), but for example, `Startup.LoadTime*ProcessCreat*ToApplicationStart*` vary widely because the OS changes how it itself starts and times the startup of applications.
Related details
Attention is currently required from:
- Alex Attar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
Jul 7, 2026, 3:15:02 PM (yesterday) Jul 7
to Eshwar Stalin, Sean Maher, Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Eshwar Stalin
Alex Attar added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Alex Attar . resolved
+@estalin for chrome/browser/metrics/startup_metrics_browsertest.cc review.
PTAL,
Thanks
File tools/metrics/histograms/metadata/startup/histograms.xml
Line 787, Patchset 8:
(pageins); on Linux from getrusage (ru_majflt). Absolute values are not
directly comparable across platforms.Sean Maher . resolved
I would add perhaps that these may not be comparable even between OS versions (though of course we would hope they may be), but for example, `Startup.LoadTime*ProcessCreat*ToApplicationStart*` vary widely because the OS changes how it itself starts and times the startup of applications.
Attention is currently required from:
- Eshwar Stalin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
2:10 PM (4 hours ago) 2:10 PM
to Dana Fried, Sean Maher, Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Dana Fried
Alex Attar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alex Attar . resolved
+@dfried for chrome/browser/metrics/startup_metrics_browsertest.cc review.
PTAL,
Thanks
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
3:57 PM (2 hours ago) 3:57 PM
to Alex Attar, Sean Maher, Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Attention needed from Alex Attar
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Attar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Attar (Gerrit)
4:08 PM (2 hours ago) 4:08 PM
to Dana Fried, Sean Maher, Olivier Li, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, chromiumme...@microsoft.com
Alex Attar voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages