[Blink] Eliminate WebGpuMailboxTexture call of ProduceCanvasResource() [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Jul 7, 2026, 11:11:35 AM (17 hours ago) Jul 7
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/platform/graphics/gpu/webgpu_mailbox_texture.cc
Line 123, Patchset 10 (Latest):
resource_provider->EndWriteAccess();Vasiliy Telezhnikov . resolved
(not in this CL): We can just remove EndWriteAccess / EnsureWriteAccess, it doesn't do anything useful here. It's only for this [DCHECK](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4;l=456), which has questionable utility now that CSI tracks access.
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
2:40 AM (2 hours ago) 2:40 AM
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Colin Blundell added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/graphics/gpu/webgpu_mailbox_texture.cc
Line 123, Patchset 10 (Latest):
resource_provider->EndWriteAccess();Vasiliy Telezhnikov . resolved
(not in this CL): We can just remove EndWriteAccess / EnsureWriteAccess, it doesn't do anything useful here. It's only for this [DCHECK](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4;l=456), which has questionable utility now that CSI tracks access.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:01 AM (1 hour ago) 3:01 AM
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Blink] Eliminate WebGpuMailboxTexture call of ProduceCanvasResource()
Effectively inlines the method body [1] at the callsite. Step toward
elimination of this method existing on WebGpuRecyclableResourceProvider.
Note that EndWriteAccess() is a no-op if the GPU context is lost [2].
Note also that CanvasResourceSharedImage::GetSharedImage() is guaranteed
to be non-null if the resource is non-null, as it is non-null on
construction [3] and is never subsequently modified [4].
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;l=548-561;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc;l=307-309;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4;bpv=1;bpt=1
[3] https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/client/shared_image_pool.cc;l=31;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4
[4] https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/client/shared_image_pool.h;l=126;drc=458a490c2544e4ea08bb9457d8fe8f5c65af07c4;bpv=1;bpt=1
Bug: 352263194
Change-Id: I88f365f909522696d233749e0a73110a40fccdf6
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658536}
Files:
- M third_party/blink/renderer/platform/graphics/gpu/webgpu_mailbox_texture.cc
- M third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.cc
- M third_party/blink/renderer/platform/graphics/gpu/webgpu_recyclable_resource_provider.h
Change size: S
Delta: 3 files changed, 26 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages