[google_apis] Use factory method to create GoogleServiceAuthError [chromium/src : main]
0 views
Skip to first unread message
Colin Blundell (Gerrit)
Mar 5, 2026, 8:21:59 AMMar 5
to Tanmoy Mollik, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 5, 2026, 11:28:41 AMMar 5
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 5, 2026, 12:05:17 PMMar 5
to Tanmoy Mollik, Colin Blundell, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I89962ffd445ffff6e55f9b59e1e9d655e11890bf
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1594739}
Files:
- M ash/webui/projector_app/projector_oauth_token_fetcher.cc
- M ash/webui/projector_app/test/projector_xhr_sender_unittest.cc
Change size: S
Delta: 2 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Mar 10, 2026, 8:54:24 AMMar 10
to Tanmoy Mollik, Alex Ilin, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, net-r...@chromium.org, devtools...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Tanmoy Mollik
Alex Ilin voted and added 5 comments![]( "Open in Gerrit")
Votes added by Alex Ilin
| Code-Review | +1 |
5 comments
Patchset-level comments
File chrome/browser/ash/login/signin/signin_error_notifier_unittest.cc
Line 228, Patchset 7 (Latest):
std::array<GoogleServiceAuthError, 10> errors = {Alex Ilin . unresolved
nit: it's better to avoid hardcoding the size of statically defined arrays:
```suggestion
auto errors = std::to_array<GoogleServiceAuthError>({
```
File google_apis/gaia/google_service_auth_error.h
Line 198, Patchset 7 (Latest):
// Construct a REQUEST_CANCELEDACCOUNT_NOT_FOUND error.Alex Ilin . unresolved
nit: Something went wrong here:
```suggestion
// Construct a REQUEST_CANCELED error.
```
Line 196, Patchset 7 (Latest):
static GoogleServiceAuthError AuthErrorAccountNotFound();Alex Ilin . unresolved
optional naming bikeshed: this naming scheme is consistent with `AuthErrorNone()` but I'm not sure this is the best option
`GoogleServiceAuthError::AuthErrorAccountNotFound()` is a bit too repetitive. How about `GoogleServiceAuthError::CreateAccountNotFound()`?
e.g. for `CreateRequestCanceled()` and `CreateNone()` (can be renamed in the future)
alternatively, we could have `GoogleServiceAuthError::AccountNotFound()`, `GoogleServiceAuthError::RequestCanceled()`, `GoogleServiceAuthError::None()`
Line 195, Patchset 7 (Latest):
// Construct a ACCOUNT_NOT_FOUND error.Alex Ilin . unresolved
nit:
```suggestion
// Construct an ACCOUNT_NOT_FOUND error.
```
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 12, 2026, 6:59:45 AMMar 12
to Alex Ilin, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, net-r...@chromium.org, devtools...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Tanmoy Mollik added 4 comments![]( "Open in Gerrit")
File chrome/browser/ash/login/signin/signin_error_notifier_unittest.cc
nit: it's better to avoid hardcoding the size of statically defined arrays:
```suggestion
auto errors = std::to_array<GoogleServiceAuthError>({
```
Tanmoy Mollik
Done
File google_apis/gaia/google_service_auth_error.h
nit: Something went wrong here:
```suggestion
// Construct a REQUEST_CANCELED error.
```
Tanmoy Mollik
Done
optional naming bikeshed: this naming scheme is consistent with `AuthErrorNone()` but I'm not sure this is the best option
`GoogleServiceAuthError::AuthErrorAccountNotFound()` is a bit too repetitive. How about `GoogleServiceAuthError::CreateAccountNotFound()`?
e.g. for `CreateRequestCanceled()` and `CreateNone()` (can be renamed in the future)
alternatively, we could have `GoogleServiceAuthError::AccountNotFound()`, `GoogleServiceAuthError::RequestCanceled()`, `GoogleServiceAuthError::None()`
Tanmoy Mollik
Done
nit:
```suggestion
// Construct an ACCOUNT_NOT_FOUND error.
```
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 12, 2026, 6:59:56 AMMar 12
to Alex Ilin, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, net-r...@chromium.org, devtools...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Mar 12, 2026, 7:01:59 AMMar 12
to Tanmoy Mollik, Alex Ilin, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, net-r...@chromium.org, devtools...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Tanmoy Mollik
Alex Ilin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Ilin
| Code-Review | +1 |
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 12, 2026, 7:53:42 AMMar 12
to Tanmoy Mollik, Alex Ilin, Mirko Bonadei, Jerome Jiang, AyeAye, chromium...@chromium.org, jz...@chromium.org, chrome-intell...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, net-r...@chromium.org, devtools...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I7f54e6b7b5af06f2e56f7b1bd472e594e663b77a
Reviewed-by: Alex Ilin <alex...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1598352}
Files:
- M chrome/browser/ash/login/signin/signin_error_notifier_unittest.cc
- M google_apis/gaia/google_service_auth_error.cc
- M google_apis/gaia/google_service_auth_error.h
Change size: M
Delta: 3 files changed, 55 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Ilin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Artem Sumaneev (Gerrit)
Mar 13, 2026, 6:44:04 AMMar 13
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews
Attention needed from Tanmoy Mollik
Artem Sumaneev voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 13, 2026, 10:45:42 AMMar 13
to Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 13, 2026, 10:48:51 AMMar 13
to Tanmoy Mollik, chromium...@chromium.org, Enterprise Policy Reviews
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I25d504eb46762499bfbcccc28c2c1b77e0e27144
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Artem Sumaneev <asum...@google.com>
Cr-Commit-Position: refs/heads/main@{#1599045}
Files:
- M chrome/browser/ash/policy/core/policy_oauth2_token_fetcher.cc
- M chrome/browser/ash/policy/core/user_cloud_policy_manager_ash.cc
Change size: S
Delta: 2 files changed, 10 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Artem Sumaneev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Artem Sumaneev (Gerrit)
Mar 17, 2026, 10:38:10 AMMar 17
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Artem Sumaneev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Artem Sumaneev
| Code-Review | +1 |
Artem Sumaneev . resolved
LGTM, thanks!
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 17, 2026, 11:02:24 AMMar 17
to Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 17, 2026, 11:04:59 AMMar 17
to Tanmoy Mollik, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I31ee2612bc831ed3dc5863fb2c57a1e117a791a4
Reviewed-by: Artem Sumaneev <asum...@google.com>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1600553}
Files:
- M chrome/browser/device_identity/device_oauth2_token_service.cc
- M chrome/browser/device_identity/device_oauth2_token_service.h
Change size: M
Delta: 2 files changed, 28 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Artem Sumaneev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuheng Huang (Gerrit)
Mar 17, 2026, 1:41:24 PMMar 17
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Tanmoy Mollik
Yuheng Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 18, 2026, 6:08:00 AMMar 18
to Yuheng Huang, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 18, 2026, 6:11:10 AMMar 18
to Tanmoy Mollik, Yuheng Huang, chromium...@chromium.org, Sophie Chang
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I293f054d0f79551b412719a74e96541b68bc016f
Reviewed-by: Yuheng Huang <yuh...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1601146}
Files:
- M chrome/browser/contextual_tasks/contextual_tasks_ui_service_unittest.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuheng Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 18, 2026, 6:57:30 AMMar 18
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Tanmoy Mollik
Liza Bipin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Liza Bipin . resolved
Hey could you please take a look at this cl before I send it out for owner's approval?
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 18, 2026, 7:38:08 AMMar 18
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Liza Bipin
Tanmoy Mollik voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
Mar 18, 2026, 8:20:38 AMMar 18
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Tanmoy Mollik
Yang Guo voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 18, 2026, 8:30:30 AMMar 18
to Florian Leimgruber, Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Florian Leimgruber
Liza Bipin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Liza Bipin . resolved
@fleimgruber Could you ptal at this cl? Thank you :)
Related details
Attention is currently required from:
- Florian Leimgruber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
Mar 18, 2026, 8:31:30 AMMar 18
to Liza Bipin, Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Liza Bipin
Florian Leimgruber voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 18, 2026, 8:32:17 AMMar 18
to Florian Leimgruber, Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Liza Bipin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Liza Bipin
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Liza Bipin . resolved
Thank you both for the fast review!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 18, 2026, 8:35:48 AMMar 18
to Liza Bipin, Florian Leimgruber, Tanmoy Mollik, chromium...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I6a0e5754a0136650ebc2fc215fe2526849ba984d
Reviewed-by: Tanmoy Mollik <triplo...@google.com>
Commit-Queue: Liza Bipin <mlb...@google.com>
Reviewed-by: Florian Leimgruber <fleim...@google.com>
Cr-Commit-Position: refs/heads/main@{#1601197}
Files:
- M components/autofill/core/browser/data_manager/addresses/address_data_manager_unittest.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tanmoy Mollik, +1 by Florian Leimgruber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 18, 2026, 9:48:17 AMMar 18
to Yang Guo, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 18, 2026, 9:51:35 AMMar 18
to Tanmoy Mollik, Yang Guo, chromium...@chromium.org, devtools...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I264e230190438abf11ce5823dd384e9addd15ac7
Reviewed-by: Yang Guo <yan...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1601246}
Files:
- M chrome/browser/devtools/aida_client_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yang Guo
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Mar 18, 2026, 9:59:44 AMMar 18
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Tanmoy Mollik
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 18, 2026, 10:02:15 AMMar 18
to Dana Fried, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 18, 2026, 10:08:04 AMMar 18
to Tanmoy Mollik, Dana Fried, chromium...@chromium.org, dewitt...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Ife7b819f877b4f40fda4aeadf3bb537fa244eac6
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Dana Fried <dfr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1601257}
Files:
- M chrome/browser/glic/test_support/glic_test_util.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dana Fried
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 19, 2026, 7:00:17 AMMar 19
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Liza Bipin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Liza Bipin . resolved
Could you please take a look at this cl too? Thank you!
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 19, 2026, 7:00:39 AMMar 19
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Liza Bipin voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 19, 2026, 8:53:24 AMMar 19
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Tanmoy Mollik added 1 comment![]( "Open in Gerrit")
File chrome/browser/signin/dice_response_handler_unittest.cc
Line 401, Patchset 2 (Latest):
auto expected_error =
GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
GoogleServiceAuthError::InvalidGaiaCredentialsReason::
CREDENTIALS_REJECTED_BY_CLIENT);
EXPECT_EQ(error.state(), expected_error.state());
EXPECT_EQ(error.GetInvalidGaiaCredentialsReason(),
expected_error.GetInvalidGaiaCredentialsReason());Tanmoy Mollik . unresolved
I don't think this part of the code should be changed. We're not creating an error from a state here.
Lines `1014` and `1056` in this file need to be changed as we're creating error there.
Related details
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 19, 2026, 9:26:25 AMMar 19
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Liza Bipin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Liza Bipin
| Auto-Submit | +1 |
1 comment
File chrome/browser/signin/dice_response_handler_unittest.cc
Line 401, Patchset 2:
auto expected_error =
GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
GoogleServiceAuthError::InvalidGaiaCredentialsReason::
CREDENTIALS_REJECTED_BY_CLIENT);
EXPECT_EQ(error.state(), expected_error.state());
EXPECT_EQ(error.GetInvalidGaiaCredentialsReason(),
expected_error.GetInvalidGaiaCredentialsReason());Tanmoy Mollik . resolved
I don't think this part of the code should be changed. We're not creating an error from a state here.
Lines `1014` and `1056` in this file need to be changed as we're creating error there.
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 19, 2026, 11:31:52 AMMar 19
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Tanmoy Mollik added 1 comment![]( "Open in Gerrit")
File chrome/browser/signin/dice_response_handler_unittest.cc
Line 401, Patchset 2:
auto expected_error =
GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
GoogleServiceAuthError::InvalidGaiaCredentialsReason::
CREDENTIALS_REJECTED_BY_CLIENT);
EXPECT_EQ(error.state(), expected_error.state());
EXPECT_EQ(error.GetInvalidGaiaCredentialsReason(),
expected_error.GetInvalidGaiaCredentialsReason());Tanmoy Mollik . unresolved
Liza BipinI don't think this part of the code should be changed. We're not creating an error from a state here.
Lines `1014` and `1056` in this file need to be changed as we're creating error there.
smh yeah not sure how i missed that, Done.
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Mar 20, 2026, 9:45:13 AMMar 20
to Tanmoy Mollik, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tanmoy Mollik
Alex Ilin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 20, 2026, 10:02:35 AMMar 20
to Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Milchior (Gerrit)
Mar 20, 2026, 10:04:10 AMMar 20
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Tanmoy Mollik
Arthur Milchior voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 20, 2026, 10:10:32 AMMar 20
to Arthur Milchior, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 20, 2026, 10:22:09 AMMar 20
to Tanmoy Mollik, Alex Ilin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I1d3d06a635990f435bf4147b4ad3a4fe842f61d0
Reviewed-by: Alex Ilin <alex...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1602569}
Files:
- M chrome/browser/extensions/api/identity/identity_apitest.cc
Change size: S
Delta: 1 file changed, 12 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Ilin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 20, 2026, 10:37:24 AMMar 20
to Tanmoy Mollik, Arthur Milchior, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: If72282d807afe5e934912ebe9b70d94019acccc7
Reviewed-by: Arthur Milchior <arthurm...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1602594}
Files:
- M ios/chrome/browser/signin/model/signin_profile_info_updater_unittest.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Arthur Milchior
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
Mar 20, 2026, 12:37:53 PMMar 20
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Tanmoy Mollik
Gauthier Ambard voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 22, 2026, 7:23:19 AMMar 22
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 22, 2026, 8:26:05 AMMar 22
to Tanmoy Mollik, Gauthier Ambard, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I854527d6a3fba7b2c65b706628e139d8fbdd5154
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1603146}
Files:
- M ios/chrome/browser/webui/ui_bundled/signin_internals_ui_ios.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 23, 2026, 12:38:03 PMMar 23
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Liza Bipin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Liza Bipin
| Auto-Submit | +1 |
1 comment
File chrome/browser/signin/dice_response_handler_unittest.cc
Line 401, Patchset 2:
auto expected_error =
GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
GoogleServiceAuthError::InvalidGaiaCredentialsReason::
CREDENTIALS_REJECTED_BY_CLIENT);
EXPECT_EQ(error.state(), expected_error.state());
EXPECT_EQ(error.GetInvalidGaiaCredentialsReason(),
expected_error.GetInvalidGaiaCredentialsReason());Tanmoy Mollik . resolved
Liza BipinI don't think this part of the code should be changed. We're not creating an error from a state here.
Lines `1014` and `1056` in this file need to be changed as we're creating error there.
Tanmoy Molliksmh yeah not sure how i missed that, Done.
There is another usage left at line 1056
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 24, 2026, 5:19:58 AMMar 24
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Tanmoy Mollik voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tanmoy Mollik
| Code-Review | +1 |
1 comment
File chrome/browser/signin/dice_response_handler_unittest.cc
Line 1056, Patchset 5 (Latest):
GoogleServiceAuthError::FromServiceUnavailable(std::string()));Tanmoy Mollik . unresolved
nit: you can use `""` here.
Related details
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 24, 2026, 6:20:28 AMMar 24
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Liza Bipin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Liza Bipin
| Auto-Submit | +1 |
1 comment
File chrome/browser/signin/dice_response_handler_unittest.cc
Line 1056, Patchset 5:
GoogleServiceAuthError::FromServiceUnavailable(std::string()));Tanmoy Mollik . resolved
nit: you can use `""` here.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 24, 2026, 6:21:15 AMMar 24
to Tanmoy Mollik, Chromium LUCI CQ, chromium...@chromium.org
Liza Bipin voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 24, 2026, 7:04:30 AMMar 24
to Liza Bipin, Tanmoy Mollik, chromium...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/signin/dice_response_handler_unittest.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Ie42ba3734c931c05271d2029b6ce49bf98ec51a3
Reviewed-by: Tanmoy Mollik <triplo...@google.com>
Auto-Submit: Liza Bipin <mlb...@google.com>
Commit-Queue: Liza Bipin <mlb...@google.com>
Cr-Commit-Position: refs/heads/main@{#1604015}
Files:
- M chrome/browser/signin/dice_response_handler.cc
- M chrome/browser/signin/dice_response_handler_unittest.cc
Change size: S
Delta: 2 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tanmoy Mollik
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 24, 2026, 9:27:34 AMMar 24
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Colin Blundell
Liza Bipin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Mar 24, 2026, 9:36:36 AMMar 24
to Tanmoy Mollik, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Alex Ilin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 24, 2026, 9:37:43 AMMar 24
to Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Mar 24, 2026, 10:38:03 AMMar 24
to Liza Bipin, David Roger, Chromium LUCI CQ, chromium...@chromium.org, Colin Blundell
Attention needed from David Roger and Liza Bipin
Colin Blundell added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Colin Blundell . resolved
Thanks! -> droger@
Related details
Attention is currently required from:
- David Roger
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
Mar 24, 2026, 12:07:38 PMMar 24
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
David Roger voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 24, 2026, 12:10:26 PMMar 24
to David Roger, Chromium LUCI CQ, chromium...@chromium.org
Liza Bipin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 24, 2026, 12:10:54 PMMar 24
to Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Juliet Lévesque
Liza Bipin voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Juliet Lévesque
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 24, 2026, 12:13:49 PMMar 24
to Liza Bipin, David Roger, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I02fa74afecc175602f6edcb31cb3e4fdd58c3281
Reviewed-by: David Roger <dro...@chromium.org>
Commit-Queue: Liza Bipin <mlb...@google.com>
Cr-Commit-Position: refs/heads/main@{#1604174}
Files:
- M chrome/browser/save_to_drive/drive_uploader_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Roger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 25, 2026, 7:18:24 AMMar 25
to Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 25, 2026, 8:07:19 AMMar 25
to Tanmoy Mollik, Alex Ilin, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I1471caaa3c1221d8aa828b4a3b2e97cf75a39a1b
Reviewed-by: Alex Ilin <alex...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1604726}
Files:
- M google_apis/gaia/fake_oauth2_access_token_manager.cc
- M google_apis/gaia/gaia_auth_fetcher.cc
- M google_apis/gaia/gaia_auth_fetcher_unittest.cc
- M google_apis/gaia/oauth2_access_token_manager.cc
- M google_apis/gaia/oauth2_access_token_manager_unittest.cc
- M google_apis/gaia/oauth2_mint_token_flow.cc
Change size: M
Delta: 6 files changed, 26 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Ilin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 26, 2026, 5:17:29 AMMar 26
to Juliet Lévesque, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Juliet Lévesque
Liza Bipin added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Juliet Lévesque
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Mar 26, 2026, 6:44:34 AMMar 26
to Tanmoy Mollik, Chromium Sync Reviews, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Marc Treib
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
tr...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)
Related details
Attention is currently required from:
- Marc Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Mar 26, 2026, 7:03:14 AMMar 26
to Tanmoy Mollik, Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Marc Treib voted and added 2 comments![]( "Open in Gerrit")
Votes added by Marc Treib
| Code-Review | +1 |
2 comments
File components/sync/service/device_statistics_request_impl_unittest.cc
Line 101, Patchset 1 (Latest):
GoogleServiceAuthError::FromServiceUnavailable(""));Marc Treib . unresolved
`/*error_message=*/std::string()`
File components/sync/service/sync_service_impl_unittest.cc
Line 661, Patchset 1 (Latest):
GoogleServiceAuthError::InvalidGaiaCredentialsReason::UNKNOWN));Marc Treib . unresolved
optional: I think `CREDENTIALS_REJECTED_BY_CLIENT` would make sense here. Same for the other instances in this file.
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Kingsborough (Gerrit)
Mar 27, 2026, 12:52:13 PMMar 27
to Liza Bipin, Ryan Hansberry, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin and Ryan Hansberry
Alex Kingsborough voted![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
- Ryan Hansberry
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Mar 31, 2026, 4:17:57 AMMar 31
to Alex Kingsborough, Ryan Hansberry, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Ryan Hansberry
Liza Bipin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Ryan Hansberry
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 31, 2026, 5:43:22 AMMar 31
to Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik added 2 comments![]( "Open in Gerrit")
File components/sync/service/device_statistics_request_impl_unittest.cc
Line 101, Patchset 1:
GoogleServiceAuthError::FromServiceUnavailable(""));Marc Treib . resolved
Tanmoy Mollik`/*error_message=*/std::string()`
Done
File components/sync/service/sync_service_impl_unittest.cc
Line 661, Patchset 1:
GoogleServiceAuthError::InvalidGaiaCredentialsReason::UNKNOWN));Marc Treib . resolved
optional: I think `CREDENTIALS_REJECTED_BY_CLIENT` would make sense here. Same for the other instances in this file.
Tanmoy Mollik
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 31, 2026, 5:44:04 AMMar 31
to Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Mar 31, 2026, 6:41:40 AMMar 31
to Marc Treib, Chromium Sync Reviews, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 31, 2026, 6:56:45 AMMar 31
to Tanmoy Mollik, Marc Treib, Chromium Sync Reviews, chromium...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/sync/service/sync_service_impl_unittest.cc
Insertions: 9, Deletions: 5.
The diff is too large to show. Please review the diff.
```
```
The name of the file: components/sync/service/device_statistics_request_impl_unittest.cc
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Ieab087139495ba7497f833095229cbcf741ffb42
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Marc Treib <tr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607765}
Files:
- M components/sync/service/device_statistics_request_impl_unittest.cc
- M components/sync/service/sync_auth_manager_unittest.cc
- M components/sync/service/sync_service_impl_unittest.cc
- M components/sync/service/sync_session_durations_metrics_recorder_unittest.cc
Change size: S
Delta: 4 files changed, 22 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marc Treib
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Mar 31, 2026, 11:50:48 AM (14 days ago) Mar 31
to Tanmoy Mollik, chrome-family...@google.com, Duong Dac, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Duong Dac
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
dd...@google.com is from context(googleclient/chrome/chromium_gwsq/chrome/browser/supervised_user/config.gwsq)
Related details
Attention is currently required from:
- Duong Dac
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Duong Dac (Gerrit)
Apr 1, 2026, 9:30:40 AM (13 days ago) Apr 1
to Tanmoy Mollik, chrome-family...@google.com, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Duong Dac voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Apr 1, 2026, 9:54:52 AM (13 days ago) Apr 1
to Duong Dac, chrome-family...@google.com, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 1, 2026, 10:24:14 AM (13 days ago) Apr 1
to Tanmoy Mollik, Duong Dac, chrome-family...@google.com, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I187a98d4a5a7a0cda6c88ab4d3385b4893010563
Reviewed-by: Duong Dac <dd...@chromium.org>
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1608510}
Files:
- M components/supervised_user/core/browser/proto_fetcher_metrics_unittest.cc
- M components/supervised_user/core/browser/proto_fetcher_status_unittest.cc
Change size: S
Delta: 2 files changed, 8 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Duong Dac
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Hansberry (Gerrit)
Apr 2, 2026, 1:03:03 AM (12 days ago) Apr 2
to Liza Bipin, Alex Kingsborough, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Ryan Hansberry voted![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 2, 2026, 3:51:32 AM (12 days ago) Apr 2
to Ryan Hansberry, Alex Kingsborough, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Ryan Hansberry
Liza Bipin voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Ryan Hansberry
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 3:56:08 AM (12 days ago) Apr 2
to Liza Bipin, Ryan Hansberry, Alex Kingsborough, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I10b012cfcbcf3e086ccbef4079cce5244bf4a92f
Reviewed-by: Alex Kingsborough <aki...@google.com>
Auto-Submit: Liza Bipin <mlb...@google.com>
Commit-Queue: Liza Bipin <mlb...@google.com>
Reviewed-by: Ryan Hansberry <hans...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609012}
Files:
- M chrome/browser/push_notification/server_client/push_notification_server_client_desktop_impl_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ryan Hansberry, +1 by Alex Kingsborough
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 2, 2026, 5:16:54 AM (12 days ago) Apr 2
to Norge Vizcay, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Norge Vizcay
Liza Bipin voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
Apr 2, 2026, 5:20:55 AM (12 days ago) Apr 2
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Norge Vizcay voted![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 5:23:58 AM (12 days ago) Apr 2
to Liza Bipin, Norge Vizcay, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Ib10b68719ce91ec89f5b29842cc8fc0e33955e8b
Auto-Submit: Liza Bipin <mlb...@google.com>
Commit-Queue: Norge Vizcay <viz...@google.com>
Reviewed-by: Norge Vizcay <viz...@google.com>
Cr-Commit-Position: refs/heads/main@{#1609058}
Files:
- M components/wallet/core/browser/network/wallet_http_client_impl_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Norge Vizcay
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 2, 2026, 5:26:22 AM (12 days ago) Apr 2
to thefrog, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from thefrog
Liza Bipin voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- thefrog
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 2, 2026, 5:56:39 AM (12 days ago) Apr 2
to Elie Maamari, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Elie Maamari
Liza Bipin voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Elie Maamari
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
Apr 2, 2026, 7:19:43 AM (12 days ago) Apr 2
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
David Roger voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 2, 2026, 7:20:14 AM (12 days ago) Apr 2
to David Roger, Chromium LUCI CQ, chromium...@chromium.org
Liza Bipin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 7:23:11 AM (12 days ago) Apr 2
to Liza Bipin, David Roger, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Id9dfdfa9e49eace406af677e241527fb4890797b
Reviewed-by: David Roger <dro...@chromium.org>
Commit-Queue: Liza Bipin <mlb...@google.com>
Cr-Commit-Position: refs/heads/main@{#1609096}
Files:
- M chrome/browser/ui/webui/signin_internals_ui.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Roger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 2, 2026, 7:25:20 AM (12 days ago) Apr 2
to Aga Wronska, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com
Attention needed from Aga Wronska
Liza Bipin voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Aga Wronska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
thefrog (Gerrit)
Apr 2, 2026, 8:43:11 AM (12 days ago) Apr 2
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Liza Bipin
thefrog voted![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 8:50:28 AM (12 days ago) Apr 2
to Liza Bipin, thefrog, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I206d4a673377b635c771d9f2fd49dd5810d03a35
Auto-Submit: Liza Bipin <mlb...@google.com>
Reviewed-by: thefrog <the...@chromium.org>
Commit-Queue: thefrog <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609139}
Files:
- M components/safe_browsing/core/browser/sync/safe_browsing_primary_account_token_fetcher_unittest.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by thefrog
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aga Wronska (Gerrit)
Apr 2, 2026, 12:19:42 PM (12 days ago) Apr 2
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org, rrsilva+wat...@google.com
Attention needed from Liza Bipin
Aga Wronska voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aga Wronska
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 12:22:36 PM (12 days ago) Apr 2
to Liza Bipin, Aga Wronska, chromium...@chromium.org, rrsilva+wat...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I6e69f50fc3d3bb3fc5fdc655a5e4f47c868b7256
Auto-Submit: Liza Bipin <mlb...@google.com>
Reviewed-by: Aga Wronska <agawr...@chromium.org>
Commit-Queue: Aga Wronska <agawr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609276}
Files:
- M chrome/browser/ui/webui/ash/edu_coexistence/edu_coexistence_login_handler_browsertest.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Aga Wronska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 7, 2026, 9:26:27 AM (7 days ago) Apr 7
to Elie Maamari, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Elie Maamari
Liza Bipin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Elie Maamari
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Apr 8, 2026, 10:07:02 AM (6 days ago) Apr 8
to Tanmoy Mollik, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Alex Ilin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elie Maamari (Gerrit)
Apr 8, 2026, 10:23:06 AM (6 days ago) Apr 8
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Elie Maamari voted![]( "Open in Gerrit")
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 8, 2026, 10:54:47 AM (6 days ago) Apr 8
to Liza Bipin, Elie Maamari, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Ibd9969b087b5b7e4ef7367cb7286cb9204dfc1f3
Reviewed-by: Elie Maamari <emaa...@google.com>
Commit-Queue: Elie Maamari <emaa...@google.com>
Auto-Submit: Liza Bipin <mlb...@google.com>
Cr-Commit-Position: refs/heads/main@{#1611496}
Files:
- M chrome/browser/ui/webui/signin/ash/edu_account_login_handler_unittest.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Elie Maamari
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Apr 8, 2026, 11:36:39 AM (6 days ago) Apr 8
to Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 8, 2026, 11:55:26 AM (6 days ago) Apr 8
to Tanmoy Mollik, Alex Ilin, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: Icba1a032c523c33c5249cb2a0c4db63c34072101
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Alex Ilin <alex...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1611542}
Files:
- M components/signin/public/identity_manager/access_token_fetcher_unittest.cc
- M components/signin/public/identity_manager/diagnostics_provider_unittest.cc
- M components/signin/public/identity_manager/identity_manager_unittest.cc
- M components/signin/public/identity_manager/primary_account_access_token_fetcher.cc
- M components/signin/public/identity_manager/primary_account_access_token_fetcher_unittest.cc
Change size: M
Delta: 5 files changed, 56 insertions(+), 91 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Ilin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Apr 10, 2026, 5:49:21 AM (4 days ago) Apr 10
to Tanmoy Mollik, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tanmoy Mollik
Alex Ilin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alex Ilin
| Code-Review | +1 |
2 comments
Patchset-level comments
File components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_unittest.cc
Line 83, Patchset 2 (Latest):
// Contains all non-deprecated Google service auth errors.
const GoogleServiceAuthError table[] = {
GoogleServiceAuthError::AuthErrorNone(),
GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
GoogleServiceAuthError::InvalidGaiaCredentialsReason::UNKNOWN),
GoogleServiceAuthError::CreateAccountNotFound(),
GoogleServiceAuthError::FromConnectionError(net::ERR_FAILED),
GoogleServiceAuthError::FromServiceUnavailable(std::string()),
GoogleServiceAuthError::CreateRequestCanceled(),
GoogleServiceAuthError::FromUnexpectedServiceResponse(std::string()),
GoogleServiceAuthError::FromServiceError(std::string()),
GoogleServiceAuthError::FromScopeLimitedUnrecoverableErrorReason(
GoogleServiceAuthError::ScopeLimitedUnrecoverableErrorReason::
kInvalidScope),
GoogleServiceAuthError::FromTokenBindingChallenge(std::string()),
GoogleServiceAuthError::FromDeviceManagementError(
std::make_unique<gaia::FakeDeviceManagementErrorDetails>()),
};Alex Ilin . unresolved
It's forbidden to have static objects that don't have a trivial destructor.
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
Consider either making `table` a test fixture class member or wrapping it in a function like the following:
```
std::vector<GoogleServiceAuthError> GetAllErrors() {
return {
GoogleServiceAuthError::AuthErrorNone(),
// ...
};
}
```
Related details
Attention is currently required from:
- Tanmoy Mollik
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Apr 10, 2026, 6:22:57 AM (4 days ago) Apr 10
to Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik added 1 comment![]( "Open in Gerrit")
File components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_unittest.cc
Line 83, Patchset 2:
// Contains all non-deprecated Google service auth errors.
const GoogleServiceAuthError table[] = {
GoogleServiceAuthError::AuthErrorNone(),
GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
GoogleServiceAuthError::InvalidGaiaCredentialsReason::UNKNOWN),
GoogleServiceAuthError::CreateAccountNotFound(),
GoogleServiceAuthError::FromConnectionError(net::ERR_FAILED),
GoogleServiceAuthError::FromServiceUnavailable(std::string()),
GoogleServiceAuthError::CreateRequestCanceled(),
GoogleServiceAuthError::FromUnexpectedServiceResponse(std::string()),
GoogleServiceAuthError::FromServiceError(std::string()),
GoogleServiceAuthError::FromScopeLimitedUnrecoverableErrorReason(
GoogleServiceAuthError::ScopeLimitedUnrecoverableErrorReason::
kInvalidScope),
GoogleServiceAuthError::FromTokenBindingChallenge(std::string()),
GoogleServiceAuthError::FromDeviceManagementError(
std::make_unique<gaia::FakeDeviceManagementErrorDetails>()),
};Alex Ilin . resolved
It's forbidden to have static objects that don't have a trivial destructor.
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
Consider either making `table` a test fixture class member or wrapping it in a function like the following:
```
std::vector<GoogleServiceAuthError> GetAllErrors() {
return {
GoogleServiceAuthError::AuthErrorNone(),
// ...
};
}
```
Tanmoy Mollik
I had to add some extra code to be able to do the `static_assert` check.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanmoy Mollik (Gerrit)
Apr 10, 2026, 6:24:27 AM (4 days ago) Apr 10
to Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Tanmoy Mollik voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 10, 2026, 7:25:43 AM (4 days ago) Apr 10
to Tanmoy Mollik, Alex Ilin, chromium...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_unittest.cc
Insertions: 28, Deletions: 29.
@@ -81,35 +81,39 @@
}
// Contains all non-deprecated Google service auth errors.
-const GoogleServiceAuthError table[] = {
- GoogleServiceAuthError::AuthErrorNone(),
- GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
- GoogleServiceAuthError::InvalidGaiaCredentialsReason::UNKNOWN),
- GoogleServiceAuthError::CreateAccountNotFound(),
- GoogleServiceAuthError::FromConnectionError(net::ERR_FAILED),
- GoogleServiceAuthError::FromServiceUnavailable(std::string()),
- GoogleServiceAuthError::CreateRequestCanceled(),
- GoogleServiceAuthError::FromUnexpectedServiceResponse(std::string()),
- GoogleServiceAuthError::FromServiceError(std::string()),
- GoogleServiceAuthError::FromScopeLimitedUnrecoverableErrorReason(
- GoogleServiceAuthError::ScopeLimitedUnrecoverableErrorReason::
- kInvalidScope),
- GoogleServiceAuthError::FromTokenBindingChallenge(std::string()),
- GoogleServiceAuthError::FromDeviceManagementError(
- std::make_unique<gaia::FakeDeviceManagementErrorDetails>()),
-};
+std::vector<GoogleServiceAuthError> GetAllErrors() {
+ const GoogleServiceAuthError table[] = {
+ GoogleServiceAuthError::AuthErrorNone(),
+ GoogleServiceAuthError::FromInvalidGaiaCredentialsReason(
+ GoogleServiceAuthError::InvalidGaiaCredentialsReason::UNKNOWN),
+ GoogleServiceAuthError::CreateAccountNotFound(),
+ GoogleServiceAuthError::FromConnectionError(net::ERR_FAILED),
+ GoogleServiceAuthError::FromServiceUnavailable(std::string()),
+ GoogleServiceAuthError::CreateRequestCanceled(),
+ GoogleServiceAuthError::FromUnexpectedServiceResponse(std::string()),
+ GoogleServiceAuthError::FromServiceError(std::string()),
+ GoogleServiceAuthError::FromScopeLimitedUnrecoverableErrorReason(
+ GoogleServiceAuthError::ScopeLimitedUnrecoverableErrorReason::
+ kInvalidScope),
+ GoogleServiceAuthError::FromTokenBindingChallenge(std::string()),
+ GoogleServiceAuthError::FromDeviceManagementError(
+ std::make_unique<gaia::FakeDeviceManagementErrorDetails>()),
+ };
+ static_assert(
+ std::size(table) == GoogleServiceAuthError::NUM_STATES -
+ GoogleServiceAuthError::kDeprecatedStateCount,
+ "table size should match number of auth error types");
+
+ return std::vector<GoogleServiceAuthError>(std::begin(table),
+ std::end(table));
+}
TEST_F(ProfileOAuth2TokenServiceDelegateTest, UpdateAuthErrorPersistenErrors) {
const CoreAccountId account_id =
CoreAccountId::FromGaiaId(GaiaId("account_id"));
delegate.UpdateCredentials(account_id, "refresh_token");
- static_assert(
- std::size(table) == GoogleServiceAuthError::NUM_STATES -
- GoogleServiceAuthError::kDeprecatedStateCount,
- "table size should match number of auth error types");
-
- for (const auto& error : table) {
+ for (const auto& error : GetAllErrors()) {
if (!error.IsPersistentError() || error.IsScopePersistentError()) {
continue;
}
@@ -133,14 +137,9 @@
CoreAccountId::FromGaiaId(GaiaId("account_id"));
delegate.UpdateCredentials(account_id, "refresh_token");
- static_assert(
- std::size(table) == GoogleServiceAuthError::NUM_STATES -
- GoogleServiceAuthError::kDeprecatedStateCount,
- "table size should match number of auth error types");
-
EXPECT_TRUE(delegate.BackoffEntry());
int failure_count = 0;
- for (const auto& error : table) {
+ for (const auto& error : GetAllErrors()) {
if (!error.IsTransientError()) {
continue;
}
```
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I0019faab56681a95b688f61222f445ba77c188c6
Commit-Queue: Tanmoy Mollik <triplo...@google.com>
Reviewed-by: Alex Ilin <alex...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1612761}
Files:
- M components/signin/internal/identity_manager/fake_profile_oauth2_token_service.h
- M components/signin/internal/identity_manager/fake_profile_oauth2_token_service_delegate.cc
- M components/signin/internal/identity_manager/gaia_cookie_manager_service.cc
- M components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc
- M components/signin/internal/identity_manager/oauth_multilogin_helper_unittest.cc
- M components/signin/internal/identity_manager/oauth_multilogin_token_fetcher_unittest.cc
- M components/signin/internal/identity_manager/profile_oauth2_token_service.cc
- M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc
- M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_unittest.cc
- M components/signin/internal/identity_manager/profile_oauth2_token_service_unittest.cc
Change size: M
Delta: 10 files changed, 115 insertions(+), 133 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Ilin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Roland Bock (Gerrit)
Apr 10, 2026, 9:57:51 AM (4 days ago) Apr 10
to Liza Bipin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Liza Bipin
Roland Bock voted and added 1 comment![]( "Open in Gerrit")
Votes added by Roland Bock
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Liza Bipin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liza Bipin (Gerrit)
Apr 10, 2026, 9:58:42 AM (4 days ago) Apr 10
to Roland Bock, Chromium LUCI CQ, chromium...@chromium.org
Liza Bipin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 10, 2026, 10:02:04 AM (4 days ago) Apr 10
to Liza Bipin, Roland Bock, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[google_apis] Use factory method to create GoogleServiceAuthError
Bug: 487926694
Change-Id: I569f1fa2ef31cb83b2ca129fd032e08c70fe952d
Reviewed-by: Roland Bock <rb...@google.com>
Commit-Queue: Liza Bipin <mlb...@google.com>
Cr-Commit-Position: refs/heads/main@{#1612824}
Files:
- M components/invalidation/impl/per_user_topic_subscription_manager_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Roland Bock
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
It is loading more messages.
0 new messages