Extend WebView integrity timing histograms range [chromium/src : main]

1 view
Skip to first unread message

Peter Pakkenberg (Gerrit)

unread,
Jun 12, 2025, 8:35:27 AM6/12/25
to Michael van Ouwerkerk, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Michael van Ouwerkerk

Peter Pakkenberg voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael van Ouwerkerk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c69b8fbe1e1057d1347c4c792bc27200936dd35
Gerrit-Change-Number: 6632623
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:35:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael van Ouwerkerk (Gerrit)

unread,
Jun 12, 2025, 8:38:20 AM6/12/25
to Peter Pakkenberg, Michael van Ouwerkerk, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Peter Pakkenberg

Michael van Ouwerkerk voted and added 1 comment

Votes added by Michael van Ouwerkerk

Code-Review+1

1 comment

File tools/metrics/histograms/metadata/android/histograms.xml
Line 7252, Patchset 2 (Latest): Records the end-to-end time for a GetTokenProvider call to a successfull
Michael van Ouwerkerk . unresolved

nit: successful

Open in Gerrit

Related details

Attention is currently required from:
  • Peter Pakkenberg
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c69b8fbe1e1057d1347c4c792bc27200936dd35
Gerrit-Change-Number: 6632623
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:38:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Pakkenberg (Gerrit)

unread,
Jun 12, 2025, 8:39:15 AM6/12/25
to Michael van Ouwerkerk, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Peter Pakkenberg voted and added 1 comment

Votes added by Peter Pakkenberg

Auto-Submit+1
Commit-Queue+2

1 comment

File tools/metrics/histograms/metadata/android/histograms.xml
Line 7252, Patchset 2: Records the end-to-end time for a GetTokenProvider call to a successfull
Michael van Ouwerkerk . resolved

nit: successful

Peter Pakkenberg

Fix applied.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c69b8fbe1e1057d1347c4c792bc27200936dd35
Gerrit-Change-Number: 6632623
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:39:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael van Ouwerkerk <mvanou...@chromium.org>
satisfied_requirement
open
diffy

Peter Beverloo (Gerrit)

unread,
Jun 12, 2025, 8:50:39 AM6/12/25
to Peter Pakkenberg, Peter Beverloo, Michael van Ouwerkerk, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Peter Pakkenberg

Peter Beverloo voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Peter Pakkenberg
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c69b8fbe1e1057d1347c4c792bc27200936dd35
Gerrit-Change-Number: 6632623
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>
Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:50:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 12, 2025, 9:21:01 AM6/12/25
to Peter Pakkenberg, Peter Beverloo, Michael van Ouwerkerk, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Extend WebView integrity timing histograms range

This CL extends the range of the timing histograms for creating
integrity providers from 10 seconds to 3 minutes.

The actual change happens in https://crrev.com/i/8342459
Bug: 424388926
Change-Id: I3c69b8fbe1e1057d1347c4c792bc27200936dd35
Reviewed-by: Peter Beverloo <pe...@chromium.org>
Auto-Submit: Peter Pakkenberg <pb...@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanou...@chromium.org>
Commit-Queue: Peter Pakkenberg <pb...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473001}
Files:
  • M tools/metrics/histograms/metadata/android/histograms.xml
Change size: S
Delta: 1 file changed, 13 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael van Ouwerkerk, +1 by Peter Beverloo
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3c69b8fbe1e1057d1347c4c792bc27200936dd35
Gerrit-Change-Number: 6632623
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>
Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages