[PWA_Install_Dialog] Parameterize policy and DevTools tests [chromium/src : main]

0 views
Skip to first unread message

Adriana Ixba (Gerrit)

unread,
Jul 7, 2026, 9:00:40 PM (21 hours ago) Jul 7
to Chromium Web Applications Reviews, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Chromium Web Applications Reviews

Adriana Ixba voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chromium Web Applications Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
Gerrit-Change-Number: 8061346
Gerrit-PatchSet: 1
Gerrit-Owner: Adriana Ixba <ai...@chromium.org>
Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
Gerrit-Reviewer: Chromium Web Applications Reviews <chromium-web...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Chromium Web Applications Reviews <chromium-web...@google.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 01:00:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 7, 2026, 9:08:16 PM (21 hours ago) Jul 7
to Adriana Ixba, Chromium Web Applications Reviews, Luke Deng, Dibyajyoti Pal, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Dibyajyoti Pal and Luke Deng

Message from gwsq

Shadowed: luke...@chromium.org

Reviewer source(s):
luke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/ui/web_applications/config.gwsq)
diby...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/ui/web_applications/config.gwsq,googleclient/chrome/chromium_gwsq/chrome/browser/web_applications/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Dibyajyoti Pal
  • Luke Deng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
Gerrit-Change-Number: 8061346
Gerrit-PatchSet: 1
Gerrit-Owner: Adriana Ixba <ai...@chromium.org>
Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
Gerrit-Reviewer: Luke Deng <luke...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Luke Deng <luke...@google.com>
Gerrit-Attention: Dibyajyoti Pal <diby...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 01:07:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Luke Deng (Gerrit)

unread,
12:39 PM (5 hours ago) 12:39 PM
to Adriana Ixba, Chromium Web Applications Reviews, Dibyajyoti Pal, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Adriana Ixba and Dibyajyoti Pal

Luke Deng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adriana Ixba
  • Dibyajyoti Pal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
    Gerrit-Change-Number: 8061346
    Gerrit-PatchSet: 1
    Gerrit-Owner: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Attention: Adriana Ixba <ai...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 16:39:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dibyajyoti Pal (Gerrit)

    unread,
    4:04 PM (2 hours ago) 4:04 PM
    to Adriana Ixba, Luke Deng, Chromium Web Applications Reviews, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
    Attention needed from Adriana Ixba

    Dibyajyoti Pal voted and added 1 comment

    Votes added by Dibyajyoti Pal

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Dibyajyoti Pal . resolved

    LGTM, welcome back! 😄

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adriana Ixba
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
    Gerrit-Change-Number: 8061346
    Gerrit-PatchSet: 1
    Gerrit-Owner: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Adriana Ixba <ai...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 20:03:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Adriana Ixba (Gerrit)

    unread,
    4:08 PM (2 hours ago) 4:08 PM
    to Luke Deng, Chromium Web Applications Reviews, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

    Adriana Ixba voted and added 1 comment

    Votes added by Adriana Ixba

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Adriana Ixba . resolved

    Thanks for the reviews!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
    Gerrit-Change-Number: 8061346
    Gerrit-PatchSet: 1
    Gerrit-Owner: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Web Applications Reviews <chromium-web...@google.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Wed, 08 Jul 2026 20:08:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    4:13 PM (2 hours ago) 4:13 PM
    to Adriana Ixba, Dibyajyoti Pal, Luke Deng, Chromium Web Applications Reviews, chromium...@chromium.org, Andrew Rayskiy, Simon Hangl, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [PWA_Install_Dialog] Parameterize policy and DevTools tests

    This parameterizes tests around the kWebAppInstallDialog feature
    Bug: 532156082
    Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
    Reviewed-by: Dibyajyoti Pal <diby...@chromium.org>
    Reviewed-by: Luke Deng <luke...@google.com>
    Commit-Queue: Adriana Ixba <ai...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1659019}
    Files:
    • M chrome/browser/web_applications/alternative_error_page_override_info_browsertest.cc
    • M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_dev_tools_browsertest.cc
    • M chrome/browser/web_applications/policy/web_app_policy_manager_browsertest.cc
    Change size: M
    Delta: 3 files changed, 47 insertions(+), 43 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Dibyajyoti Pal, +1 by Luke Deng
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I212c835f1cad6afd165e8a1e406896fcc6af4458
    Gerrit-Change-Number: 8061346
    Gerrit-PatchSet: 2
    Gerrit-Owner: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Adriana Ixba <ai...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-Reviewer: Luke Deng <luke...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages