Componentize chrome/browser/content_index/ [chromium/src : main]
0 views
Skip to first unread message
Antonio Gomes (Gerrit)
11:11 AM (9 hours ago) 11:11 AM
to Antonio Gomes, Chromium LUCI CQ, AyeAye, Darryl James, chromium...@chromium.org, Erik Chen, rayanka...@chromium.org
Attention needed from Darryl James
Antonio Gomes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
2:23 PM (6 hours ago) 2:23 PM
to Antonio Gomes, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Erik Chen, rayanka...@chromium.org
Attention needed from Antonio Gomes
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Gomes
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Gomes (Gerrit)
4:23 PM (4 hours ago) 4:23 PM
to Antonio Gomes, Darryl James, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Erik Chen, rayanka...@chromium.org
Antonio Gomes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:46 PM (3 hours ago) 4:46 PM
to Antonio Gomes, Darryl James, AyeAye, chromium...@chromium.org, Erik Chen, rayanka...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Componentize chrome/browser/content_index/
This CL adds a BUILD.gn files to drive the compilation of
c/b/content_index/, as per [1].
[1] docs/chrome_browser_design_principles.md
R=dlj...@chromium.org
Bug: 353332589
Change-Id: Ifb9defcd65e05bdf1bd3b5454f9d538a7225e7a2
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Antonio Gomes <toni...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1532511}
Files:
- M chrome/browser/BUILD.gn
- A chrome/browser/content_index/BUILD.gn
- M chrome/browser/profiles/BUILD.gn
- M chrome/test/BUILD.gn
Change size: M
Delta: 4 files changed, 99 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages