[WIB] Add support for online windows customization - pin_customizations [infra/infra : main]
Anushruth Sasivehalli (Gerrit)
Attention is currently required from: Adam Todd, Xixuan Wu.
1 comment:
File recipes/recipes/windows_image_builder/windows_image_builder.proto:
Patch Set #5, Line 43:
ARCH_ARM64There is no such thing as ARM64. The architecture is called AARCH64
To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.
Adam Todd (Gerrit)
Attention is currently required from: Anushruth Sasivehalli, Xixuan Wu.
1 comment:
File recipes/recipes/windows_image_builder/windows_image_builder.proto:
Patch Set #5, Line 43:
ARCH_ARM64
There is no such thing as ARM64. […]
Interesting, there are lots of references to ARM64 in windows documentation.
https://docs.microsoft.com/en-us/search/?scope=OEM&view=windows-11&terms=arm64
To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.
Anushruth Sasivehalli (Gerrit)
Attention is currently required from: Adam Todd, Xixuan Wu.
1 comment:
File recipes/recipes/windows_image_builder/windows_image_builder.proto:
Patch Set #5, Line 43:
ARCH_ARM64
Interesting, there are lots of references to ARM64 in windows documentation. […]
Yeah. That's why I called it `arm64`. Turns out the architecture has gone through various names. But the current standard is `aarch64`. Also It's helpful to have the names that QEMU/GCC use. We can directly convert the enum to string and use it.
To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.
Adam Todd (Gerrit)
Attention is currently required from: Anushruth Sasivehalli, Xixuan Wu.
1 comment:
File recipes/recipes/windows_image_builder/windows_image_builder.proto:
Patch Set #5, Line 43:
ARCH_ARM64
Yeah. That's why I called it `arm64`. Turns out the architecture has gone through various names. […]
Ok, additionally consider that winpe also uses this value and calls it ARM64. How would you like to handle for this?
To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.
Anushruth Sasivehalli (Gerrit)
Attention is currently required from: Adam Todd, Xixuan Wu.
1 comment:
File recipes/recipes/windows_image_builder/windows_image_builder.proto:
Patch Set #5, Line 43:
ARCH_ARM64
Ok, additionally consider that winpe also uses this value and calls it ARM64. […]
Added support for it in crrev.com/c/3726961
To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.
Xixuan Wu (Gerrit)
Attention is currently required from: Adam Todd, Anushruth Sasivehalli.
Patch set 9:Code-Review +1
Anushruth Sasivehalli (Gerrit)
Attention is currently required from: Adam Todd, Anushruth Sasivehalli.
Patch set 11:Commit-Queue +2
Anushruth Sasivehalli (Gerrit)
Attention is currently required from: Adam Todd, Anushruth Sasivehalli.
Patch set 11:Commit-Queue +2
To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.
LUCI CQ (Gerrit)
LUCI CQ submitted this change.
9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: recipes/recipe_modules/windows_scripts_executor/online_windows_customization.py
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: recipes/recipe_modules/windows_scripts_executor/test_helper.py
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
[WIB] Add support for online windows customization - pin_customizations
Bug: b/182061277
Add online_windows_customization with support for pinning artifacts.
Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3708004
Reviewed-by: Xixuan Wu <xix...@chromium.org>
Commit-Queue: Anushruth Sasivehalli <anus...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#50125}
---
M recipes/README.recipes.md
M recipes/recipe_modules/windows_scripts_executor/__init__.py
M recipes/recipe_modules/windows_scripts_executor/api.py
M recipes/recipe_modules/windows_scripts_executor/customization.py
A recipes/recipe_modules/windows_scripts_executor/examples/online_windows_customization.py
A recipes/recipe_modules/windows_scripts_executor/online_windows_customization.py
M recipes/recipe_modules/windows_scripts_executor/test_helper.py
7 files changed, 270 insertions(+), 28 deletions(-)