[WIB] Add support for online windows customization - pin_customizations [infra/infra : main]

0 views
Skip to first unread message

Anushruth Sasivehalli (Gerrit)

unread,
Jun 16, 2022, 7:00:06 PMJun 16
to Adam Todd, Xixuan Wu, Tzvi Zeller, chromium...@chromium.org

Attention is currently required from: Adam Todd, Xixuan Wu.

View Change

1 comment:

  • File recipes/recipes/windows_image_builder/windows_image_builder.proto:

To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
Gerrit-Change-Number: 3708004
Gerrit-PatchSet: 5
Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Reviewer: Adam Todd <act...@google.com>
Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
Gerrit-CC: Tzvi Zeller <tze...@google.com>
Gerrit-Attention: Adam Todd <act...@google.com>
Gerrit-Attention: Xixuan Wu <xix...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Jun 2022 23:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Adam Todd (Gerrit)

unread,
Jun 17, 2022, 2:29:23 PMJun 17
to Anushruth Sasivehalli, Xixuan Wu, Tzvi Zeller, chromium...@chromium.org

Attention is currently required from: Anushruth Sasivehalli, Xixuan Wu.

View Change

1 comment:

  • File recipes/recipes/windows_image_builder/windows_image_builder.proto:

To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
Gerrit-Change-Number: 3708004
Gerrit-PatchSet: 5
Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Reviewer: Adam Todd <act...@google.com>
Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
Gerrit-CC: Tzvi Zeller <tze...@google.com>
Gerrit-Attention: Xixuan Wu <xix...@chromium.org>
Gerrit-Attention: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jun 2022 18:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-MessageType: comment

Anushruth Sasivehalli (Gerrit)

unread,
Jun 17, 2022, 5:14:23 PMJun 17
to Adam Todd, Xixuan Wu, Tzvi Zeller, chromium...@chromium.org

Attention is currently required from: Adam Todd, Xixuan Wu.

View Change

1 comment:

  • File recipes/recipes/windows_image_builder/windows_image_builder.proto:

    • Interesting, there are lots of references to ARM64 in windows documentation. […]

      Yeah. That's why I called it `arm64`. Turns out the architecture has gone through various names. But the current standard is `aarch64`. Also It's helpful to have the names that QEMU/GCC use. We can directly convert the enum to string and use it.

To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
Gerrit-Change-Number: 3708004
Gerrit-PatchSet: 5
Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Reviewer: Adam Todd <act...@google.com>
Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
Gerrit-CC: Tzvi Zeller <tze...@google.com>
Gerrit-Attention: Adam Todd <act...@google.com>
Gerrit-Attention: Xixuan Wu <xix...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jun 2022 21:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Adam Todd <act...@google.com>

Adam Todd (Gerrit)

unread,
Jun 17, 2022, 6:59:35 PMJun 17
to Anushruth Sasivehalli, Xixuan Wu, Tzvi Zeller, chromium...@chromium.org

Attention is currently required from: Anushruth Sasivehalli, Xixuan Wu.

View Change

1 comment:

  • File recipes/recipes/windows_image_builder/windows_image_builder.proto:

    • Yeah. That's why I called it `arm64`. Turns out the architecture has gone through various names. […]

      Ok, additionally consider that winpe also uses this value and calls it ARM64. How would you like to handle for this?

To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
Gerrit-Change-Number: 3708004
Gerrit-PatchSet: 6
Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Reviewer: Adam Todd <act...@google.com>
Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
Gerrit-CC: Tzvi Zeller <tze...@google.com>
Gerrit-Attention: Xixuan Wu <xix...@chromium.org>
Gerrit-Attention: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jun 2022 22:59:24 +0000

Anushruth Sasivehalli (Gerrit)

unread,
Jun 27, 2022, 3:26:01 PMJun 27
to Adam Todd, Xixuan Wu, Tzvi Zeller, chromium...@chromium.org

Attention is currently required from: Adam Todd, Xixuan Wu.

View Change

1 comment:

  • File recipes/recipes/windows_image_builder/windows_image_builder.proto:

    • Ok, additionally consider that winpe also uses this value and calls it ARM64. […]

      Added support for it in crrev.com/c/3726961

To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
Gerrit-Change-Number: 3708004
Gerrit-PatchSet: 7
Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
Gerrit-Reviewer: Adam Todd <act...@google.com>
Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
Gerrit-CC: Tzvi Zeller <tze...@google.com>
Gerrit-Attention: Adam Todd <act...@google.com>
Gerrit-Attention: Xixuan Wu <xix...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Jun 2022 19:25:51 +0000

Xixuan Wu (Gerrit)

unread,
Jul 2, 2022, 1:50:28 AMJul 2
to Anushruth Sasivehalli, Adam Todd, Tzvi Zeller, chromium...@chromium.org

Attention is currently required from: Adam Todd, Anushruth Sasivehalli.

Patch set 9:Code-Review +1

View Change

    To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
    Gerrit-Change-Number: 3708004
    Gerrit-PatchSet: 9
    Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
    Gerrit-Reviewer: Adam Todd <act...@google.com>
    Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
    Gerrit-CC: Tzvi Zeller <tze...@google.com>
    Gerrit-Attention: Adam Todd <act...@google.com>
    Gerrit-Attention: Anushruth Sasivehalli <anus...@chromium.org>
    Gerrit-Comment-Date: Sat, 02 Jul 2022 05:50:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Anushruth Sasivehalli (Gerrit)

    unread,
    Jul 7, 2022, 9:36:26 PMJul 7
    to Xixuan Wu, Adam Todd, Tzvi Zeller, chromium...@chromium.org

    Attention is currently required from: Adam Todd, Anushruth Sasivehalli.

    Patch set 11:Commit-Queue +2

    View Change

      To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: infra/infra
      Gerrit-Branch: main
      Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
      Gerrit-Change-Number: 3708004
      Gerrit-PatchSet: 11
      Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
      Gerrit-Reviewer: Adam Todd <act...@google.com>
      Gerrit-Reviewer: Anushruth Sasivehalli <anus...@chromium.org>
      Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
      Gerrit-CC: Tzvi Zeller <tze...@google.com>
      Gerrit-Attention: Adam Todd <act...@google.com>
      Gerrit-Attention: Anushruth Sasivehalli <anus...@chromium.org>
      Gerrit-Comment-Date: Fri, 08 Jul 2022 01:36:17 +0000

      Anushruth Sasivehalli (Gerrit)

      unread,
      Jul 7, 2022, 9:49:10 PMJul 7
      to LUCI CQ, Xixuan Wu, Adam Todd, Tzvi Zeller, chromium...@chromium.org

      Attention is currently required from: Adam Todd, Anushruth Sasivehalli.

      Patch set 11:Commit-Queue +2

      View Change

        To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: infra/infra
        Gerrit-Branch: main
        Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
        Gerrit-Change-Number: 3708004
        Gerrit-PatchSet: 11
        Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
        Gerrit-Reviewer: Adam Todd <act...@google.com>
        Gerrit-Reviewer: Anushruth Sasivehalli <anus...@chromium.org>
        Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
        Gerrit-CC: Tzvi Zeller <tze...@google.com>
        Gerrit-Attention: Adam Todd <act...@google.com>
        Gerrit-Attention: Anushruth Sasivehalli <anus...@chromium.org>
        Gerrit-Comment-Date: Fri, 08 Jul 2022 01:48:58 +0000

        LUCI CQ (Gerrit)

        unread,
        Jul 7, 2022, 9:52:37 PMJul 7
        to Anushruth Sasivehalli, Xixuan Wu, Adam Todd, Tzvi Zeller, chromium...@chromium.org

        LUCI CQ submitted this change.

        View Change



        9 is the latest approved patch-set.
        The change was submitted with unreviewed changes in the following files:

        ```
        The name of the file: recipes/recipe_modules/windows_scripts_executor/online_windows_customization.py
        Insertions: 1, Deletions: 1.

        The diff is too large to show. Please review the diff.
        ```
        ```
        The name of the file: recipes/recipe_modules/windows_scripts_executor/test_helper.py
        Insertions: 1, Deletions: 1.

        The diff is too large to show. Please review the diff.
        ```

        Approvals: Xixuan Wu: Looks good to me Anushruth Sasivehalli: Commit
        [WIB] Add support for online windows customization - pin_customizations

        Bug: b/182061277

        Add online_windows_customization with support for pinning artifacts.

        Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
        Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/3708004
        Reviewed-by: Xixuan Wu <xix...@chromium.org>
        Commit-Queue: Anushruth Sasivehalli <anus...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#50125}
        ---
        M recipes/README.recipes.md
        M recipes/recipe_modules/windows_scripts_executor/__init__.py
        M recipes/recipe_modules/windows_scripts_executor/api.py
        M recipes/recipe_modules/windows_scripts_executor/customization.py
        A recipes/recipe_modules/windows_scripts_executor/examples/online_windows_customization.py
        A recipes/recipe_modules/windows_scripts_executor/online_windows_customization.py
        M recipes/recipe_modules/windows_scripts_executor/test_helper.py
        7 files changed, 270 insertions(+), 28 deletions(-)


        To view, visit change 3708004. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: infra/infra
        Gerrit-Branch: main
        Gerrit-Change-Id: I66db76d8d1b643659384739d85e69465ecaa4dc0
        Gerrit-Change-Number: 3708004
        Gerrit-PatchSet: 12
        Gerrit-Owner: Anushruth Sasivehalli <anus...@chromium.org>
        Gerrit-Reviewer: Adam Todd <act...@google.com>
        Gerrit-Reviewer: Anushruth Sasivehalli <anus...@chromium.org>
        Gerrit-Reviewer: Xixuan Wu <xix...@chromium.org>
        Gerrit-CC: Tzvi Zeller <tze...@google.com>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages