[auth-service] Dedupe role expansion for perms [infra/luci/luci-go : main]
0 views
Skip to first unread message
Anne Redulla (Gerrit)
2:06 AM (18 hours ago) 2:06 AM
to Dan Le Febvre, LUCI CQ, chromium...@chromium.org
Attention needed from Dan Le Febvre
Anne Redulla voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Dan Le Febvre
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Le Febvre (Gerrit)
3:32 AM (17 hours ago) 3:32 AM
to Anne Redulla, LUCI CQ, chromium...@chromium.org
Attention needed from Anne Redulla
Dan Le Febvre voted![]( "Open in Gerrit")
Attention is currently required from:
- Anne Redulla
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anne Redulla (Gerrit)
7:59 PM (9 minutes ago) 7:59 PM
to Dan Le Febvre, LUCI CQ, chromium...@chromium.org
Attention needed from Dan Le Febvre
Anne Redulla voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dan Le Febvre
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
7:59 PM (9 minutes ago) 7:59 PM
to Anne Redulla, Dan Le Febvre, chromium...@chromium.org
LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[auth-service] Dedupe role expansion for perms
This CL tweaks role expansion to skip adding
parent permissions if they have already been added.
This helps in cases like a role which extends other roles that have a
common parent role.
Bug: b/534824421
Change-Id: Iad56310522601aa5a6ef7707fcac2fc210e0cee7
Reviewed-by: Dan Le Febvre <d...@google.com>
Auto-Submit: Anne Redulla <ared...@google.com>
Commit-Queue: Anne Redulla <ared...@google.com>
Files:
- M auth_service/internal/realmsinternals/expansion.go
- M auth_service/internal/realmsinternals/expansion_test.go
Change size: S
Delta: 2 files changed, 48 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dan Le Febvre
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages