disable topControlsScroll [chromium/src : main]

0 views
Skip to first unread message

Linyu He (Gerrit)

unread,
8:25 PM (3 hours ago) 8:25 PM
to Eleanor Lee, chromium...@chromium.org
Attention needed from Eleanor Lee

Linyu He voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eleanor Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fa36ff68a68603589c7c1971720efde0d583f97
Gerrit-Change-Number: 7335434
Gerrit-PatchSet: 1
Gerrit-Owner: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Attention: Eleanor Lee <elean...@google.com>
Gerrit-Comment-Date: Sat, 27 Dec 2025 01:24:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Wenyu Fu (Gerrit)

unread,
8:25 PM (3 hours ago) 8:25 PM
to Eleanor Lee, Linyu He, chromium...@chromium.org
Attention needed from Eleanor Lee

Wenyu Fu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eleanor Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fa36ff68a68603589c7c1971720efde0d583f97
Gerrit-Change-Number: 7335434
Gerrit-PatchSet: 1
Gerrit-Owner: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
Gerrit-Attention: Eleanor Lee <elean...@google.com>
Gerrit-Comment-Date: Sat, 27 Dec 2025 01:25:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Eleanor Lee (Gerrit)

unread,
8:26 PM (3 hours ago) 8:26 PM
to Wenyu Fu, Linyu He, chromium...@chromium.org

Eleanor Lee voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fa36ff68a68603589c7c1971720efde0d583f97
Gerrit-Change-Number: 7335434
Gerrit-PatchSet: 1
Gerrit-Owner: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
Gerrit-Comment-Date: Sat, 27 Dec 2025 01:26:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
8:55 PM (2 hours ago) 8:55 PM
to Eleanor Lee, Wenyu Fu, Linyu He, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
disable topControlsScroll
Bug: 471837397
Change-Id: I3fa36ff68a68603589c7c1971720efde0d583f97
Reviewed-by: Linyu He <lin...@google.com>
Reviewed-by: Wenyu Fu <wen...@chromium.org>
Commit-Queue: Eleanor Lee <elean...@google.com>
Cr-Commit-Position: refs/heads/main@{#1562826}
Files:
  • M chrome/android/javatests/src/org/chromium/chrome/browser/browser_controls/BrowserControlsPTTest.java
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Linyu He, +1 by Wenyu Fu
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3fa36ff68a68603589c7c1971720efde0d583f97
Gerrit-Change-Number: 7335434
Gerrit-PatchSet: 2
Gerrit-Owner: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages