[iOS]Remove code repetition [chromium/src : main]
1 view
Skip to first unread message
Arthur Milchior (Gerrit)
Apr 22, 2026, 8:33:44 PM (13 days ago) Apr 22
to Huiting Yu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Huiting Yu
Arthur Milchior voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Huiting Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Huiting Yu (Gerrit)
Apr 24, 2026, 6:06:39 PM (11 days ago) Apr 24
to Arthur Milchior, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Arthur Milchior
Huiting Yu added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/bookmarks/ui_bundled/home/bookmarks_home_view_controller.mm
Line 968, Patchset 4 (Latest):
if ([self isIncognitoForced]) {Huiting Yu . unresolved
This logic is incorrect. If `inIncognito` is `YES` and `isIncognitoForced` is `YES`, this method will now return early and fail to open the URLs.
The check for `isIncognitoForced` should only apply when `inIncognito` is `NO`.
The comment above this method correctly describes the intent: \"if `inIncognito` is NO but incognito is forced, do nothing.\" but the implementation checks it regardless of the value of `inIncognito`.
Related details
Attention is currently required from:
- Arthur Milchior
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Milchior (Gerrit)
Apr 29, 2026, 8:55:29 AM (6 days ago) Apr 29
to Huiting Yu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Huiting Yu
Arthur Milchior voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Milchior
| Auto-Submit | +1 |
1 comment
File ios/chrome/browser/bookmarks/ui_bundled/home/bookmarks_home_view_controller.mm
This logic is incorrect. If `inIncognito` is `YES` and `isIncognitoForced` is `YES`, this method will now return early and fail to open the URLs.
The check for `isIncognitoForced` should only apply when `inIncognito` is `NO`.
The comment above this method correctly describes the intent: \"if `inIncognito` is NO but incognito is forced, do nothing.\" but the implementation checks it regardless of the value of `inIncognito`.
Attention is currently required from:
- Huiting Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Huiting Yu (Gerrit)
May 4, 2026, 3:20:13 PM (17 hours ago) May 4
to Arthur Milchior, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Arthur Milchior
Huiting Yu voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Milchior
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Milchior (Gerrit)
6:43 AM (2 hours ago) 6:43 AM
to Huiting Yu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Arthur Milchior voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:38 AM (1 hour ago) 7:38 AM
to Arthur Milchior, Huiting Yu, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
16 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[iOS]Remove code repetition
Each time the method openAllURLs:inIncognito:newTab: was called, the
code checked first whether this could be executed. This Change
simplifies slightly the code, and in particular reduces the size of
blocks.
Bug: none
Change-Id: I7c97eb75fcc012be24482d2aafe6038bed7e8599
Auto-Submit: Arthur Milchior <arthurm...@chromium.org>
Commit-Queue: Arthur Milchior <arthurm...@chromium.org>
Reviewed-by: Huiting Yu <huit...@google.com>
Cr-Commit-Position: refs/heads/main@{#1625324}
Files:
- M ios/chrome/browser/bookmarks/ui_bundled/home/bookmarks_home_view_controller.mm
Change size: S
Delta: 1 file changed, 7 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Huiting Yu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages