window management api: asking permission in Clank [chromium/src : main]
0 views
Skip to first unread message
Daniil Hrybchuk (Gerrit)
Jun 11, 2025, 10:44:35 AM6/11/25
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Attention needed from Daniil Hrybchuk
Message from Daniil Hrybchuk![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Daniil Hrybchuk
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Hrybchuk (Gerrit)
Jun 11, 2025, 10:46:28 AM6/11/25
to Elias Klim, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Attention needed from Elias Klim and Nico Weber
Daniil Hrybchuk added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Daniil Hrybchuk . resolved
Hello, could you please take a look at these changes.
Related details
Attention is currently required from:
- Elias Klim
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elias Klim (Gerrit)
Jun 12, 2025, 7:29:55 AM6/12/25
to Daniil Hrybchuk, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Attention needed from Daniil Hrybchuk and Nico Weber
Elias Klim voted and added 2 comments![]( "Open in Gerrit")
Votes added by Elias Klim
| Code-Review | +1 |
2 comments
Patchset-level comments
File components/permissions/contexts/window_management_permission_context.cc
Line 37, Patchset 14 (Latest):
// TODO(crbug.com/40092782): Add window-management support on Android.Elias Klim . unresolved
Do we still need it?
Related details
Attention is currently required from:
- Daniil Hrybchuk
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Hrybchuk (Gerrit)
Jun 12, 2025, 7:37:57 AM6/12/25
to Elias Klim, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Attention needed from Elias Klim and Nico Weber
Daniil Hrybchuk added 1 comment![]( "Open in Gerrit")
File components/permissions/contexts/window_management_permission_context.cc
Line 37, Patchset 14 (Latest):
// TODO(crbug.com/40092782): Add window-management support on Android.Elias Klim . unresolved
Do we still need it?
Daniil Hrybchuk
Yes, because it is under development and clank doesn't support display topology right now.
Related details
Attention is currently required from:
- Elias Klim
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elias Klim (Gerrit)
Jun 12, 2025, 8:22:51 AM6/12/25
to Daniil Hrybchuk, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Attention needed from Daniil Hrybchuk and Nico Weber
Elias Klim added 1 comment![]( "Open in Gerrit")
File components/permissions/contexts/window_management_permission_context.cc
Line 37, Patchset 14 (Latest):
// TODO(crbug.com/40092782): Add window-management support on Android.Elias Klim . resolved
Daniil HrybchukDo we still need it?
Yes, because it is under development and clank doesn't support display topology right now.
Attention is currently required from:
- Daniil Hrybchuk
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Jun 12, 2025, 9:03:01 AM6/12/25
to Daniil Hrybchuk, Nico Weber, Elias Klim, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Attention needed from Daniil Hrybchuk
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
1 comment
Patchset-level comments
Nico Weber . resolved
components/resources/android/permissions_resource_id.h lg
Related details
Attention is currently required from:
- Daniil Hrybchuk
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Hrybchuk (Gerrit)
Jun 12, 2025, 9:05:38 AM6/12/25
to Nico Weber, Elias Klim, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Daniil Hrybchuk voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 12, 2025, 9:08:28 AM6/12/25
to Daniil Hrybchuk, Nico Weber, Elias Klim, AyeAye, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
window management api: asking permission in Clank
Add icon
(https://fonts.corp.google.com/icons?selected=Google+Material+Icons+Filled:select_window:&icon.query=windows&icon.size=24&icon.color=%231f1f1f&icon.set=Google+Material&icon.style=Filled&icon.platform=android)
and string for permission request.
Remove unnecessary
`ContentSettingPermissionContextBase::UserMadePermissionDecision` call
from `WindowManagementPermissionContext::UserMadePermissionDecision`.
All these changes are guarded by `AndroidWindowManagementWebApi` feature
flag.
DD – go/wm-api-clank-dd.
Bug: 422698943
Test: out/{directory}/bin/run_components_unittests --gtest_filter='PermissionManagerTest*'
Change-Id: I2463a8b132454b00b886c034cda3f296e45166b7
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Daniil Hrybchuk <ren...@google.com>
Reviewed-by: Elias Klim <el...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1472997}
Files:
- M chrome/android/javatests/src/org/chromium/chrome/browser/page_info/PageInfoDiscoverabilityTest.java
- M components/permissions/DEPS
- M components/permissions/android/BUILD.gn
- A components/permissions/android/res/drawable/gm_filled_select_window_24.xml
- M components/permissions/contexts/window_management_permission_context.cc
- M components/permissions/permission_manager_unittest.cc
- M components/permissions/permission_request.cc
- M components/permissions/permission_util.cc
- M components/permissions/request_type.cc
- M components/permissions/request_type.h
- M components/permissions_strings.grdp
- A components/permissions_strings_grdp/IDS_WINDOW_MANAGEMENT_INFOBAR_TEXT.png.sha1
- M components/resources/android/permissions_resource_id.h
Change size: M
Delta: 13 files changed, 66 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Elias Klim, +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages