Solomon Kinard (Gerrit)

unread,

7:44 PM (3 hours ago) 7:44 PM

to Enterprise Policy Reviews, chromium...@chromium.org, Javier Fernandez, chromium-a...@chromium.org, kinuko+...@chromium.org, extension...@chromium.org

Solomon Kinard has uploaded the change for review

Commit message

CodeHealth: Fix a few random places to use single quotes or good grammar

Bug: 346952289

Change-Id: I4d3fdcadf19385867bae9fa18fe04167e91418c4

Change diff

Change information

Files:

M base/threading/thread_restrictions.h
M chrome/browser/ash/policy/login/signin_profile_extensions_policy_browsertest.cc
M chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
M chrome/browser/extensions/api/file_system/consent_provider_impl.h
M chrome/browser/extensions/content_verifier_test_utils.h
M chrome/browser/extensions/extension_management_unittest.cc
M chrome/browser/extensions/extension_tab_util.h
M chrome/browser/extensions/external_provider_impl_unittest.cc
M chrome/browser/extensions/initial_external_extension_loader_browsertest.cc
M chrome/browser/extensions/updater/extension_updater.cc
M chrome/browser/policy/extension_policy_browsertest.cc
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc
M components/custom_handlers/protocol_handler.cc
M components/custom_handlers/protocol_handler.h
M components/custom_handlers/protocol_handler_registry.h
M components/custom_handlers/protocol_handler_registry_unittest.cc
M components/custom_handlers/simple_protocol_handler_registry_factory.h
M extensions/browser/pref_names.h
M extensions/common/api/_manifest_features.json
M extensions/common/manifest_test.h
M extensions/test/test_extensions_client.h

Change size: M

Delta: 21 files changed, 28 insertions(+), 31 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Solomon Kinard (Gerrit)

unread,

8:53 PM (2 hours ago) 8:53 PM

to Kyle Charbonneau, chromium...@chromium.org

Attention needed from Kyle Charbonneau

Solomon Kinard has uploaded the change for review

Solomon Kinard would like Kyle Charbonneau to review this change.

Commit message

CodeHealth: Fix a few random places to use single quotes or good grammar

This CL was uploaded by git cl split.

R=kyle...@chromium.org

Bug: 346952289

Change-Id: I16e651a328bd09c4a136ce7686393ddb892ae517

Change diff

diff --git a/base/threading/thread_restrictions.h b/base/threading/thread_restrictions.h
index 6f000c21..016a4499 100644
--- a/base/threading/thread_restrictions.h
+++ b/base/threading/thread_restrictions.h
@@ -691,7 +691,7 @@
   friend base::FilePath printing::GetAbsoluteSystemDestinationLocation(
       const base::FilePath&);
 
-  ScopedAllowBlocking(const Location& from_here = Location::Current());
+  explicit ScopedAllowBlocking(const Location& from_here = Location::Current());
   ~ScopedAllowBlocking();
 
   const AutoReset<BooleanWithOptionalStack> resetter_;

Change information

Files:

M base/threading/thread_restrictions.h

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

Kyle Charbonneau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Solomon Kinard (Gerrit)

unread,

8:53 PM (2 hours ago) 8:53 PM

to Alexander Hendrich, Enterprise Policy Reviews, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Alexander Hendrich

Solomon Kinard has uploaded the change for review

Solomon Kinard would like Alexander Hendrich to review this change.

Commit message

CodeHealth: Fix a few random places to use single quotes or good grammar

This CL was uploaded by git cl split.

R=hend...@chromium.org

Bug: 346952289

Change-Id: I0bd33c882fb18480e86d7adef688c88400e15d1b

Change diff

Change information

Files:

M chrome/browser/ash/policy/login/signin_profile_extensions_policy_browsertest.cc
M chrome/browser/policy/extension_policy_browsertest.cc

Change size: XS

Delta: 2 files changed, 4 insertions(+), 4 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Alexander Hendrich

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Solomon Kinard (Gerrit)

unread,

8:54 PM (2 hours ago) 8:54 PM

to Ben Reich, chromium...@chromium.org, chromium-a...@chromium.org, kinuko+...@chromium.org, extension...@chromium.org

Attention needed from Ben Reich

Solomon Kinard has uploaded the change for review

Solomon Kinard would like Ben Reich to review this change.

Commit message

CodeHealth: Fix a few random places to use single quotes or good grammar

This CL was uploaded by git cl split.

R=benr...@chromium.org

Bug: 346952289

Change-Id: I49435306c4404d1906baac52d56ca8d270987e45

Change diff

diff --git a/chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc b/chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
index 115b911..d0e4d07 100644
--- a/chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
+++ b/chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
@@ -114,7 +114,7 @@
     return false;
 
   // TODO(asargent/benwells) - As a short term remediation for
-  // crbug.com/179010 we're adding the ability for a allowlisted extension to
+  // crbug.com/179010 we're adding the ability for an allowlisted extension to
   // use this API since chrome.fileBrowserHandler.selectFile is ChromeOS-only.
   // Eventually we'd like a better solution and likely this code will go back
   // to being platform-app only.
diff --git a/chrome/browser/extensions/api/file_system/consent_provider_impl.h b/chrome/browser/extensions/api/file_system/consent_provider_impl.h
index d03d047..ed22542f 100644
--- a/chrome/browser/extensions/api/file_system/consent_provider_impl.h
+++ b/chrome/browser/extensions/api/file_system/consent_provider_impl.h
@@ -64,7 +64,7 @@
     // Checks if the extension was launched in auto-launch kiosk mode.
     virtual bool IsAutoLaunched(const Extension& extension) = 0;
 
-    // Checks if the extension is a allowlisted component extension or app.
+    // Checks if the extension is an allowlisted component extension or app.
     virtual bool IsAllowlistedComponent(const Extension& extension) = 0;
   };

Change information

Files:

M chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
M chrome/browser/extensions/api/file_system/consent_provider_impl.h

Change size: XS

Delta: 2 files changed, 2 insertions(+), 2 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Ben Reich

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Solomon Kinard (Gerrit)

unread,

8:55 PM (2 hours ago) 8:55 PM

to Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Devlin Cronin

Solomon Kinard has uploaded the change for review

Solomon Kinard would like Devlin Cronin to review this change.

Commit message

CodeHealth: Fix a few random places to use single quotes or good grammar

This CL was uploaded by git cl split.

R=rdevlin...@chromium.org

Bug: 346952289

Change-Id: I880064b5f6940f333eef1ab6ce003fe2d073b66c

Change diff

Change information

Files:

M chrome/browser/extensions/content_verifier_test_utils.h
M chrome/browser/extensions/extension_management_unittest.cc
M chrome/browser/extensions/extension_tab_util.h
M chrome/browser/extensions/external_provider_impl_unittest.cc
M chrome/browser/extensions/initial_external_extension_loader_browsertest.cc

M extensions/browser/pref_names.h
M extensions/common/manifest_test.h
M extensions/test/test_extensions_client.h

Change size: S

Delta: 8 files changed, 6 insertions(+), 9 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Solomon Kinard (Gerrit)

unread,

8:56 PM (2 hours ago) 8:56 PM

to Sorin Jianu, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Sorin Jianu

Solomon Kinard has uploaded the change for review

Solomon Kinard would like Sorin Jianu to review this change.

Commit message

CodeHealth: Fix a few random places to use single quotes or good grammar

This CL was uploaded by git cl split.

R=so...@chromium.org

Bug: 346952289

Change-Id: Ibc62d44b9a09cb99ee2265c377fa106877c258cc

Change diff

diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/browser/extensions/updater/extension_updater.cc
index b976ad4..c130c60a 100644
--- a/chrome/browser/extensions/updater/extension_updater.cc
+++ b/chrome/browser/extensions/updater/extension_updater.cc
@@ -525,7 +525,7 @@
       // extensions or external component extensions) with foreground fetch
       // priority; otherwise their installation may be throttled by bandwidth
       // limits.
-      // See https://crbug.com/904600 and https://crbug.com/965686.
+      // See https://crbug.com/41425994 and https://crbug.com/41460304.
       const bool is_high_priority_extension_pending =
           pending_extension_manager->HasHighPriorityPendingExtension();
       if (CanUseUpdateService(pending_id)) {

Change information

Files:

M chrome/browser/extensions/updater/extension_updater.cc

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

Sorin Jianu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

CodeHealth: Fix a few random places to use single quotes or good grammar [chromium/src : main]

Solomon Kinard (Gerrit)

Solomon Kinard has uploaded the change for review

Commit message

Change diff

Change information

Related details

Solomon Kinard (Gerrit)

Solomon Kinard has uploaded the change for review

Commit message

Change diff

Change information

Related details

Solomon Kinard (Gerrit)

Solomon Kinard has uploaded the change for review

Commit message

Change diff

Change information

Related details

Solomon Kinard (Gerrit)

Solomon Kinard has uploaded the change for review

Commit message

Change diff

Change information

Related details

Solomon Kinard (Gerrit)

Solomon Kinard has uploaded the change for review

Commit message

Change diff

Change information

Related details

Solomon Kinard (Gerrit)

Solomon Kinard has uploaded the change for review

Commit message

Change diff

Change information

Related details