[ash] mahi: Drop dead chrome/browser/policy include [chromium/src : main]

0 views
Skip to first unread message

Tiago Vignatti (Gerrit)

unread,
Jul 8, 2026, 12:37:37 PM (23 hours ago) Jul 8
to Thanh Nguyen, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Thanh Nguyen

Tiago Vignatti added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tiago Vignatti . resolved

thanhdng@ could you PTAL? Thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • Thanh Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icaa7b1a13e08743f5d22f54f6a5678b8de774eda
Gerrit-Change-Number: 8065664
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Thanh Nguyen <than...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
Gerrit-CC: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Thanh Nguyen <than...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 16:37:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thanh Nguyen (Gerrit)

unread,
Jul 8, 2026, 7:31:16 PM (16 hours ago) Jul 8
to Tiago Vignatti, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Tiago Vignatti

Thanh Nguyen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tiago Vignatti
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icaa7b1a13e08743f5d22f54f6a5678b8de774eda
Gerrit-Change-Number: 8065664
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Thanh Nguyen <than...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
Gerrit-CC: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 23:30:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tiago Vignatti (Gerrit)

unread,
7:59 AM (4 hours ago) 7:59 AM
to Thanh Nguyen, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org

Tiago Vignatti voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icaa7b1a13e08743f5d22f54f6a5678b8de774eda
Gerrit-Change-Number: 8065664
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Thanh Nguyen <than...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
Gerrit-CC: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 11:59:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
8:18 AM (3 hours ago) 8:18 AM
to Tiago Vignatti, Thanh Nguyen, Hidehiko Abe, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ash] mahi: Drop dead chrome/browser/policy include

mahi_availability.cc included
chrome/browser/policy/profile_policy_connector.h but never referenced
ProfilePolicyConnector, so both the include and its DEPS exemption were
dead. Remove them.

#ai-assisted
Bug: 353332589
Change-Id: Icaa7b1a13e08743f5d22f54f6a5678b8de774eda
Reviewed-by: Thanh Nguyen <than...@chromium.org>
Commit-Queue: Tiago Vignatti <tvig...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1659480}
Files:
  • M chrome/browser/ash/mahi/DEPS
  • M chrome/browser/ash/mahi/mahi_availability.cc
Change size: XS
Delta: 2 files changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Thanh Nguyen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icaa7b1a13e08743f5d22f54f6a5678b8de774eda
Gerrit-Change-Number: 8065664
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Vignatti <tvig...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Thanh Nguyen <than...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti <tvig...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages